Skip to contentSkip to conversation

af_key: fix SADB_X_SPDDELETE response

PATCH In review Tobias Brunner 2 participants 4 messages Oct 9, 2008 – Oct 10, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 af_key: fix SADB_X_SPDDELETE response

When deleting an SPD entry using SADB_X_SPDDELETE, c.data.byid is not initialized to zero in pfkey_spddelete(). Thus, key_notify_policy() responds with a PF_KEY message of type SADB_X_SPDDELETE2 instead of SADB_X_SPDDELETE.

net/key/af_key.c +0 -0
@@ -2317,6 +2317,7 @@
 
	c.seq = hdr->sadb_msg_seq;
	c.pid = hdr->sadb_msg_pid;
+	c.data.byid = 0;
	c.event = XFRM_MSG_DELPOLICY;
	km_policy_notify(xp, pol->sadb_x_policy_dir-1, &c);
maintainer
#1 lore raw

From: Tobias Brunner <[email protected]>
Date: Thu, 09 Oct 2008 14:10:21 +0200

Quoted 3 lines

When deleting an SPD entry using SADB_X_SPDDELETE, c.data.byid is not initialized to zero in pfkey_spddelete(). Thus, key_notify_policy() responds with a PF_KEY message of type SADB_X_SPDDELETE2 instead of SADB_X_SPDDELETE.

This patch does not apply cleanly to net-next-2.6, a lot has changed in this area over the past several weeks.

Please respin this so that I can add it, thanks.

#2 lore raw
Quoted 4 lines · David Miller

This patch does not apply cleanly to net-next-2.6, a lot has changed in this area over the past several weeks.

Please respin this so that I can add it, thanks.

Please find the patch for net-next-2.6 below.

Thanks,
Tobias

---

net/key/af_key.c +0 -0
index 362fe31..e55e044 100644
@@ -2341,6 +2341,7 @@ static int pfkey_spddelete(struct sock *sk, struct sk_buff *skb, struct sadb_msg
 
	c.seq = hdr->sadb_msg_seq;
	c.pid = hdr->sadb_msg_pid;
+	c.data.byid = 0;
	c.event = XFRM_MSG_DELPOLICY;
	km_policy_notify(xp, pol->sadb_x_policy_dir-1, &c);
maintainer
#3 lore raw

From: Tobias Brunner <[email protected]>
Date: Fri, 10 Oct 2008 10:23:36 +0200

Quoted 6 lines
Quoted 3 lines · David Miller

This patch does not apply cleanly to net-next-2.6, a lot has changed in this area over the past several weeks. Please respin this so that I can add it, thanks.

Please find the patch for net-next-2.6 below.

Please resubmit:

1) At least CC:'d to the correct mailing list, [email protected]

This is important so that the patch gets tracked at:

http://patchwork.ozlabs.org/project/netdev/list/

2) With full commit log message and signoffs presented again.

Thanks.