USB: remove info() macro from usb network drivers
Subsystems (4)
PATCH 1/1 USB: remove info() macro from usb network drivers
From: Greg Kroah-Hartman <[email protected]>
USB should not be having it's own printk macros, so remove info() and use the system-wide standard of dev_info() wherever possible.
---
Jeff, this has been in the USB tree for a few months now, sorry for not sending it to you sooner. I can easily keep it in my tree and send it to Linus for this merge if you want me to, or you can take it in your tree, which ever you want me to do.
thanks,
greg k-h
drivers/net/irda/kingsun-sir.c | 3 ++- drivers/net/irda/ks959-sir.c | 3 ++- drivers/net/irda/ksdazzle-sir.c | 3 ++- drivers/net/irda/stir4200.c | 8 +++++--- drivers/net/usb/catc.c | 3 ++- drivers/net/usb/kaweth.c | 19 ++++++++++--------- drivers/net/usb/rtl8150.c | 15 +++++++++------ 7 files changed, 32 insertions(+), 22 deletions(-)
drivers/net/irda/kingsun-sir.c +2 -1
@@ -540,7 +540,8 @@ static int kingsun_probe(struct usb_inteif (ret !=0 ) goto free_mem; -info ("IrDA: Registered KingSun/DonShine device %s" , net->name); +dev_info (&net->dev,"IrDA: Registered KingSun/DonShine device %s\n" , + net->name);usb_set_intfdata (intf, kingsun);
drivers/net/irda/ks959-sir.c +2 -1
@@ -801,7 +801,8 @@ static int ks959_probe(struct usb_interfif (ret !=0 ) goto free_mem; -info ("IrDA: Registered KingSun KS-959 device %s" , net->name); +dev_info (&net->dev,"IrDA: Registered KingSun KS-959 device %s\n" , + net->name);usb_set_intfdata (intf, kingsun);
drivers/net/irda/ksdazzle-sir.c +2 -1
@@ -705,7 +705,8 @@ static int ksdazzle_probe(struct usb_intif (ret !=0 ) goto free_mem; -info ("IrDA: Registered KingSun/Dazzle device %s" , net->name); +dev_info (&net->dev,"IrDA: Registered KingSun/Dazzle device %s\n" , + net->name);usb_set_intfdata (intf, kingsun);
drivers/net/irda/stir4200.c +5 -3
@@ -783,8 +783,9 @@ static int stir_transmit_thread(void *arif (unlikely (receive_start (stir))) {if (net_ratelimit ()) -info ("%s: receive usb submit failed" , - stir->netdev->name); +dev_info (&dev->dev, +"%s: receive usb submit failed\n" , + stir->netdev->name); stir->receiving =0 ;msleep (10 );continue ;
@@ -1073,7 +1074,8 @@ static int stir_probe(struct usb_interfaif (ret !=0 ) goto err_out2; -info ("IrDA: Registered SigmaTel device %s" , net->name); +dev_info (&intf->dev,"IrDA: Registered SigmaTel device %s\n" , + net->name);usb_set_intfdata (intf, stir);
drivers/net/usb/catc.c +2 -1
@@ -954,7 +954,8 @@ static int __init catc_init(void) {int result =usb_register (&catc_driver);if (result ==0 ) -info (DRIVER_VERSION " " DRIVER_DESC ); + printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":" +DRIVER_DESC "\n" );return result; }
drivers/net/usb/kaweth.c +10 -9
@@ -1016,10 +1016,10 @@ static int kaweth_probe(*/ if (le16_to_cpu (dev->descriptor.bcdDevice) >>8 ) { -info ("Firmware present in device." ); +dev_info (&intf->dev,"Firmware present in device.\n" ); } else { /* Download the firmware */ - info("Downloading firmware..."); + dev_info(&intf->dev, "Downloading firmware...\n"); kaweth->firmware_buf = (__u8 *)__get_free_page(GFP_KERNEL); if ((result = kaweth_download_firmware(kaweth, "kaweth/new_code.bin",
@@ -1061,7 +1061,7 @@ static int kaweth_probe( }/* Device will now disappear for a moment... */ -info ("Firmware loaded. I'll be back..." ); +dev_info (&intf->dev,"Firmware loaded. I'll be back...\n" ); err_fw:free_page ((unsigned long )kaweth->firmware_buf);free_netdev (netdev);
@@ -1075,10 +1075,10 @@ err_fw: goto err_free_netdev; } -info ("Statistics collection: %x" , kaweth->configuration.statistics_mask); -info ("Multicast filter limit: %x" , kaweth->configuration.max_multicast_filters & ((1 <<15 ) -1 )); -info ("MTU: %d" ,le16_to_cpu (kaweth->configuration.segment_size)); - info("Read MAC address %2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x", +dev_info (&intf->dev,"Statistics collection: %x\n" , kaweth->configuration.statistics_mask); +dev_info (&intf->dev,"Multicast filter limit: %x\n" , kaweth->configuration.max_multicast_filters & ((1 <<15 ) -1 )); +dev_info (&intf->dev,"MTU: %d\n" ,le16_to_cpu (kaweth->configuration.segment_size)); + dev_info(&intf->dev, "Read MAC address %2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x\n", (int)kaweth->configuration.hw_addr[0], (int)kaweth->configuration.hw_addr[1], (int)kaweth->configuration.hw_addr[2],
@@ -1174,7 +1174,8 @@ err_fw: goto err_intfdata; } -info ("kaweth interface created at %s" , kaweth->net->name); +dev_info (&intf->dev,"kaweth interface created at %s\n" , + kaweth->net->name);dbg ("Kaweth probe returning." );
@@ -1205,7 +1206,7 @@ static void kaweth_disconnect(struct usbstruct kaweth_device *kaweth =usb_get_intfdata (intf);struct net_device *netdev; -info ("Unregistering" ); +dev_info (&intf->dev,"Unregistering\n" );usb_set_intfdata (intf,NULL );if (!kaweth) {
drivers/net/usb/rtl8150.c +9 -6
@@ -538,7 +538,8 @@ static void write_bulk_callback(struct uif (!netif_device_present (dev->netdev))return ;if (urb->status) -info ("%s: Tx status %d" , dev->netdev->name, urb->status); +dev_info (&urb->dev->dev,"%s: Tx status %d\n" , + dev->netdev->name, urb->status); dev->netdev->trans_start = jiffies;netif_wake_queue (dev->netdev); }
@@ -561,7 +562,8 @@ static void intr_callback(struct urb *urreturn ;/* -EPIPE: should clear the halt */ default : -info ("%s: intr status %d" , dev->netdev->name, urb->status); +dev_info (&urb->dev->dev,"%s: intr status %d\n" , + dev->netdev->name, urb->status); goto resubmit; }
@@ -710,12 +712,12 @@ static void rtl8150_set_multicast(structnetif_stop_queue (netdev);if (netdev->flags &IFF_PROMISC ) { dev->rx_creg |=cpu_to_le16 (0x0001 ); -info ("%s: promiscuous mode" , netdev->name); +dev_info (&netdev->dev,"%s: promiscuous mode\n" , netdev->name); }else if (netdev->mc_count || (netdev->flags &IFF_ALLMULTI )) { dev->rx_creg &=cpu_to_le16 (0xfffe ); dev->rx_creg |=cpu_to_le16 (0x0002 ); -info ("%s: allmulti set" , netdev->name); +dev_info (&netdev->dev,"%s: allmulti set\n" , netdev->name); }else {/* ~RX_MULTICAST, ~RX_PROMISCUOUS */ dev->rx_creg &=cpu_to_le16 (0x00fc );
@@ -947,7 +949,7 @@ static int rtl8150_probe(struct usb_inte goto out2; } -info ("%s: rtl8150 is detected" , netdev->name); +dev_info (&intf->dev,"%s: rtl8150 is detected\n" , netdev->name);return 0 ;
@@ -984,7 +986,8 @@ static void rtl8150_disconnect(struct usstatic int __init usb_rtl8150_init (void ) { -info (DRIVER_DESC " " DRIVER_VERSION ); + printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":" + DRIVER_DESC "\n");return usb_register (&rtl8150_driver); }
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 17 lines · Greg KH
From: Greg Kroah-Hartman <[email protected]>
USB should not be having it's own printk macros, so remove
info()and use the system-wide standard ofdev_info()wherever possible.Cc Jeff Garzik <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>---
Jeff, this has been in the USB tree for a few months now, sorry for not sending it to you sooner. I can easily keep it in my tree and send it to Linus for this merge if you want me to, or you can take it in your tree, which ever you want me to do.thanks,
greg k-h
Quoted 8 lines
drivers/net/irda/kingsun-sir.c | 3 ++- drivers/net/irda/ks959-sir.c | 3 ++- drivers/net/irda/ksdazzle-sir.c | 3 ++- drivers/net/irda/stir4200.c | 8 +++++--- drivers/net/usb/catc.c | 3 ++- drivers/net/usb/kaweth.c | 19 ++++++++++--------- drivers/net/usb/rtl8150.c | 15 +++++++++------ 7 files changed, 32 insertions(+), 22 deletions(-)
post-vacation ACK, feel free to send via your tree if you wish
Quoted 22 lines · Jeff Garzik
Quoted 12 lines · Greg KH
From: Greg Kroah-Hartman <[email protected]>
USB should not be having it's own printk macros, so removeinfo()and use the system-wide standard ofdev_info()wherever possible.Cc Jeff Garzik <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>---
Jeff, this has been in the USB tree for a few months now, sorry for not sending it to you sooner. I can easily keep it in my tree and send it to Linus for this merge if you want me to, or you can take it in your tree, which ever you want me to do.
thanks,
greg k-hQuoted 8 lines
drivers/net/irda/kingsun-sir.c | 3 ++- drivers/net/irda/ks959-sir.c | 3 ++- drivers/net/irda/ksdazzle-sir.c | 3 ++- drivers/net/irda/stir4200.c | 8 +++++--- drivers/net/usb/catc.c | 3 ++- drivers/net/usb/kaweth.c | 19 ++++++++++--------- drivers/net/usb/rtl8150.c | 15 +++++++++------ 7 files changed, 32 insertions(+), 22 deletions(-)
Quoted 1 line
post-vacation ACK, feel free to send via your tree if you wish
Already did, hope your vacation was nice :)
thanks,
greg k-h