kernel/kallsyms.c: fix double return's

PATCH In review Américo Wang 2 participants 2 messages Oct 10, 2008 – Oct 16, 2008

Share & tools

Américo Wang

author

2008-10-10 09:43 UTC #0 lore raw

PATCH 1/1 kernel/kallsyms.c: fix double return's

Commit 6dd06c9fbe025f542bce4cdb91790c0f91962722 introduced double returns in the function kallsyms_lookup(), it's weird. The second one should be removed.

Signed-off-by WANG Cong <[email protected]>

Cc Rusty Russell <[email protected]>

---

kernel/kallsyms.c +0 -1

index 38fc10a..5072cf1 100644
@@ -260,7 +260,6 @@ const char *kallsyms_lookup(unsigned long addr,
 	/* see if it's in a module */
 	return module_address_lookup(addr, symbolsize, offset, modname,
 				     namebuf);
-	return NULL;
 }
 
 int lookup_symbol_name(unsigned long addr, char *symname)

Rusty Russell

Acked-by on v1 1/1

2008-10-16 11:32 UTC #1 lore raw

Quoted 6 lines · On Friday 10 October 2008 20:43:03 Américo Wang wrote:

Commit 6dd06c9fbe025f542bce4cdb91790c0f91962722 introduced double returns in the function kallsyms_lookup(), it's weird. The second one should be removed.
Signed-off-by WANG Cong <[email protected]>
Cc Rusty Russell <[email protected]>

Yeah, weird.

Acked-by Rusty Russell <[email protected]>

Thanks!
Rusty.