Skip to contentSkip to conversation

Attribution of patches in the git tree...

DISCUSSION Dave Chinner 1 participant 1 message Oct 15, 2008

lore
Share & tools
lore
#0 lore raw

Folks,

Just noticed that all the btree factoring patches in the master tree are attributed to Christoph, even when his patch descriptions gave a different attribution for the source of the patch. e.g:

http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs-2.6.git;a=commit;h=ea8fb246ad5230263f13e45635fad80cc04e28a0

Quoted 10 lines

[XFS] implement generic xfs_btree_increment

From: Dave Chinner <[email protected]>

Because this is the first major generic btree routine this patch includes some infrastrucure, first a few routines to deal with a btree block that can be either in short or long form, second xfs_btree_read_buf_block, which is the new central routine to read a btree block given a cursor, and third the new xfs_btree_ptr_addr routine to calculate the address for a given btree pointer record.

The description has a "From: blah" line indicates the author of the patch was not the person who sent the patch. i.e. the git "author" is incorrect, and the only way to find that out is by looking at the commit description.

In future, can we please get the attribution for patches correct in the git tree so that things like pull requests and historical mining of the trees accurately reflect who the author of the patches really are?

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]