Skip to contentSkip to conversation

remove exports of inline functions

PATCH In review Christoph Hellwig 2 participants 3 messages Oct 6, 2008 – Oct 16, 2008 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove exports of inline functions

Recent gcc starts to complain about exports of functions marked static inline, so let's get rid of those.

fs/xfs/linux-2.6/xfs_ksyms.c +0 -7
Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ksyms.c
===================================================================
@@ -153,8 +153,6 @@
 EXPORT_SYMBOL(kmem_zalloc);
 EXPORT_SYMBOL(kmem_zone_alloc);
 EXPORT_SYMBOL(kmem_zalloc_greedy);
-EXPORT_SYMBOL(kmem_zone_free);
-EXPORT_SYMBOL(kmem_zone_init);
 EXPORT_SYMBOL(kmem_zone_zalloc);
 EXPORT_SYMBOL(xfs_address_space_operations);
 EXPORT_SYMBOL(xfs_dir_file_operations);
@@ -217,8 +215,6 @@
 EXPORT_SYMBOL(xfs_finish_reclaim_all);
 EXPORT_SYMBOL(xfs_freesb);
 EXPORT_SYMBOL(xfs_fs_cmn_err);
-EXPORT_SYMBOL(xfs_highbit32);
-EXPORT_SYMBOL(xfs_highbit64);
 EXPORT_SYMBOL(xfs_idestroy);
 EXPORT_SYMBOL(xfs_iextract);
 EXPORT_SYMBOL(xfs_iext_add);
@@ -227,10 +223,7 @@
 EXPORT_SYMBOL(xfs_iext_idx_to_irec);
 EXPORT_SYMBOL(xfs_iext_insert);
 EXPORT_SYMBOL(xfs_iext_remove);
-EXPORT_SYMBOL(xfs_iflock);
-EXPORT_SYMBOL(xfs_iflock_nowait);
 EXPORT_SYMBOL(xfs_iflush);
-EXPORT_SYMBOL(xfs_ifunlock);
 EXPORT_SYMBOL(xfs_iget);
 EXPORT_SYMBOL(xfs_ilock);
 EXPORT_SYMBOL(xfs_ilock_map_shared);
#1 lore raw
Quoted 2 lines · Christoph Hellwig

Recent gcc starts to complain about exports of functions marked static inline, so let's get rid of those.

note that the complain is in the form of a kernel doesn't link, so any chance we could get this patch in?

Quoted 27 lines

Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ksyms.c
===================================================================

fs/xfs/linux-2.6/xfs_ksyms.c +0 -4
@@ -153,8 +153,6 @@
 EXPORT_SYMBOL(kmem_zalloc);
 EXPORT_SYMBOL(kmem_zone_alloc);
 EXPORT_SYMBOL(kmem_zalloc_greedy);
-EXPORT_SYMBOL(kmem_zone_free);
-EXPORT_SYMBOL(kmem_zone_init);
 EXPORT_SYMBOL(kmem_zone_zalloc);
 EXPORT_SYMBOL(xfs_address_space_operations);
 EXPORT_SYMBOL(xfs_dir_file_operations);
@@ -217,8 +215,6 @@
 EXPORT_SYMBOL(xfs_finish_reclaim_all);
 EXPORT_SYMBOL(xfs_freesb);
 EXPORT_SYMBOL(xfs_fs_cmn_err);
-EXPORT_SYMBOL(xfs_highbit32);
-EXPORT_SYMBOL(xfs_highbit64);
 EXPORT_SYMBOL(xfs_idestroy);
 EXPORT_SYMBOL(xfs_iextract);
 EXPORT_SYMBOL(xfs_iext_add);

fs/xfs/linux-2.6/xfs_ksyms.c line 229

Quoted 10 lines
fs/xfs/linux-2.6/xfs_ksyms.c +0 -3
@@ -227,10 +223,7 @@
 EXPORT_SYMBOL(xfs_iext_idx_to_irec);
 EXPORT_SYMBOL(xfs_iext_insert);
 EXPORT_SYMBOL(xfs_iext_remove);
-EXPORT_SYMBOL(xfs_iflock);
-EXPORT_SYMBOL(xfs_iflock_nowait);
 EXPORT_SYMBOL(xfs_iflush);
-EXPORT_SYMBOL(xfs_ifunlock);
 EXPORT_SYMBOL(xfs_iget);
 EXPORT_SYMBOL(xfs_ilock);
 EXPORT_SYMBOL(xfs_ilock_map_shared);

---end quoted text---

#2 lore raw
Quoted 6 lines · Christoph Hellwig
Quoted 2 lines · Christoph Hellwig

Recent gcc starts to complain about exports of functions marked static inline, so let's get rid of those.

note that the complain is in the form of a kernel doesn't link, so any chance we could get this patch in?

Yes, picking it up now.

Quoted 38 lines
Quoted 26 lines

Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ksyms.c
===================================================================

fs/xfs/linux-2.6/xfs_ksyms.c +0 -4
@@ -153,8 +153,6 @@
 EXPORT_SYMBOL(kmem_zalloc);
 EXPORT_SYMBOL(kmem_zone_alloc);
 EXPORT_SYMBOL(kmem_zalloc_greedy);
-EXPORT_SYMBOL(kmem_zone_free);
-EXPORT_SYMBOL(kmem_zone_init);
 EXPORT_SYMBOL(kmem_zone_zalloc);
 EXPORT_SYMBOL(xfs_address_space_operations);
 EXPORT_SYMBOL(xfs_dir_file_operations);
@@ -217,8 +215,6 @@
 EXPORT_SYMBOL(xfs_finish_reclaim_all);
 EXPORT_SYMBOL(xfs_freesb);
 EXPORT_SYMBOL(xfs_fs_cmn_err);
-EXPORT_SYMBOL(xfs_highbit32);
-EXPORT_SYMBOL(xfs_highbit64);
 EXPORT_SYMBOL(xfs_idestroy);
 EXPORT_SYMBOL(xfs_iextract);
 EXPORT_SYMBOL(xfs_iext_add);

fs/xfs/linux-2.6/xfs_ksyms.c line 229

Quoted 10 lines
fs/xfs/linux-2.6/xfs_ksyms.c +0 -3
@@ -227,10 +223,7 @@
 EXPORT_SYMBOL(xfs_iext_idx_to_irec);
 EXPORT_SYMBOL(xfs_iext_insert);
 EXPORT_SYMBOL(xfs_iext_remove);
-EXPORT_SYMBOL(xfs_iflock);
-EXPORT_SYMBOL(xfs_iflock_nowait);
 EXPORT_SYMBOL(xfs_iflush);
-EXPORT_SYMBOL(xfs_ifunlock);
 EXPORT_SYMBOL(xfs_iget);
 EXPORT_SYMBOL(xfs_ilock);
 EXPORT_SYMBOL(xfs_ilock_map_shared);

---end quoted text---