markers: remove exported symbol marker_probe_cb_noarg()
PATCH 1/1 markers: remove exported symbol marker_probe_cb_noarg()
marker_probe_cb_noarg() should not be seen by outer code. this patch remove it.
Signed-off-by Lai Jiangshan <[email protected]>
---
include/linux/marker.h +0 -2
@@ -137,8 +137,6 @@ extern marker_probe_func __mark_empty_function;extern void marker_probe_cb (const struct marker *mdata,void *call_private, ...); -extern void marker_probe_cb_noarg (const struct marker *mdata, -void *call_private, ...);/* * Connect a probe to a marker.
kernel/marker.c +1 -2
@@ -157,7 +157,7 @@ EXPORT_SYMBOL_GPL(marker_probe_cb);* * Should be connected to markers "MARK_NOARGS". */ -void marker_probe_cb_noarg (const struct marker *mdata,void *call_private, ...) +static void marker_probe_cb_noarg (const struct marker *mdata,void *call_private, ...) {va_list args;/* not initialized */ char ptype;
@@ -197,7 +197,6 @@ void marker_probe_cb_noarg(const struct marker *mdata, void *call_private, ...) }rcu_read_unlock_sched (); } -EXPORT_SYMBOL_GPL (marker_probe_cb_noarg);static void free_old_closure (struct rcu_head *head) {
Quoted 4 lines · * Lai Jiangshan ([email protected]) wrote:
marker_probe_cb_noarg()should not be seen by outer code. this patch remove it.
Yep, good idea. Thanks!
Quoted 40 lines
Signed-off-by Lai Jiangshan <[email protected]>---
include/linux/marker.h +0
-2@@ -137,8 +137,6 @@ extern marker_probe_func __mark_empty_function;extern void marker_probe_cb (const struct marker *mdata,void *call_private, ...); -extern void marker_probe_cb_noarg (const struct marker *mdata, -void *call_private, ...);/* * Connect a probe to a marker. kernel/marker.c +1
-2@@ -157,7 +157,7 @@ EXPORT_SYMBOL_GPL(marker_probe_cb);* * Should be connected to markers "MARK_NOARGS". */ -void marker_probe_cb_noarg (const struct marker *mdata,void *call_private, ...) +static void marker_probe_cb_noarg (const struct marker *mdata,void *call_private, ...) {va_list args;/* not initialized */ char ptype;@@ -197,7 +197,6 @@ void marker_probe_cb_noarg(const struct marker *mdata, void *call_private, ...) }rcu_read_unlock_sched (); } -EXPORT_SYMBOL_GPL (marker_probe_cb_noarg);static void free_old_closure (struct rcu_head *head) {
Signature · 2 lines
Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
Ingo Molnar
AppliedQuoted 9 lines · Mathieu Desnoyers
Quoted 4 lines · * Lai Jiangshan ([email protected]) wrote:
marker_probe_cb_noarg()should not be seen by outer code. this patch remove it.Yep, good idea. Thanks!
applied to tip/tracing/markers, thanks!
Ingo