Skip to contentSkip to conversation

ide: remove broken hpt34x driver

PATCH In review Bartlomiej Zolnierkiewicz 3 participants 3 messages Oct 15, 2008 – Oct 16, 2008 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ide: remove broken hpt34x driver

No big loss since HPT343/363 controllers are properly supported by pata_hpt3x3 driver from Alan Cox.

---
 drivers/ide/Kconfig      |   24 -----
 drivers/ide/pci/Makefile |    1 
 drivers/ide/pci/hpt34x.c |  193 -----------------------------------------------
 3 files changed, 1 insertion(+), 217 deletions(-)
drivers/ide/Kconfig +1 -23
Index: b/drivers/ide/Kconfig
===================================================================
@@ -328,7 +328,7 @@ config IDEPCI_PCIBUS_ORDER
 # TODO: split it on per host driver config options (or module parameters)
 config BLK_DEV_OFFBOARD
 	bool "Boot off-board chipsets first support (DEPRECATED)"
-	depends on BLK_DEV_IDEPCI && (BLK_DEV_AEC62XX || BLK_DEV_GENERIC || BLK_DEV_HPT34X || BLK_DEV_HPT366 || BLK_DEV_PDC202XX_NEW || BLK_DEV_PDC202XX_OLD || BLK_DEV_TC86C001)
+	depends on BLK_DEV_IDEPCI && (BLK_DEV_AEC62XX || BLK_DEV_GENERIC || BLK_DEV_HPT366 || BLK_DEV_PDC202XX_NEW || BLK_DEV_PDC202XX_OLD || BLK_DEV_TC86C001)
 	help
 	  Normally, IDE controllers built into the motherboard (on-board
 	  controllers) are assigned to ide0 and ide1 while those on add-in PCI
@@ -478,28 +478,6 @@ config BLK_DEV_CS5535
 
 	  It is safe to say Y to this question.
 
-config BLK_DEV_HPT34X
-	tristate "HPT34X chipset support"
-	depends on BROKEN
-	select BLK_DEV_IDEDMA_PCI
-	help
-	  This driver adds up to 4 more EIDE devices sharing a single
-	  interrupt. The HPT343 chipset in its current form is a non-bootable
-	  controller; the HPT345/HPT363 chipset is a bootable (needs BIOS FIX)
-	  PCI UDMA controllers. This driver requires dynamic tuning of the
-	  chipset during the ide-probe at boot time. It is reported to support
-	  DVD II drives, by the manufacturer.
-
-config HPT34X_AUTODMA
-	bool "HPT34X AUTODMA support (EXPERIMENTAL)"
-	depends on BLK_DEV_HPT34X && EXPERIMENTAL
-	help
-	  This is a dangerous thing to attempt currently! Please read the
-	  comments at the top of <file:drivers/ide/pci/hpt34x.c>.  If you say Y
-	  here, then say Y to "Use DMA by default when available" as well.
-
-	  If unsure, say N.
-
 config BLK_DEV_HPT366
 	tristate "HPT36X/37X chipset support"
 	select BLK_DEV_IDEDMA_PCI
drivers/ide/pci/Makefile +0 -1
Index: b/drivers/ide/pci/Makefile
===================================================================
@@ -11,7 +11,6 @@ obj-$(CONFIG_BLK_DEV_CS5535)		+= cs5535.
 obj-$(CONFIG_BLK_DEV_SC1200)		+= sc1200.o
 obj-$(CONFIG_BLK_DEV_CY82C693)		+= cy82c693.o
 obj-$(CONFIG_BLK_DEV_DELKIN)		+= delkin_cb.o
-obj-$(CONFIG_BLK_DEV_HPT34X)		+= hpt34x.o
 obj-$(CONFIG_BLK_DEV_HPT366)		+= hpt366.o
 obj-$(CONFIG_BLK_DEV_IT8213)		+= it8213.o
 obj-$(CONFIG_BLK_DEV_IT821X)		+= it821x.o
drivers/ide/pci/hpt34x.c deleted +0 -193

193 lines not on this page · raw message

#1 lore raw

Hello.

Quoted 5 lines · Bartlomiej Zolnierkiewicz

No big loss since HPT343/363 controllers are properly supported by pata_hpt3x3 driver from Alan Cox.

Hum, interesting way of fixing the driver... :-) Shouldn't the PCI IDs be added to drivers/ide/pci/generic.c?

MBR, Sergei

#2 lore raw
Quoted 4 lines · On Thu, 16 Oct 2008 13:48:10 +0400 Sergei Shtylyov <[email protected]>…

Hello.

Bartlomiej Zolnierkiewicz wrote:

Quoted 8 lines
Quoted 5 lines

No big loss since HPT343/363 controllers are properly supported by pata_hpt3x3 driver from Alan Cox.

Hum, interesting way of fixing the driver... :-) Shouldn't the PCI IDs be added to drivers/ide/pci/generic.c?

Won't work. The device isn't actually generic IDE. You have to sort the register mappings out and use the right mapping window for the chip to work.