ath9k: fix oops on trying to hold the wrong spinlock

PATCH In review Luis R. Rodriguez 2 participants 5 messages Oct 16, 2008 Networking drivers (wireless)

Share & tools

Luis R. Rodriguez

author

2008-10-16 18:13 UTC #0 lore raw

PATCH 1/1 ath9k: fix oops on trying to hold the wrong spinlock

This fixes on oops when you get try to send a BA to an 11n AP. The oops occurred because we were trying to aquire an incorrect spinlock.

We were trying to hold the wrong spinlock due to a typo on IEEE80211_BAR_CTL_TID_S's definition. We use this to compute the tid number and then hold this this tid number's spinlock.

Tested-by Steven Noonan <[email protected]>

Signed-off-by Vasanthakumar Thiagarajan <[email protected]>

Signed-off-by Sujith <[email protected]>

Signed-off-by Luis R. Rodriguez <[email protected]>

Signed-off-by John W. Linville <[email protected]>

---

I don't see this queue'd yet for 2.6.27.2

 drivers/net/wireless/ath9k/core.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/net/wireless/ath9k/core.h +1 -1

index 80814c9..5b4f1c4 100644
@@ -309,7 +309,7 @@ void ath_descdma_cleanup(struct ath_softc *sc,
 #define ATH_RX_TIMEOUT           40      /* 40 milliseconds */
 #define WME_NUM_TID              16
 #define IEEE80211_BAR_CTL_TID_M  0xF000  /* tid mask */
-#define IEEE80211_BAR_CTL_TID_S  2       /* tid shift */
+#define IEEE80211_BAR_CTL_TID_S  12      /* tid shift */
 
 enum ATH_RX_TYPE {
 	ATH_RX_NON_CONSUMED = 0,

Signature · 6 lines

1.5.6.rc2.15.g457bb.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Greg KH

2008-10-16 21:57 UTC #1 lore raw

Quoted 9 lines · Luis R. Rodriguez

This fixes on oops when you get try to send a BA to an 11n AP. The oops occurred because we were trying to aquire an incorrect spinlock.
We were trying to hold the wrong spinlock due to a typo on IEEE80211_BAR_CTL_TID_S's definition. We use this to compute the tid number and then hold this this tid number's spinlock.

Quoted 8 lines

Tested-by Steven Noonan <[email protected]>
Signed-off-by Vasanthakumar Thiagarajan <[email protected]>
Signed-off-by Sujith <[email protected]>
Signed-off-by Luis R. Rodriguez <[email protected]>
Signed-off-by John W. Linville <[email protected]>
---
I don't see this queue'd yet for 2.6.27.2

Is it in Linus's tree? If so, do you have a git commit id?

thanks,

greg k-h

Luis R. Rodriguez

author

2008-10-16 23:12 UTC #2 lore raw

Quoted 17 lines · Greg KH

Quoted 16 lines · Luis R. Rodriguez
This fixes on oops when you get try to send a BA to an 11n AP. The oops occurred because we were trying to aquire an incorrect spinlock.
We were trying to hold the wrong spinlock due to a typo on IEEE80211_BAR_CTL_TID_S's definition. We use this to compute the tid number and then hold this this tid number's spinlock.
Tested-by Steven Noonan <[email protected]>
Signed-off-by Vasanthakumar Thiagarajan <[email protected]>
Signed-off-by Sujith <[email protected]>
Signed-off-by Luis R. Rodriguez <[email protected]>
Signed-off-by John W. Linville <[email protected]>
---

Quoted 3 lines

Quoted 1 line
I don't see this queue'd yet for 2.6.27.2
Is it in Linus's tree? If so, do you have a git commit id?

Got it.

a477e4e6d48d3ac7c7a75bad40585cb391e5c237

If you can add the Reported-by tag it'd be great, I missed it on Linus' tree.

Thanks,

Luis

Greg KH

2008-10-16 23:33 UTC #3 lore raw

Quoted 20 lines · Luis R. Rodriguez

Quoted 19 lines · Greg KH
Quoted 17 lines · Luis R. Rodriguez
This fixes on oops when you get try to send a BA to an 11n AP. The oops occurred because we were trying to aquire an incorrect spinlock.
We were trying to hold the wrong spinlock due to a typo on IEEE80211_BAR_CTL_TID_S's definition. We use this to compute the tid number and then hold this this tid number's spinlock.
Tested-by Steven Noonan <[email protected]>
Signed-off-by Vasanthakumar Thiagarajan <[email protected]>
Signed-off-by Sujith <[email protected]>
Signed-off-by Luis R. Rodriguez <[email protected]>
Signed-off-by John W. Linville <[email protected]>
---
I don't see this queue'd yet for 2.6.27.2

Quoted 7 lines

Quoted 1 line
Is it in Linus's tree? If so, do you have a git commit id?
Got it.
a477e4e6d48d3ac7c7a75bad40585cb391e5c237
If you can add the Reported-by tag it'd be great, I missed it on Linus' tree.

You mean the "tested-by" flag? I've added that, I don't see a reported-by flag above.

thanks,

greg k-h

Luis R. Rodriguez

author

2008-10-16 23:41 UTC #4 lore raw

Quoted 23 lines · Greg KH

Quoted 22 lines · Luis R. Rodriguez
Quoted 20 lines · Greg KH
Quoted 9 lines · Luis R. Rodriguez
This fixes on oops when you get try to send a BA to an 11n AP. The oops occurred because we were trying to aquire an incorrect spinlock.
We were trying to hold the wrong spinlock due to a typo on IEEE80211_BAR_CTL_TID_S's definition. We use this to compute the tid number and then hold this this tid number's spinlock.
Quoted 8 lines
Tested-by Steven Noonan <[email protected]>
Signed-off-by Vasanthakumar Thiagarajan <[email protected]>
Signed-off-by Sujith <[email protected]>
Signed-off-by Luis R. Rodriguez <[email protected]>
Signed-off-by John W. Linville <[email protected]>
---
I don't see this queue'd yet for 2.6.27.2
Is it in Linus's tree? If so, do you have a git commit id?

Quoted 8 lines

Quoted 5 lines
Got it.
a477e4e6d48d3ac7c7a75bad40585cb391e5c237
If you can add the Reported-by tag it'd be great, I missed it on Linus' tree.
You mean the "tested-by" flag? I've added that, I don't see a reported-by flag above.

Yeap, tested.

Luis