Skip to contentSkip to conversation

proc: move /proc/kmsg creation to fs/proc/kmsg.c

PATCH In review Alexey Dobriyan 1 participant 1 message Oct 17, 2008 Proc filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 11/31 proc: move /proc/kmsg creation to fs/proc/kmsg.c

Quoted 2 lines

From cc7092760336b7886f9e96631675ff934d9f1e01 Mon Sep 17 00:00:00 2001

From: Alexey Dobriyan <[email protected]>
Date: Sat, 4 Oct 2008 14:39:12 +0400
Subject: [PATCH 11/31] proc: move /proc/kmsg creation to fs/proc/kmsg.c

---
 fs/proc/internal.h  |    1 -
 fs/proc/kmsg.c      |   12 +++++++++---
 fs/proc/proc_misc.c |    3 ---
 3 files changed, 9 insertions(+), 7 deletions(-)
fs/proc/internal.h +0 -1
index d5bf4de..3e8aeb8 100644
@@ -61,7 +61,6 @@ extern const struct file_operations proc_smaps_operations;
 extern const struct file_operations proc_clear_refs_operations;
 extern const struct file_operations proc_pagemap_operations;
 extern const struct file_operations proc_net_operations;
-extern const struct file_operations proc_kmsg_operations;
 extern const struct inode_operations proc_net_inode_operations;
 
 void free_proc_entry(struct proc_dir_entry *de);
fs/proc/kmsg.c +9 -3
index 9fd5df3..7ca7834 100644
@@ -10,13 +10,12 @@
 #include <linux/time.h>
 #include <linux/kernel.h>
 #include <linux/poll.h>
+#include <linux/proc_fs.h>
 #include <linux/fs.h>
 
 #include <asm/uaccess.h>
 #include <asm/io.h>
 
-#include "internal.h"
-
 extern wait_queue_head_t log_wait;
 
 extern int do_syslog(int type, char __user *bug, int count);
@@ -49,9 +48,16 @@ static unsigned int kmsg_poll(struct file *file, poll_table *wait)
 }
 
 
-const struct file_operations proc_kmsg_operations = {
+static const struct file_operations proc_kmsg_operations = {
 	.read		= kmsg_read,
 	.poll		= kmsg_poll,
 	.open		= kmsg_open,
 	.release	= kmsg_release,
 };
+
+static int __init proc_kmsg_init(void)
+{
+	proc_create("kmsg", S_IRUSR, NULL, &proc_kmsg_operations);
+	return 0;
+}
+module_init(proc_kmsg_init);
fs/proc/proc_misc.c +0 -3
index 2dbe0aa..8ae7d38 100644
@@ -607,9 +607,6 @@ void __init proc_misc_init(void)
 	proc_symlink("mounts", NULL, "self/mounts");
 
 	/* And now for trickier ones */
-#ifdef CONFIG_PRINTK
-	proc_create("kmsg", S_IRUSR, NULL, &proc_kmsg_operations);
-#endif
 #ifdef CONFIG_FILE_LOCKING
 	proc_create("locks", 0, NULL, &proc_locks_operations);
 #endif
Signature · 1 line
1.5.6.5