powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards
Subsystems (2)
PATCH 1/2 powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards
The RTC is sitting on the I2C2 bus at address 0x68. RTC interrupt signal is connected to the IPIC's EXT2 interrupt line, the line is shared with Vitesse 8201 Ethernet PHY.
--- arch/powerpc/boot/dts/mpc8349emitx.dts | 8 ++++++++ arch/powerpc/boot/dts/mpc8349emitxgp.dts | 8 ++++++++ 2 files changed, 16 insertions(+), 0 deletions(-)
arch/powerpc/boot/dts/mpc8349emitx.dts +8 -0
@@ -83,6 +83,14 @@ interrupts = <15 0x8>; interrupt-parent = <&ipic>; dfsrr; + + rtc@68 { + device_type = "rtc"; + compatible = "dallas,ds1339"; + reg = <0x68>; + interrupts = <18 0x8>; + interrupt-parent = <&ipic>; + }; }; spi@7000 {
arch/powerpc/boot/dts/mpc8349emitxgp.dts +8 -0
@@ -81,6 +81,14 @@ interrupts = <15 0x8>; interrupt-parent = <&ipic>; dfsrr; + + rtc@68 { + device_type = "rtc"; + compatible = "dallas,ds1339"; + reg = <0x68>; + interrupts = <18 0x8>; + interrupt-parent = <&ipic>; + }; }; spi@7000 {
Signature · 1 line
1.5.6.3
Kumar Gala
AppliedQuoted 9 lines · Anton Vorontsov
The RTC is sitting on the I2C2 bus at address
0x68. RTC interrupt signal is connected to the IPIC's EXT2 interrupt line, the line is shared with Vitesse 8201 Ethernet PHY.Signed-off-by Anton Vorontsov <[email protected]>---
arch/powerpc/boot/dts/mpc8349emitx.dts | 8 ++++++++ arch/powerpc/boot/dts/mpc8349emitxgp.dts | 8 ++++++++ 2 files changed, 16 insertions(+), 0 deletions(-)
applied
- k
Quoted 6 lines · Anton Vorontsov
arch/powerpc/boot/dts/mpc8349emitx.dts +0
-0@@ -83,6 +83,14 @@ interrupts = <15 0x8>;
arch/powerpc/boot/dts/mpc8349emitx.dts line 93
Quoted 10 lines
arch/powerpc/boot/dts/mpc8349emitx.dts +8
-0interrupt-parent = <&ipic>; dfsrr; + + rtc@68 { + device_type = "rtc"; + compatible = "dallas,ds1339"; + reg = <0x68>; + interrupts = <18 0x8>; + interrupt-parent = <&ipic>; + };
Why are we adding more device_types?
-Scott
Quoted 11 lines · Scott Wood
Quoted 10 lines · Anton Vorontsov
arch/powerpc/boot/dts/mpc8349emitx.dts +2
-0@@ -83,6 +83,14 @@ interrupts = <15 0x8>; interrupt-parent = <&ipic>; dfsrr; + + rtc@68 {
Quoted 8 lines
arch/powerpc/boot/dts/mpc8349emitx.dts line 93
Quoted 6 lines
arch/powerpc/boot/dts/mpc8349emitx.dts +6
-0+ device_type = "rtc"; + compatible = "dallas,ds1339"; + reg = <0x68>; + interrupts = <18 0x8>; + interrupt-parent = <&ipic>; + };Why are we adding more
device_types?
I think the 'rtc' device_type is legacy from OF.
- k
Quoted 4 lines · Kumar Gala
Quoted 1 line · Scott Wood
Why are we adding more
device_types?I think the 'rtc'
device_typeis legacy from OF.
Yes, and it advertises a run-time service that we do not and cannot support. We should not have it in flat trees.
-Scott
Quoted 11 lines · Scott Wood
Quoted 10 lines · Anton Vorontsov
arch/powerpc/boot/dts/mpc8349emitx.dts +2
-0@@ -83,6 +83,14 @@ interrupts = <15 0x8>; interrupt-parent = <&ipic>; dfsrr; + + rtc@68 {
Quoted 8 lines
arch/powerpc/boot/dts/mpc8349emitx.dts line 93
Quoted 6 lines
arch/powerpc/boot/dts/mpc8349emitx.dts +6
-0+ device_type = "rtc"; + compatible = "dallas,ds1339"; + reg = <0x68>; + interrupts = <18 0x8>; + interrupt-parent = <&ipic>; + };Why are we adding more
device_types?
It seems that CHRP is using the device_type for rtc devices, which means that real OF also provide it. But I guess we don't need it, right? Then we should cleanup all the boards.