Skip to contentSkip to conversation

powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards

PATCH Applied Anton Vorontsov 3 participants 4 messages Oct 17, 2008 – Dec 3, 2008

Subsystems (2)
Device tree bindings PowerPC
lore
Share & tools
lore

Anton Vorontsov

author
#0 lore raw

PATCH 2/2 powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards

MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to provide soft power-off function, but also exports two GPIOs (wired to the LEDs and also available from the external headers).

Signed-off-by Anton Vorontsov <[email protected]>
---
 arch/powerpc/boot/dts/mpc8315erdb.dts  |    8 ++++++++
 arch/powerpc/boot/dts/mpc8349emitx.dts |    8 ++++++++
 arch/powerpc/boot/dts/mpc8377_rdb.dts  |    8 ++++++++
 arch/powerpc/boot/dts/mpc8378_rdb.dts  |    8 ++++++++
 arch/powerpc/boot/dts/mpc8379_rdb.dts  |    8 ++++++++
 5 files changed, 40 insertions(+), 0 deletions(-)
arch/powerpc/boot/dts/mpc8315erdb.dts +8 -0
index 7449e54..6b85067 100644
@@ -121,6 +121,14 @@
 				compatible = "dallas,ds1339";
 				reg = <0x68>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8315erdb",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		spi@7000 {
arch/powerpc/boot/dts/mpc8349emitx.dts +8 -0
index 7fc5414..4bdbaf4 100644
@@ -91,6 +91,14 @@
 				interrupts = <18 0x8>;
 				interrupt-parent = <&ipic>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8349emitx",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		spi@7000 {
arch/powerpc/boot/dts/mpc8377_rdb.dts +8 -0
index 53191ba..435ef3d 100644
@@ -121,6 +121,14 @@
 				compatible = "dallas,ds1339";
 				reg = <0x68>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8377erdb",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		i2c@3100 {
arch/powerpc/boot/dts/mpc8378_rdb.dts +8 -0
index 4a09153..b11e68f 100644
@@ -121,6 +121,14 @@
 				compatible = "dallas,ds1339";
 				reg = <0x68>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8378erdb",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		i2c@3100 {
arch/powerpc/boot/dts/mpc8379_rdb.dts +8 -0
index bbd884a..337af6e 100644
@@ -121,6 +121,14 @@
 				compatible = "dallas,ds1339";
 				reg = <0x68>;
 			};
+
+			mcu_pio: mcu@a {
+				#gpio-cells = <2>;
+				compatible = "fsl,mc9s08qg8-mpc8379erdb",
+					     "fsl,mcu-mpc8349emitx";
+				reg = <0x0a>;
+				gpio-controller;
+			};
 		};
 
 		i2c@3100 {
Signature · 1 line
1.5.6.3
Applied
#1 lore raw
Quoted 4 lines · Anton Vorontsov

MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to provide soft power-off function, but also exports two GPIOs (wired to the LEDs and also available from the external headers).

Quoted 8 lines
Signed-off-by Anton Vorontsov <[email protected]>

---

arch/powerpc/boot/dts/mpc8315erdb.dts  |    8 ++++++++
arch/powerpc/boot/dts/mpc8349emitx.dts |    8 ++++++++
arch/powerpc/boot/dts/mpc8377_rdb.dts  |    8 ++++++++
arch/powerpc/boot/dts/mpc8378_rdb.dts  |    8 ++++++++
arch/powerpc/boot/dts/mpc8379_rdb.dts  |    8 ++++++++
5 files changed, 40 insertions(+), 0 deletions(-)

applied

- k

#2 lore raw
In reply to Anton Vorontsov
Quoted 5 lines · Anton Vorontsov

MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to provide soft power-off function, but also exports two GPIOs (wired to the LEDs and also available from the external headers).

Signed-off-by Anton Vorontsov <[email protected]>

Kumar, I think you merged this patch incorrectly ...

Quoted 6 lines
arch/powerpc/boot/dts/mpc8349emitx.dts +0 -0
index 7fc5414..4bdbaf4 100644
@@ -91,6 +91,14 @@
                               interrupts = <18 0x8>;

arch/powerpc/boot/dts/mpc8349emitx.dts line 101

Quoted 10 lines
arch/powerpc/boot/dts/mpc8349emitx.dts +8 -0
                               interrupt-parent = <&ipic>;
                       };
+
+                       mcu_pio: mcu@a {
+                               #gpio-cells = <2>;
+                               compatible = "fsl,mc9s08qg8-mpc8349emitx",
+                                            "fsl,mcu-mpc8349emitx";
+                               reg = <0x0a>;
+                               gpio-controller;
+                       };

This node is supposed to go under the I2C node, but you put it under the DMA node.

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
author
#3 lore raw
Quoted 9 lines · Timur Tabi
Quoted 5 lines · Anton Vorontsov

MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to provide soft power-off function, but also exports two GPIOs (wired to the LEDs and also available from the external headers).

Signed-off-by Anton Vorontsov <[email protected]>

Kumar, I think you merged this patch incorrectly ...

[...]

Quoted 2 lines

This node is supposed to go under the I2C node, but you put it under the DMA node.

I've noticed this on the other 'stg pull', when it told me that the patch isn't empty (stg patch becomes empty if merged).

This should be fixed already:

http://ozlabs.org/pipermail/linuxppc-dev/2008-November/065666.html

Anyway, thanks for heads up!

Signature · 3 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2