Skip to contentSkip to conversation

netdev: change name dropping error codes

PATCH Applied Stephen Hemminger 2 participants 2 messages Oct 18, 2008 – Oct 20, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 netdev: change name dropping error codes

If changename notifier returns an error code, it gets incorrectly cleared during rollback so the error is never returned to the user. Found while testing similar code for MTU changes.

Signed-off-by Stephen Hemminger <[email protected]>
net/core/dev.c +3 -3
@@ -924,10 +924,10 @@ int dev_change_name(struct net_device *d
 		strlcpy(dev->name, newname, IFNAMSIZ);
 
 rollback:
-	err = device_rename(&dev->dev, dev->name);
-	if (err) {
+	ret = device_rename(&dev->dev, dev->name);
+	if (ret) {
 		memcpy(dev->name, oldname, IFNAMSIZ);
-		return err;
+		return ret;
 	}
 
 	write_lock_bh(&dev_base_lock);
maintainer Applied
#1 lore raw

From: Stephen Hemminger <[email protected]>
Date: Fri, 17 Oct 2008 21:30:06 -0700

Quoted 5 lines

If changename notifier returns an error code, it gets incorrectly cleared during rollback so the error is never returned to the user. Found while testing similar code for MTU changes.

Signed-off-by Stephen Hemminger <[email protected]>

Applied, thanks Stephen.