Skip to contentSkip to conversation

powerpc: remove device_type = "board-control"

PATCH Applied Anton Vorontsov 3 participants 3 messages Oct 18, 2008 – Oct 20, 2008

Subsystems (3)
Device tree bindings Documentation PowerPC
lore
Share & tools
lore

Anton Vorontsov

author
#0 lore raw

PATCH 1/1 powerpc: remove device_type = "board-control"

We don't want to encourage the bogus device_type usage.

The device type isn't used in the code, so we can simply remove it from the documentation and dts files.

Boards should specify proper compatible entries instead.

Suggested-by David Gibson <[email protected]>
Signed-off-by Anton Vorontsov <[email protected]>

---

On Sat, Oct 11, 2008 at 05:56:18PM +1100, David Gibson wrote:
[...]

Quoted 10 lines

Review

Quoted 6 lines
(quoted diff) +6 -0
+Example:
+
+	bcsr@1,0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		device_type = "board-control";

This device_type field should not be used. I know it is in the existing samples, which is another bug. But please don't document it (and thereby further encourage it).

I didn't forget your comment. ;-) Here is a cleanup patch for the documentation and dts files.

 Documentation/powerpc/dts-bindings/fsl/board.txt |    6 +++---
 arch/powerpc/boot/dts/mpc832x_mds.dts            |    2 +-
 arch/powerpc/boot/dts/mpc834x_mds.dts            |    2 +-
 arch/powerpc/boot/dts/mpc836x_mds.dts            |    2 +-
 arch/powerpc/boot/dts/mpc8568mds.dts             |    2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)
Documentation/powerpc/dts-bindings/fsl/board.txt +3 -3
index e97877f..2bd9888 100644
@@ -2,13 +2,13 @@
 
 Required properties:
 
- - device_type : Should be "board-control"
+ - compatible : Should be "fsl,<board>-bcsr"
  - reg : Offset and length of the register set for the device
 
 Example:
 
 	bcsr@f8000000 {
-		device_type = "board-control";
+		compatible = "fsl,mpc8360mds-bcsr";
 		reg = <f8000000 8000>;
 	};
 

@@ -46,7 +46,7 @@ Example:
 	bcsr@1,0 {
 		#address-cells = <1>;
 		#size-cells = <1>;
-		device_type = "board-control";
+		compatible = "fsl,mpc8360mds-bcsr";
 		reg = <1 0 0x8000>;
 		ranges = <0 1 0 0x8000>;
arch/powerpc/boot/dts/mpc832x_mds.dts +1 -1
index e4cc176..57c595b 100644
@@ -60,7 +60,7 @@
 	};
 
 	bcsr@f8000000 {
-		device_type = "board-control";
+		compatible = "fsl,mpc8323mds-bcsr";
 		reg = <0xf8000000 0x8000>;
 	};
arch/powerpc/boot/dts/mpc834x_mds.dts +1 -1
index 04bfde3..c986c54 100644
@@ -49,7 +49,7 @@
 	};
 
 	bcsr@e2400000 {
-		device_type = "board-control";
+		compatible = "fsl,mpc8349mds-bcsr";
 		reg = <0xe2400000 0x8000>;
 	};
arch/powerpc/boot/dts/mpc836x_mds.dts +1 -1
index bdb14ba..98443fc 100644
@@ -71,7 +71,7 @@
 		bcsr@1,0 {
 			#address-cells = <1>;
 			#size-cells = <1>;
-			device_type = "board-control";
+			compatible = "fsl,mpc8360mds-bcsr";
 			reg = <1 0 0x8000>;
 			ranges = <0 1 0 0x8000>;
arch/powerpc/boot/dts/mpc8568mds.dts +1 -1
index a15f103..c80158f 100644
@@ -52,7 +52,7 @@
 	};
 
 	bcsr@f8000000 {
-		device_type = "board-control";
+		compatible = "fsl,mpc8568mds-bcsr";
 		reg = <0xf8000000 0x8000>;
 	};
Signature · 1 line
1.5.6.3
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Anton Vorontsov

We don't want to encourage the bogus device_type usage.

The device type isn't used in the code, so we can simply remove it from the documentation and dts files.

Boards should specify proper compatible entries instead.

Suggested-by David Gibson <[email protected]>
Signed-off-by Anton Vorontsov <[email protected]>
Acked-by David Gibson <[email protected]>
Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson