Skip to contentSkip to conversation

Don't throw away cmdline parameter

PATCH In review Christoph Egger 2 participants 2 messages Oct 20, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Don't throw away cmdline parameter

Hi,

attach patch avoids throwing away the first cmdline parameter. It contains the dom0 kernel filename.

On NetBSD, this is used to set sysctl.booted_kernel
This sysctl entry is used by the kvm framework
(http://netbsd.gw.com/cgi-bin/man-cgi?kvm+3+NetBSD-current)
and savecore (http://netbsd.gw.com/cgi-bin/man-cgi?savecore+8+NetBSD-current).
The kvm framework is used by almost all system utilities.

Signature · 12 lines
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy

$NetBSD$

arch/x86/setup.c renamed from arch/x86/setup.c.orig +0 -1
@@ -998,7 +998,6 @@ void __init __start_xen(unsigned long mb
     {
         static char dom0_cmdline[MAX_GUEST_CMDLINE];
 
-        cmdline = cmdline_cook(cmdline);
         safe_strcpy(dom0_cmdline, cmdline);
 
         if ( kextra != NULL )

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 10 lines · Christoph Egger

attach patch avoids throwing away the first cmdline parameter. It contains the dom0 kernel filename.

On NetBSD, this is used to set sysctl.booted_kernel
This sysctl entry is used by the kvm framework
(http://netbsd.gw.com/cgi-bin/man-cgi?kvm+3+NetBSD-current)
and savecore (http://netbsd.gw.com/cgi-bin/man-cgi?savecore+8+NetBSD-current).
The kvm framework is used by almost all system utilities.

Doing this would make dom0 start_info format differ from domU start_info format. If an accurate filename is actually useful then I'd consider making an extension to start_info format (e.g., an extra SIF_ flag and use that to indicate an extra string appended to cmd_line[] containing the kernel filename). Or those who do care can explicitly duplicate the filename into the cmdline in their domain config file or bootloader config file.

-- Keir