AT91SAM9263-pm9263-support

PATCH New Ilko Iliev 4 participants 4 messages Oct 20, 2008

Subsystems (4)

Kbuild Memory technology devices (MTD) Arm/Microchip (AT91) SoC support Arm/actions semi architecture

lore

Share & tools

lore

Ilko Iliev

author

2008-10-20 16:24 UTC #0 lore raw

PATCH 1/1 AT91SAM9263-pm9263-support

This patch adds support for the PM9263 board of Ronetix GmbH (www.ronetix.at)

Signed-off-by Ilko Iliev <[email protected]>

---
 MAKEALL                              |    1 +
 Makefile                             |    3 +
 board/ronetix/pm9263/Makefile        |   60 +++++
 board/ronetix/pm9263/config.mk       |    1 +
 board/ronetix/pm9263/led.c           |   68 ++++++
 board/ronetix/pm9263/lowlevel_init.S |  375 
++++++++++++++++++++++++++++++++
 board/ronetix/pm9263/partition.c     |   47 ++++
 board/ronetix/pm9263/pm9263.c        |  393 
++++++++++++++++++++++++++++++++++
 board/ronetix/pm9263/pm9263_nand.c   |   79 +++++++
 common/lcd.c                         |    9 +
 cpu/arm926ejs/at91/lowlevel_init.S   |    6 +-
 drivers/mtd/dataflash.c              |    5 +-
 include/configs/pm9263.h             |  285 ++++++++++++++++++++++++
 tools/Makefile                       |    3 +
 tools/logos/ronetix.bmp              |  Bin 0 -> 5638 bytes
 15 files changed, 1330 insertions(+), 5 deletions(-)
 mode change 100755 => 100644 MAKEALL
 create mode 100644 board/ronetix/pm9263/Makefile
 create mode 100644 board/ronetix/pm9263/config.mk
 create mode 100644 board/ronetix/pm9263/led.c
 create mode 100644 board/ronetix/pm9263/lowlevel_init.S
 create mode 100644 board/ronetix/pm9263/partition.c
 create mode 100644 board/ronetix/pm9263/pm9263.c
 create mode 100644 board/ronetix/pm9263/pm9263_nand.c
 create mode 100644 include/configs/pm9263.h
 create mode 100644 tools/logos/ronetix.bmp

MAKEALL +1 -0

old mode 100755
new mode 100644
index 9ccb9ac..bde7d73
@@ -536,6 +536,7 @@ LIST_at91="		\
 	at91sam9260ek	\
 	at91sam9261ek	\
 	at91sam9263ek	\
+	pm9263	\
 	at91sam9rlek	\
 	cmc_pu2		\
 	csb637		\

Makefile +3 -0

index 9055747..2772dd5 100644
@@ -2493,6 +2493,9 @@ at91sam9261ek_config	:	unconfig
 at91sam9263ek_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9263ek atmel at91
 
+pm9263_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs pm9263 ronetix at91
+
 at91sam9rlek_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9rlek atmel at91

board/ronetix/pm9263/Makefile new file +60 -0

60 lines not on this page · raw message

board/ronetix/pm9263/config.mk new file +1 -0

new file mode 100644
index 0000000..ff2cfd1
@@ -0,0 +1 @@
+TEXT_BASE = 0x23f00000

board/ronetix/pm9263/led.c new file +68 -0

68 lines not on this page · raw message

board/ronetix/pm9263/lowlevel_init.S new file +375 -0

375 lines not on this page · raw message

board/ronetix/pm9263/partition.c new file +47 -0

47 lines not on this page · raw message

board/ronetix/pm9263/pm9263.c new file +393 -0

393 lines not on this page · raw message

board/ronetix/pm9263/pm9263_nand.c new file +79 -0

79 lines not on this page · raw message

common/lcd.c +9 -0

index 25f8664..9f81031 100644
@@ -824,14 +824,23 @@ static void *lcd_logo (void)
 
 #ifdef CONFIG_ATMEL_LCD
 # ifdef CONFIG_LCD_INFO
+
 	sprintf (info, "%s", U_BOOT_VERSION);
 	lcd_drawchars (LCD_INFO_X, LCD_INFO_Y, (uchar *)info, strlen(info));
 
+#ifdef CONFIG_LCD_LOGO_TEXT1
+	sprintf (info, CONFIG_LCD_LOGO_TEXT1);
+#else
 	sprintf (info, "(C) 2008 ATMEL Corp");
+#endif	
 	lcd_drawchars (LCD_INFO_X, LCD_INFO_Y + VIDEO_FONT_HEIGHT,
 					(uchar *)info, strlen(info));
 
+#ifdef CONFIG_LCD_LOGO_TEXT2
+	sprintf (info, CONFIG_LCD_LOGO_TEXT2);
+#else
 	sprintf (info, "at91support at atmel.com");
+#endif	
 	lcd_drawchars (LCD_INFO_X, LCD_INFO_Y + VIDEO_FONT_HEIGHT * 2,
 					(uchar *)info, strlen(info));

cpu/arm926ejs/at91/lowlevel_init.S +3 -3

index ec6ad5d..7882e89 100644
@@ -27,7 +27,7 @@
 #include <config.h>
 #include <version.h>
 
-#ifndef CONFIG_SKIP_LOWLEVEL_INIT
+#if !defined(CONFIG_SKIP_LOWLEVEL_INIT) && !defined(CONFIG_USER_LOWLEVEL_INIT)
 
 .globl lowlevel_init
 lowlevel_init:

@@ -39,5 +39,5 @@ lowlevel_init:
 	mov	pc, lr
 
 	.ltorg
-
-#endif /* CONFIG_SKIP_LOWLEVEL_INIT */
+	
+#endif /* !CONFIG_SKIP_LOWLEVEL_INIT && !CONFIG_USER_LOWLEVEL_INIT */

drivers/mtd/dataflash.c +3 -2

index 049da69..e926b38 100644
@@ -130,8 +130,9 @@ int AT91F_DataflashInit (void)
 			dfcode = 0;
 			break;
 		}
+
 		/* set the last area end to the dataflash size*/
-		area_list[NB_DATAFLASH_AREA -1].end =
+		dataflash_info[i].end_address = 
 				(dataflash_info[i].Device.pages_number *
 				dataflash_info[i].Device.pages_size)-1;

@@ -146,7 +147,7 @@ int AT91F_DataflashInit (void)
 				if(area_list[part].end == 0xffffffff) {
 					dataflash_info[i].Device.area_list[j].end =
 						dataflash_info[i].end_address +
-						dataflash_info	[i].logical_address;
+						dataflash_info[i].logical_address;
 					last_part = 1;
 				} else {
 					dataflash_info[i].Device.area_list[j].end =

include/configs/pm9263.h new file +285 -0

285 lines not on this page · raw message

tools/Makefile +3 -0

index 9e9ee15..fbc64ba 100644
@@ -47,6 +47,9 @@ endif
 ifeq ($(VENDOR),atmel)
 LOGO_BMP= logos/atmel.bmp
 endif
+ifeq ($(VENDOR),ronetix)
+LOGO_BMP= logos/ronetix.bmp
+endif
 
 
 #-------------------------------------------------------------------------

tools/logos/ronetix.bmp new file binary +0 -0

new file mode 100644
index 0000000000000000000000000000000000000000..f956813915c7822ba11a3ab81ad9f48fa2849a5c
GIT binary patch

zc%03cKU~{J6vq!FPL^XEQ4<1A027nM#06YR5|^g at OKA-xvFpaEo7M?2RUxKo5Z8f` zk&)3OBO@bYMn*=D9z8NL_UZmevTPuqe43=c5AXA&)4g|Jo$j7w=AYmmM1|WCii6(= zi-NTwAG^>E=VQ$NLCl!oy3YrH8uDqD^&-u(Udy7W*Rp67MXAM6G#*FscoM~vNt8^c zP%@Q5DQdGQH9L!Dsio0uI*roQvXJKlrL$R-rB;A^Cty{SEfgSU6&1i23M-Hsj#pOD z3RpZ at 1;36~*4JT-Dq07hqJ9&0l&G4Ho<1oRq)#|4)|^G*(%xwzrDSKws&@5j2hYj zU!Z;$?d<NNU21!ftA=*>_Rt>KeqIC)Zn;+_9_*Kub~R~N at X8a_V>{~wF8K&qy2*e zbU^J89ULB_L$FGv4*m!o9a;7cuGPeJMf2f^bY)?<&TfiG1$@3Dfkm;2Y+&cPN-F( z?G#n3RXDbM4OMGk)l*ahU#r)_pP{<t>y&QJw>O~&d}M}8G1<m-%=+&H^IdU$jQ%* zaG>V<efpIqzjeIa%O(6QS(bh==6GeZf-j3idvp#m#6c at n4f8gn3*fnE{j$(4Jy+f zGYdNJIbCuCJj-wl}J!k<?#l*)vy|1x`LBSAuM@?)lrkA+a#&&h7&a-uA)(*E1rn9 zJ_EX#p?2%|Ivf^d+OFtRh;;}XPO2p4YVTjO_!<HAFJy&FioXhCwONX^OqSsSj at eOp zMd26a38DuSPlPmL@rA8q_@>3 at w|XdnHF8s8Q8t1ZmlZxr!X%VWm0>~zUbifg$_cU{ zwZMZbF%MrUWZ#Fwr-*sL3YPA-<kQJU4~xWUmZ==&<12WYu0M8vQ+%NHu#G2;5;Dp7 z6h|!C)kZ$EmqsaCz{Tg++zMq|^T8nn!~wbl*LwJjV0Do=eDZBRdp$NDhC3zY}^Mq zpSD>F%CEKjk0cq|f2QVZ(H3bMqWNl2LqCbjLMVf<-YsIG7Dz7cw|A?Q^_w(vL~ z&N<7IJNAxB1<YwOiM1lZsO57eB?eGR7#OzC&!buB5CF;_lnu$41+QoH4F8^X2Ja zaLf9*{2_cMUvmD*PQHqzK3xR4_>AlJ?BN;m-h5?^WtGz;id#S5i}}bJ=j!0wUXD4{ z#^Ez=ICy+By$_#xgWWyscG8dC=gU9q^(}eM_%|{WlZUqw5y4W&+Hd?SP^*d!<XU( ztQ+q6I&P>hTv#n#!bcWdczkI!@{O7?vG#nLvmGwyTf{!L_+Ak&pFNgQa&;#BC!84 zA;10M;lqh>F?;@N^Urd*=d0%Bd>yw)QRP!b at 9Bg2@|>a2lHg>^eC*V!!}Pq517} z0qem)bsaS><C7CcnD346h?~zEUD5K-neqj*iBE0dTN3L}>MoJLzl{tI+z~U#H=p-~ z3Co~8aVcMFhL<j02sz)DRcGKG<B^L43JH9OlDIeP#0ItH{vMP-N^c7W9JlgnI0V zcUIKmCG}aJy2jp3;c^2X>@~RsAEA6Qy_Y3x*)l#eDe&YGgRFdM;Q<TP!GRT~)dg zwr*>pds at 8TZaxsYA9B6l)L4M6FH!6TA6e6|qCL$tYMCxF+>^;X*6B-w@)@64}wWT zUJf$6p~1+HJn1}U#mkn?0i}6SJY3&^?7WZiPt&d%f!n^itt#lS7M7|874d~Q$D>< zym6HUi2L)-z>om^nP(l9#QT>kiUnWB{#<B~G|A?VojBj$4j;+jrX}r85F<u6Rsu#z z6L@~M$XA91;K0yJzHX!Pd3<K99V=d8DO4hh5<ipsoNC_(pSBYJJu at da1-b+u1Mtll zTo7+ux$;C@yo!V0KEH#HI=*C&fz1*!(JasLt*L)U##&Bf#IKy8{ep!$HHjHp-6 zmtV<{9F#GE7hbiKJc$Uv$k%UKQ^|kJ&DZbnS<~Aj+FE8>bNz52M!CGPA*RzTU8L7= zTWL$q-fcdWtMLd0DQ!op2l6*^-jgj_YpPD%7Yv?-K}r$MeIHDgtz5laiN%~FCU-J zs*_MxraaAW?%JF9j%Z7?iSjJI!c=+jWAj;clGT+)*_+tmGvnT$YKmHF3jEJiRQ<UY z&0-S|-nE;Io`zZnRpgWWXC|9(*~~Ywi;w7C?uvTl>JMhi$WNq4bdL;-xtjDBj(*oa QD;*(Q_XdWChX=;~1zg+&lK=n!

literal 0
Hc$@<O00001

-- 1.5.2.2

Wolfgang Denk

2008-10-20 18:29 UTC #1 lore raw

PATCH 1/1 AT91SAM9263-pm9263-support

Dear Ilko Iliev,

Quoted 5 lines · In message <[email protected]> you wrote:

This patch adds support for the PM9263 board of Ronetix GmbH (www.ronetix.at)
Signed-off-by Ilko Iliev <[email protected]>

Quoted 8 lines

---
 MAKEALL                              |    1 +
 Makefile                             |    3 +
 board/ronetix/pm9263/Makefile        |   60 +++++
 board/ronetix/pm9263/config.mk       |    1 +
 board/ronetix/pm9263/led.c           |   68 ++++++
 board/ronetix/pm9263/lowlevel_init.S |  375

++++++++++++++++++++++++++++++++

Ouch - line wrapped?

Quoted 3 lines

 board/ronetix/pm9263/partition.c     |   47 ++++
 board/ronetix/pm9263/pm9263.c        |  393

++++++++++++++++++++++++++++++++++

Ditto?

MAKEALL LIST_at91=" \ · line 542

Quoted 10 lines

MAKEALL +1 -0

@@ -536,6 +536,7 @@ LIST_at91="		\
 	at91sam9260ek	\
 	at91sam9261ek	\
 	at91sam9263ek	\
+	pm9263	\
 	at91sam9rlek	\
 	cmc_pu2		\
 	csb637		\

Please keep lists sorted, and vertical alignment of the backslashes intact.

Makefile at91sam9261ek_config : unconfig · line 2498

Quoted 11 lines

Makefile +3 -0

index 9055747..2772dd5 100644
@@ -2493,6 +2493,9 @@ at91sam9261ek_config	:	unconfig
 at91sam9263ek_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9263ek atmel at91
 
+pm9263_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs pm9263 ronetix at91
+

Please keep lists sorted.

Quoted 3 lines

Makefile +0 -0

 at91sam9rlek_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm926ejs at91sam9rlek atmel at91

...

Quoted 3 lines

board/ronetix/pm9263/led.c new file +0 -0
@@ -0,0 +1,68 @@

...

board/ronetix/pm9263/led.c line 56

Quoted 7 lines

board/ronetix/pm9263/led.c new file +7 -0

+void green_LED_off(void)
+{
+	at91_set_gpio_value(GREEN_LED, 1);
+}
+
+
+

Too many empty lines. One should be sufficient here.

Quoted 6 lines

board/ronetix/pm9263/lowlevel_init.S new file +0 -0
new file mode 100644
index 0000000..de240b7
@@ -0,0 +1,375 @@

...

board/ronetix/pm9263/lowlevel_init.S line 72

Quoted 3 lines

board/ronetix/pm9263/lowlevel_init.S new file +3 -0

+#define PIOD_PDR_VAL1 0xFFFF0000	/* define PDC[31:16] as DATA[31:16] */
+#define PIOD_PPUDR_VAL 0xFFFF0000	/* no pull-up for D[31:16] */
+#define MATRIX_EBI0CSA_VAL 0x0001010A	/* EBI0_CSA, CS1 SDRAM, CS3 NAND Flash,	3.3V memories */

Maximum line length exceeded. Actually many lines are too long, but here it is obvious.

common/lcd.c static void *lcd_logo (void) · line 828

Quoted 10 lines

common/lcd.c +1 -0

index 25f8664..9f81031 100644
@@ -824,14 +824,23 @@ static void *lcd_logo (void)
 
 #ifdef CONFIG_ATMEL_LCD
 # ifdef CONFIG_LCD_INFO
+
 	sprintf (info, "%s", U_BOOT_VERSION);

Please do not change common files witout need, and without even mentioning it!

common/lcd.c static void *lcd_logo (void) · line 837

Quoted 9 lines

common/lcd.c +4 -0

 	lcd_drawchars (LCD_INFO_X, LCD_INFO_Y, (uchar *)info, strlen(info));
 
+#ifdef CONFIG_LCD_LOGO_TEXT1
+	sprintf (info, CONFIG_LCD_LOGO_TEXT1);
+#else
 	sprintf (info, "(C) 2008 ATMEL Corp");
+#endif	
 	lcd_drawchars (LCD_INFO_X, LCD_INFO_Y + VIDEO_FONT_HEIGHT,
 					(uchar *)info, strlen(info));

This change is unrelated to your board support. Please split it out into a separate patch.

common/lcd.c static void *lcd_logo (void) · line 843

Quoted 5 lines

common/lcd.c +4 -0

+#ifdef CONFIG_LCD_LOGO_TEXT2
+	sprintf (info, CONFIG_LCD_LOGO_TEXT2);
+#else
 	sprintf (info, "at91support at atmel.com");
+#endif

Ditto.

And instead of the #idfef's in the code, please consider something like this:

#ifndef CONFIG_LCD_LOGO_TEXT2

# define CONFIG_LCD_LOGO_TEXT2 "at91support at atmel.com"
#endif
...
	sprintf (info, CONFIG_LCD_LOGO_TEXT2);

Same for above.

cpu/arm926ejs/at91/lowlevel_init.S line 30

Quoted 10 lines

cpu/arm926ejs/at91/lowlevel_init.S +1 -1

index ec6ad5d..7882e89 100644
@@ -27,7 +27,7 @@
 #include <config.h>
 #include <version.h>
 
-#ifndef CONFIG_SKIP_LOWLEVEL_INIT
+#if !defined(CONFIG_SKIP_LOWLEVEL_INIT) && !defined(CONFIG_USER_LOWLEVEL_INIT)

This is unrelated to your board support, so please split it out into a separate patch.

drivers/mtd/dataflash.c int AT91F_DataflashInit (void) · line 134

Quoted 10 lines

drivers/mtd/dataflash.c +1 -0

index 049da69..e926b38 100644
@@ -130,8 +130,9 @@ int AT91F_DataflashInit (void)
 			dfcode = 0;
 			break;
 		}
+
 		/* set the last area end to the dataflash size*/

Please don;t change common files without need.

drivers/mtd/dataflash.c int AT91F_DataflashInit (void) · line 135

Quoted 2 lines

drivers/mtd/dataflash.c +1 -1

-		area_list[NB_DATAFLASH_AREA -1].end =
+		dataflash_info[i].end_address =

This change is unrelated to you board support and affects all boards. Modifications by this must explicitely mentioned in the description and discussed.

Quoted 6 lines

include/configs/pm9263.h new file +0 -0
new file mode 100644
index 0000000..1646e9f
@@ -0,0 +1,285 @@

...

include/configs/pm9263.h line 127

Quoted 2 lines

include/configs/pm9263.h new file +2 -0
+/* NOR flash, if populated */
+#if 0

Please do not add dead code.

include/configs/pm9263.h line 259

Quoted 5 lines

include/configs/pm9263.h new file +5 -0

+#define CONFIG_IPADDR		192.168.3.222
+#define CONFIG_GATEWAYIP	192.168.3.1
+#define CONFIG_ETHADDR		02:DE:AD:BE:EF:01
+#define CONFIG_NETMASK		255.255.255.0
+#define CONFIG_SERVERIP		192.168.3.1

Please never encode network paramters in the default environment. Delete this.

Best regards,

Wolfgang Denk

Signature · 7 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How many seconds are there in a year? If I tell you there are 3.155 x
10^7, you won't even try to remember it. On the other hand, who could
forget that, to within half a percent, pi seconds is  a  nanocentury.
                                               -- Tom Duff, Bell Labs

Robert Schwebel

2008-10-20 19:41 UTC #2 lore raw

PATCH 1/1 AT91SAM9263-pm9263-support

In reply to Ilko Iliev

Quoted 2 lines · Ilko Iliev

This patch adds support for the PM9263 board of Ronetix GmbH (www.ronetix.at)

Please note that u-boot-v2 has also a port for the PM9263:
http://git.denx.de/?p=u-boot/u-boot-v2.git;a=summary

Marc, you may also have some comments about the posted patches.

rsc

Signature · 5 lines

 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

Jean-Christophe PLAGNIOL-VILLARD

2008-10-20 20:07 UTC #3 lore raw

PATCH 1/1 AT91SAM9263-pm9263-support

In reply to Ilko Iliev

Quoted 26 lines · Ilko Iliev

This patch adds support for the PM9263 board of Ronetix GmbH (www.ronetix.at)

Signed-off-by Ilko Iliev <[email protected]>

---
 MAKEALL                              |    1 +
 Makefile                             |    3 +
 board/ronetix/pm9263/Makefile        |   60 +++++
 board/ronetix/pm9263/config.mk       |    1 +
 board/ronetix/pm9263/led.c           |   68 ++++++
 board/ronetix/pm9263/lowlevel_init.S |  375 
++++++++++++++++++++++++++++++++
 board/ronetix/pm9263/partition.c     |   47 ++++
 board/ronetix/pm9263/pm9263.c        |  393 
++++++++++++++++++++++++++++++++++
 board/ronetix/pm9263/pm9263_nand.c   |   79 +++++++
 common/lcd.c                         |    9 +
 cpu/arm926ejs/at91/lowlevel_init.S   |    6 +-
 drivers/mtd/dataflash.c              |    5 +-
 include/configs/pm9263.h             |  285 ++++++++++++++++++++++++
 tools/Makefile                       |    3 +
 tools/logos/ronetix.bmp              |  Bin 0 -> 5638 bytes
 15 files changed, 1330 insertions(+), 5 deletions(-)
 mode change 100755 => 100644 MAKEALL
 create mode 100644 board/ronetix/pm9263/Makefile

Quoted 9 lines

 create mode 100644 board/ronetix/pm9263/config.mk
 create mode 100644 board/ronetix/pm9263/led.c
 create mode 100644 board/ronetix/pm9263/lowlevel_init.S
 create mode 100644 board/ronetix/pm9263/partition.c
 create mode 100644 board/ronetix/pm9263/pm9263.c
 create mode 100644 board/ronetix/pm9263/pm9263_nand.c
 create mode 100644 include/configs/pm9263.h
 create mode 100644 tools/logos/ronetix.bmp

Hi,
I'd like to notice that I've plan to modify the at91 board support in order to reduce duplicate code that I've seen more and more with the adding of new board.

Of course I will review your patch but please keep in mind that the current may need to be updated against this new common part.

Best Regards,
J.