pci: use pci_ioremap_bar() in drivers/misc

PATCH New Arjan van de Ven 1 participant 1 message Oct 21, 2008

Subsystems (2)

Char and misc drivers TI flash media memorystick/MMC drivers

lore

Share & tools

lore

Arjan van de Ven

author

2008-10-21 04:52 UTC #0 lore raw

PATCH 1/1 pci: use pci_ioremap_bar() in drivers/misc

Quoted 1 line

From 24499136286bd94ed96f938bd59442a6e0723903 Mon Sep 17 00:00:00 2001

From: Arjan van de Ven <[email protected]>
Date: Sun, 28 Sep 2008 16:15:14 -0700
Subject: [PATCH] pci: use pci_ioremap_bar() in drivers/misc

Use the newly introduced pci_ioremap_bar() function in drivers/misc. pci_ioremap_bar() just takes a pci device and a bar number, with the goal of making it really hard to get wrong, while also having a central place to stick sanity checks.

Signed-off-by Arjan van de Ven <[email protected]>

---
 drivers/misc/ibmasm/module.c |    3 +--
 drivers/misc/tifm_7xx1.c     |    3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

drivers/misc/ibmasm/module.c +1 -2

index b5f6add..dc14b0b 100644
@@ -104,8 +104,7 @@ static int __devinit ibmasm_init_one(struct pci_dev *pdev, const struct pci_devi
 	}
 
 	sp->irq = pdev->irq;
-	sp->base_address = ioremap(pci_resource_start(pdev, 0),
-					pci_resource_len(pdev, 0));
+	sp->base_address = pci_ioremap_bar(pdev, 0);
 	if (!sp->base_address) {
 		dev_err(sp->dev, "Failed to ioremap pci memory\n");
 		result =  -ENODEV;

drivers/misc/tifm_7xx1.c +1 -2

index 67503ea..af61733 100644
@@ -354,8 +354,7 @@ static int tifm_7xx1_probe(struct pci_dev *dev,
 	fm->has_ms_pif = tifm_7xx1_has_ms_pif;
 	pci_set_drvdata(dev, fm);
 
-	fm->addr = ioremap(pci_resource_start(dev, 0),
-			   pci_resource_len(dev, 0));
+	fm->addr = pci_ioremap_bar(dev, 0);
 	if (!fm->addr)
 		goto err_out_free;

Signature · 8 lines

1.5.5.1



-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org