declare vmlist to fix ia64 build breakage in kexec core
PATCH 1/1 declare vmlist to fix ia64 build breakage in kexec core
Commit acd99dbf54020f5c80b9aa2f2ea86f43cb285b02 (kdump: add vmlist.addr to vmcoreinfo for x86 vmalloc translation) broke the ia64 build in this fashion:
kernel/kexec.c: In function `crash_save_vmcoreinfo_init':kernel/kexec.c:1374: error: `vmlist' undeclared (first use in this function) kernel/kexec.c:1374: error: (Each undeclared identifier is reported only once kernel/kexec.c:1374: error: for each function it appears in.) kernel/kexec.c:1410: error: dereferencing pointer to incomplete type make[1]: *** [kernel/kexec.o] Error 1
Adding the proper include fixes the build.
---
kernel/kexec.c +1 -0
@@ -30,6 +30,7 @@#include <linux/pm.h> #include <linux/cpu.h> #include <linux/console.h> +#include <linux/vmalloc.h> #include <asm/page.h> #include <asm/uaccess.h>
Oh whoops, I see that Tony Luck already sent a patch for this directly to Linus.
[Sorry for the noise, but I didn't realize this until I decided to browse through my lkml folder, as Tony's patch hasn't been pushed out yet.]
/ac
* Alex Chiang <[email protected]>:
Quoted 33 lines
Commit
acd99dbf54020f5c80b9aa2f2ea86f43cb285b02(kdump: add vmlist.addr to vmcoreinfo for x86 vmalloc translation) broke the ia64 build in this fashion:
kernel/kexec.c: In function `crash_save_vmcoreinfo_init':kernel/kexec.c:1374: error: `vmlist' undeclared (first use in this function)kernel/kexec.c:1374: error: (Each undeclared identifier is reported only oncekernel/kexec.c:1374: error: for each function it appears in.)kernel/kexec.c:1410: error: dereferencing pointer to incomplete type make[1]: *** [kernel/kexec.o] Error 1Adding the proper include fixes the build.
Signed-off-by Alex Chiang <[email protected]>---
kernel/kexec.c +1
-1@@ -30,6 +30,7 @@#include <linux/pm.h> #include <linux/cpu.h> #include <linux/console.h> +#include <linux/vmalloc.h> #include <asm/page.h> #include <asm/uaccess.h> --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Alex, Tony,
Quoted 2 lines · Alex Chiang
Oh whoops, I see that Tony Luck already sent a patch for this directly to Linus.
Thank you for fixing a bug contained in my patch.
Thanks
Ken'ichi Ohmichi
Quoted 41 lines
[Sorry for the noise, but I didn't realize this until I decided to browse through my lkml folder, as Tony's patch hasn't been pushed out yet.]
/ac
* Alex Chiang <[email protected]>:
Quoted 33 lines
Commit
acd99dbf54020f5c80b9aa2f2ea86f43cb285b02(kdump: add vmlist.addr to vmcoreinfo for x86 vmalloc translation) broke the ia64 build in this fashion:
kernel/kexec.c: In function `crash_save_vmcoreinfo_init':kernel/kexec.c:1374: error: `vmlist' undeclared (first use in this function)kernel/kexec.c:1374: error: (Each undeclared identifier is reported only oncekernel/kexec.c:1374: error: for each function it appears in.)kernel/kexec.c:1410: error: dereferencing pointer to incomplete type make[1]: *** [kernel/kexec.o] Error 1Adding the proper include fixes the build.
Signed-off-by Alex Chiang <[email protected]>---
kernel/kexec.c +1
-1@@ -30,6 +30,7 @@#include <linux/pm.h> #include <linux/cpu.h> #include <linux/console.h> +#include <linux/vmalloc.h> #include <asm/page.h> #include <asm/uaccess.h> --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/