Skip to contentSkip to conversation

Fix kexec compile error, undeclared 'vmlist'

PATCH In review Jens Axboe 1 participant 2 messages Oct 21, 2008 kexec

lore
Share & tools
lore

Jens Axboe

author
#0 lore raw

PATCH 1/1 Fix kexec compile error, undeclared 'vmlist'

Hi,

Current -git fails to compile, at least on ppc:

kernel/kexec.c: In function 'crash_save_vmcoreinfo_init':
kernel/kexec.c:1374: error: 'vmlist' undeclared (first use in this function) kernel/kexec.c:1374: error: (Each undeclared identifier is reported only once kernel/kexec.c:1374: error: for each function it appears in.) kernel/kexec.c:1410: error: invalid use of undefined type 'struct vm_struct'

It's missing a vmalloc.h include, introduced by
acd99dbf54020f5c80b9aa2f2ea86f43cb285b02.

Signed-off-by Jens Axboe <[email protected]>
kernel/kexec.c +1 -0
index 777ac45..ac0fde7 100644
@@ -30,6 +30,7 @@
 #include <linux/pm.h>
 #include <linux/cpu.h>
 #include <linux/console.h>
+#include <linux/vmalloc.h>
 
 #include <asm/page.h>
 #include <asm/uaccess.h>
Signature · 1 line
Jens Axboe
author
#1 lore raw
Quoted 20 lines · Jens Axboe

Hi,

Current -git fails to compile, at least on ppc:

kernel/kexec.c: In function 'crash_save_vmcoreinfo_init':
kernel/kexec.c:1374: error: 'vmlist' undeclared (first use in this function) kernel/kexec.c:1374: error: (Each undeclared identifier is reported only once kernel/kexec.c:1374: error: for each function it appears in.) kernel/kexec.c:1410: error: invalid use of undefined type 'struct vm_struct'

It's missing a vmalloc.h include, introduced by
acd99dbf54020f5c80b9aa2f2ea86f43cb285b02.

Signed-off-by Jens Axboe <[email protected]>
kernel/kexec.c +0 -0
index 777ac45..ac0fde7 100644

kernel/kexec.c line 36

Quoted 7 lines
kernel/kexec.c +1 -0
@@ -30,6 +30,7 @@
 #include <linux/pm.h>
 #include <linux/cpu.h>
 #include <linux/console.h>
+#include <linux/vmalloc.h>
 
 #include <asm/page.h>
 #include <asm/uaccess.h>

So this was already fixed and pushed out by Tony, so nevermind the extra noise. Apparently I had pulled this morning just before, so missed the last few changes.

Signature · 1 line
Jens Axboe