Skip to contentSkip to conversation

fork.c: fix a problem of code style

PATCH In review Jianjun Kong 4 participants 4 messages Oct 21, 2008 – Oct 29, 2008

Subsystems (3)
MM core Scheduler exec and binfmt
lore
Share & tools
lore

Jianjun Kong

author
#0 lore raw

PATCH 1/1 fork.c: fix a problem of code style

fix a problem of code style

Signed-off-by Jianjun Kong <[email protected]>
---
 kernel/fork.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/fork.c +1 -1
index 30de644..b6e5a94 100644
@@ -187,7 +187,7 @@ void __init fork_init(unsigned long mempages)
 	/*
 	 * we need to allow at least 20 threads to boot a system
 	 */
-	if(max_threads < 20)
+	if (max_threads < 20)
 		max_threads = 20;
 
 	init_task.signal->rlim[RLIMIT_NPROC].rlim_cur = max_threads/2;
Signature · 6 lines
1.5.2.5

-- 
Jianjun Kong | Happy Hacking
HomePage: http://kongove.cn
Gtalk: [email protected]
#2 lore raw
In reply to Jianjun Kong

kernel/fork.c void __init fork_init(unsigned long mempages) · line 190

Quoted 2 lines · Jianjun Kong
kernel/fork.c +1 -1
-	if(max_threads < 20)
+	if (max_threads < 20)

I thought we didn't bother with trivial style changes like this.

maintainer
#3 lore raw
Quoted 5 lines · On Wed, 22 Oct 2008 03:02:21 +1030 David Newall <[email protected]> wrote:

kernel/fork.c void __init fork_init(unsigned long mempages) · line 190

Quoted 2 lines · Jianjun Kong
kernel/fork.c +1 -1
-	if(max_threads < 20)
+	if (max_threads < 20)

I thought we didn't bother with trivial style changes like this.

Yes, it's too small:

akpm:/usr/src/25> perl scripts/checkpatch.pl --file kernel/fork.c | grep total
total: 34 errors, 13 warnings, 1689 lines checked

We could merge thousands and thousand of one-line patches like this and it's all very inefficient.

I'd consider larger patches which cleaned up whole subdirectories. They're not much fun to maintain but we don't regret these things after we've done them.