Skip to contentSkip to conversation

ppc4xx: New board avnet fx12 minimodule <v2>

PATCH New Georg Schardt 3 participants 8 messages Oct 22, 2008 – Oct 24, 2008 Kbuild

lore
Share & tools
lore

Georg Schardt

author
#0 lore raw

PATCH 1/1 ppc4xx: New board avnet fx12 minimodule <v2>

From: schardt <[email protected]>

this patch adds support for the avnet fx12 minimodul
it needs the "ppc4xx: Generic architecture for xilinx ppc405" patch from Ricardo

<v2>
rebased to ppc4xx/master

Signed-off-by schardt <[email protected]>
Signed-off-by Ricardo Ribalda Delgado <[email protected]>
---
 MAINTAINERS                      |    4 +
 MAKEALL                          |    1 +
 Makefile                         |   18 +++++
 board/avnet/fx12mm/.gitignore    |    1 +
 board/avnet/fx12mm/Makefile      |   27 +++++++
 board/avnet/fx12mm/config.mk     |   26 +++++++
 board/avnet/fx12mm/fx12mm.c      |   52 +++++++++++++
 board/avnet/fx12mm/init.S        |   32 ++++++++
 board/avnet/fx12mm/u-boot.lds    |  149 ++++++++++++++++++++++++++++++++++++++
 board/avnet/fx12mm/xparameters.h |   51 +++++++++++++
 include/configs/fx12mm.h         |   72 ++++++++++++++++++
 11 files changed, 433 insertions(+), 0 deletions(-)
 create mode 100644 board/avnet/fx12mm/.gitignore
 create mode 100644 board/avnet/fx12mm/Makefile
 create mode 100644 board/avnet/fx12mm/config.mk
 create mode 100644 board/avnet/fx12mm/fx12mm.c
 create mode 100644 board/avnet/fx12mm/init.S
 create mode 100644 board/avnet/fx12mm/u-boot.lds
 create mode 100644 board/avnet/fx12mm/xparameters.h
 create mode 100644 include/configs/fx12mm.h
MAINTAINERS +4 -0
index a5d1038..260c3e6 100644
@@ -366,6 +366,10 @@ Travis Sawyer (travis.sawyer at sandburst.com>
 	METROBOX	PPC440GX
 	XPEDITE1K	PPC440GX
 
+Georg Schardt <[email protected]>
+
+	fx12mm		PPC405
+
 Heiko Schocher <[email protected]>
 
 	ids8247		MPC8247
MAKEALL +1 -0
index aa602b7..1f56ac5 100755
@@ -186,6 +186,7 @@ LIST_4xx="		\
 	ebony		\
 	ERIC		\
 	EXBITGEN	\
+	fx12mm		\
 	G2000		\
 	glacier		\
 	haleakala	\
Makefile +18 -0
index 66922eb..d6abb4d 100644
@@ -1293,6 +1293,24 @@ ERIC_config:	unconfig
 EXBITGEN_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx exbitgen
 
+fx12mm_flash_config: unconfig
+	@mkdir -p $(obj)include $(obj)board/xilinx/ppc405-generic
+	@mkdir -p $(obj)include $(obj)board/avnet/fx12mm
+	@echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc405-generic/u-boot-rom.lds"\
+		> $(obj)board/avnet/fx12mm/config.tmp
+	@echo "TEXT_BASE := 0xFFCB0000" \
+		>> $(obj)board/avnet/fx12mm/config.tmp
+	@$(MKCONFIG) fx12mm ppc ppc4xx fx12mm avnet
+
+fx12mm_config: unconfig
+	@mkdir -p $(obj)include $(obj)board/xilinx/ppc405-generic
+	@mkdir -p $(obj)include $(obj)board/avnet/fx12mm
+	@echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc405-generic/u-boot-ram.lds"\
+		> $(obj)board/avnet/fx12mm/config.tmp
+	@echo "TEXT_BASE := 0x03000000" \
+		>> $(obj)board/avnet/fx12mm/config.tmp
+	@$(MKCONFIG) fx12mm ppc ppc4xx fx12mm avnet
+
 G2000_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx g2000
board/avnet/fx12mm/.gitignore new file +1 -0
new file mode 100644
index 0000000..b644f59
@@ -0,0 +1 @@
+config.tmp
board/avnet/fx12mm/Makefile new file +27 -0
new file mode 100644
index 0000000..f943781
@@ -0,0 +1,27 @@
+#
+# (C) Copyright 2008
+# Ricardo Ribalda,Universidad Autonoma de Madrid, ricardo.ribalda at uam.es
+# This work has been supported by: Qtechnology http://qtec.com/
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+COBJS	+= $(BOARD).o
+
+include $(SRCTREE)/board/xilinx/ppc405-generic/Makefile
board/avnet/fx12mm/config.mk new file +26 -0
new file mode 100644
index 0000000..f5a6039
@@ -0,0 +1,26 @@
+#
+# (C) Copyright 2008
+# Ricardo Ribalda-Universidad Autonoma de Madrid-ricardo.ribalda at uam.es
+# Work supported by Qtechnology http://www.qtec.com
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+#
+
+sinclude $(SRCTREE)/board/xilinx/ppc405-generic/config.mk
board/avnet/fx12mm/fx12mm.c new file +52 -0

52 lines not on this page · raw message

board/avnet/fx12mm/init.S new file +32 -0
new file mode 100644
index 0000000..c05a211
@@ -0,0 +1,32 @@
+/*
+ * (C) Copyright 2008
+ *
+ * Georg Schardt <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ *
+ */
+
+	.globl ext_bus_cntlr_init
+ext_bus_cntlr_init:
+	blr
+
+	.globl sdram_init
+sdram_init:
+	blr
board/avnet/fx12mm/u-boot.lds new file +149 -0

149 lines not on this page · raw message

board/avnet/fx12mm/xparameters.h new file +51 -0

51 lines not on this page · raw message

include/configs/fx12mm.h new file +72 -0

72 lines not on this page · raw message

Signature · 1 line
1.5.4.1
#1 lore raw

PATCH 1/1 ppc4xx: New board avnet fx12 minimodule <v2>

Quoted 8 lines · Georg Schardt

From: schardt <[email protected]>

this patch adds support for the avnet fx12 minimodul
it needs the "ppc4xx: Generic architecture for xilinx ppc405" patch from Ricardo

<v2>
rebased to ppc4xx/master

Thanks. Another comment below.

Quoted 24 lines
Signed-off-by schardt <[email protected]>
Signed-off-by Ricardo Ribalda Delgado <[email protected]>
---
 MAINTAINERS                      |    4 +
 MAKEALL                          |    1 +
 Makefile                         |   18 +++++
 board/avnet/fx12mm/.gitignore    |    1 +
 board/avnet/fx12mm/Makefile      |   27 +++++++
 board/avnet/fx12mm/config.mk     |   26 +++++++
 board/avnet/fx12mm/fx12mm.c      |   52 +++++++++++++
 board/avnet/fx12mm/init.S        |   32 ++++++++
 board/avnet/fx12mm/u-boot.lds    |  149
++++++++++++++++++++++++++++++++++++++ board/avnet/fx12mm/xparameters.h |  
51 +++++++++++++
 include/configs/fx12mm.h         |   72 ++++++++++++++++++
 11 files changed, 433 insertions(+), 0 deletions(-)
 create mode 100644 board/avnet/fx12mm/.gitignore
 create mode 100644 board/avnet/fx12mm/Makefile
 create mode 100644 board/avnet/fx12mm/config.mk
 create mode 100644 board/avnet/fx12mm/fx12mm.c
 create mode 100644 board/avnet/fx12mm/init.S
 create mode 100644 board/avnet/fx12mm/u-boot.lds
 create mode 100644 board/avnet/fx12mm/xparameters.h
 create mode 100644 include/configs/fx12mm.h

<snip>

Quoted 28 lines
board/avnet/fx12mm/init.S new file +22 -0
new file mode 100644
index 0000000..c05a211
@@ -0,0 +1,32 @@
+/*
+ * (C) Copyright 2008
+ *
+ * Georg Schardt <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA

board/avnet/fx12mm/init.S line 32

Quoted 10 lines
board/avnet/fx12mm/init.S new file +10 -0
+ *
+ */
+
+	.globl ext_bus_cntlr_init
+ext_bus_cntlr_init:
+	blr
+
+	.globl sdram_init
+sdram_init:
+	blr

This file is not needed anymore. Please remove it.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#2 lore raw

PATCH 1/1 ppc4xx: New board avnet fx12 minimodule <v2>

In reply to Georg Schardt
Quoted 7 lines · Georg Schardt

From: schardt <[email protected]>

this patch adds support for the avnet fx12 minimodul
it needs the "ppc4xx: Generic architecture for xilinx ppc405" patch from Ricardo

<v2>
rebased to ppc4xx/master

The above two^Wfour lines should go *below* the "---", they are remarks WRT the patch, not really a commit comment for posterity. Ahh, also the line "it needs the "ppc4xx: Generic architecture for xilinx ppc405" patch from Ricardo" should go below the "---".

Also, s/minimodul/minimodule/ unless it really *is* spelled w/o the "e".

While we are critiquing the English, sentences start with capital letters and end with periods, as in "This patch adds support for the avnet fx12 minimodule."

WRT the subject line, the <v2> should go *inside* the [PATCH v2] so it doesn't get included in the git repository comment.

Quoted 3 lines
Signed-off-by schardt <[email protected]>
Signed-off-by Ricardo Ribalda Delgado <[email protected]>

---

Put your remarks here.

Quoted 11 lines
 MAINTAINERS                      |    4 +
 MAKEALL                          |    1 +
 Makefile                         |   18 +++++
 board/avnet/fx12mm/.gitignore    |    1 +
 board/avnet/fx12mm/Makefile      |   27 +++++++
 board/avnet/fx12mm/config.mk     |   26 +++++++
 board/avnet/fx12mm/fx12mm.c      |   52 +++++++++++++
 board/avnet/fx12mm/init.S        |   32 ++++++++
 board/avnet/fx12mm/u-boot.lds    |  149 ++++++++++++++++++++++++++++++++++++++
 board/avnet/fx12mm/xparameters.h |   51 +++++++++++++
 include/configs/fx12mm.h         |   72 ++++++++++++++++++

[snip]

The bike shed is blue today.

Thanks,
gvb

author
#3 lore raw

PATCH 1/1 ppc4xx: New board avnet fx12 minimodule <v2>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jerry,

thx for your comments, i will pay attention on the right patch format the next time. It is my first project I send patches to and until now, git is not my best friend.

Sorry for my poor english, it is not my native language and i dont know that this is a problem here.

Georg

Quoted 41 lines · Jerry Van Baren
Quoted 7 lines · Georg Schardt

From: schardt <[email protected]>

this patch adds support for the avnet fx12 minimodul it needs the "ppc4xx: Generic architecture for xilinx ppc405" patch from Ricardo

<v2> rebased to ppc4xx/master

The above two^Wfour lines should go *below* the "---", they are remarks WRT the patch, not really a commit comment for posterity. Ahh, also the line "it needs the "ppc4xx: Generic architecture for xilinx ppc405" patch from Ricardo" should go below the "---".

Also, s/minimodul/minimodule/ unless it really *is* spelled w/o the
"e".

While we are critiquing the English, sentences start with capital letters and end with periods, as in "This patch adds support for the avnet fx12 minimodule."

WRT the subject line, the <v2> should go *inside* the [PATCH v2] so
it doesn't get included in the git repository comment.

Quoted 2 lines
Signed-off-by schardt <[email protected]> Signed-off-by:

Ricardo Ribalda Delgado <[email protected]> ---

Put your remarks here.

Quoted 11 lines

MAINTAINERS | 4 + MAKEALL

|    1 + Makefile                         |   18 +++++
board/avnet/fx12mm/.gitignore    |    1 +
board/avnet/fx12mm/Makefile      |   27 +++++++
board/avnet/fx12mm/config.mk     |   26 +++++++
board/avnet/fx12mm/fx12mm.c      |   52 +++++++++++++
board/avnet/fx12mm/init.S        |   32 ++++++++
board/avnet/fx12mm/u-boot.lds    |  149
++++++++++++++++++++++++++++++++++++++
board/avnet/fx12mm/xparameters.h |   51 +++++++++++++
include/configs/fx12mm.h         |   72 ++++++++++++++++++
Quoted 5 lines

[snip]

The bike shed is blue today.

Thanks, gvb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkj/Hl0ACgkQUicxT/v10ZuYQwCdFQ4wFp4N2lyeTy01PPpEHnjd kGgAniHDR2OxkXkbljMi/EU+5vKvVK9p
=n6XX
-----END PGP SIGNATURE-----

#4 lore raw

PATCH 1/1 ppc4xx: New board avnet fx12 minimodule <v2>

Quoted 8 lines · Georg Schardt

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jerry,

thx for your comments, i will pay attention on the right patch format the next time. It is my first project I send patches to and until now, git is not my best friend.

Oh, but it will be. ;-) Git and open source development is optimized for getting something done and relying on the rest of the world (list) to critique the changes to get things done "right." Note that this isn't just mentoring, it goes beyond correcting minor mistakes and becomes that magic known as *collaboration.*

In my day job, our change control system is optimized to get things done "right": it spends an enormous amount of energy (and money) to prevent anything "wrong" from being done. While this is intuitive and appeals to the PHBs, the actual effect is that the change management system is optimized to *prevent* change. If nothing changes, nothing will break (worse), therefore it is "optimal," assuming the proper definition of "optimal." Aaargh!

Quoted 2 lines

Sorry for my poor english, it is not my native language and i dont know that this is a problem here.

To my shame, your English is a far cry better than my German, so you have nothing to apologize for there.

Your English isn't a big problem. I mainly threw it in because I was critiquing other stuff. OTOH, if nobody corrects errors (English, comments, content), nobody would learn how to do things better.

Quoted 1 line

Georg

Best regards,
gvb

#5 lore raw

PATCH 1/1 ppc4xx: New board avnet fx12 minimodule <v2>

In reply to Georg Schardt

Georg,

Quoted 3 lines · Georg Schardt

thx for your comments, i will pay attention on the right patch format the next time. It is my first project I send patches to and until now, git is not my best friend.

Do you plan to send an updated patch version soon?

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

author
#6 lore raw

PATCH 1/1 ppc4xx: New board avnet fx12 minimodule <v2>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Sorry, i was very busy on my dayjob this week. I will send a new patch this evening.

Georg

Quoted 9 lines · Stefan Roese

Georg,

Quoted 3 lines · Georg Schardt

thx for your comments, i will pay attention on the right patch format the next time. It is my first project I send patches to and until now, git is not my best friend.

Do you plan to send an updated patch version soon?

Quoted 8 lines

Best regards, Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev
Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80
Email: office at denx.de
=====================================================================

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkBrAoACgkQUicxT/v10ZvJLQCfQLB2hjc9vw+XMT6cIGygh2Rx sBgAnjBq2LT9elQo2WvJPEWDEbIuUAk+
=T00n
-----END PGP SIGNATURE-----

#7 lore raw

PATCH 1/1 ppc4xx: New board avnet fx12 minimodule <v2>

Quoted 2 lines · Georg Schardt

Sorry, i was very busy on my dayjob this week. I will send a new patch this evening.

No need to apologize. I was just checking that I didn't miss anything.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================