Skip to contentSkip to conversation

wierd new config options

DISCUSSION Christoph Hellwig 5 participants 6 messages Oct 23, 2008 – Nov 11, 2008

lore
Share & tools
lore
#0 lore raw

Why is UNEVICTABLE_LRU and option? Is there any rason to turn it off or is this just to confuse users?

CORE_DUMP_DEFAULT_ELF_HEADERS is similarly odd, it turns something on that break old userspace, this really really should be a sysctl to turn on instead of a config option.

#1 lore raw
Quoted 2 lines · Christoph Hellwig

Why is UNEVICTABLE_LRU and option? Is there any rason to turn it off or is this just to confuse users?

We discussed this back when we first submitted the patches. I considered the NONRECLAIMABLE/UNEVICTABLE LRU mechanism to be a wee bit experimental at the time. I wasn't sure that all platform that do want memory management would necessarily also want the unevictable lru. It's easier for me to build it with the option and remove it later than vice versa. If the consensus of the community is that it should always be enabled, then I'm fine with removing the option.

Lee

Quoted 4 lines

CORE_DUMP_DEFAULT_ELF_HEADERS is similarly odd, it turns something on that break old userspace, this really really should be a sysctl to turn on instead of a config option.

#2 lore raw
Quoted 5 lines · Lee Schermerhorn
Quoted 2 lines · Christoph Hellwig

Why is UNEVICTABLE_LRU and option? Is there any rason to turn it off or is this just to confuse users?

Quoted 7 lines

We discussed this back when we first submitted the patches. I considered the NONRECLAIMABLE/UNEVICTABLE LRU mechanism to be a wee bit experimental at the time. I wasn't sure that all platform that do want memory management would necessarily also want the unevictable lru. It's easier for me to build it with the option and remove it later than vice versa. If the consensus of the community is that it should always be enabled, then I'm fine with removing the option.

The problem is that average admin can't make useful judgement on
this: active pageout lists -- what the hell is it?, kswapd -- ok, I remember this process from ps(1) output, "will not waste" -- ok, good thing, "will use one page flag" -- how many more I have?, what will happen if they emptied?

And distro kernel maintainer should also make a decision -- not a module, after all.

#3 lore raw
In reply to Christoph Hellwig
Quoted 2 lines · Christoph Hellwig

Why is UNEVICTABLE_LRU and option? Is there any rason to turn it off or is this just to confuse users?

Since the swapout code itself is already configurable with CONFIG_SWAP, I do believe we want to be able to config out the unevictable LRU code.

I guess it could be argued that maybe CONFIG_UNEVICTABLE_LRU should just be folded into CONFIG_SWAP...

Signature · 1 line
All Rights Reversed
#4 lore raw
Quoted 10 lines · Rik van Riel
Quoted 2 lines · Christoph Hellwig

Why is UNEVICTABLE_LRU and option? Is there any rason to turn it off or is this just to confuse users?

Since the swapout code itself is already configurable with CONFIG_SWAP, I do believe we want to be able to config out the unevictable LRU code.

I guess it could be argued that maybe CONFIG_UNEVICTABLE_LRU should just be folded into CONFIG_SWAP...

Sounds like a good plan.

#5 lore raw
In reply to Christoph Hellwig
Quoted 3 lines

CORE_DUMP_DEFAULT_ELF_HEADERS is similarly odd, it turns something on that break old userspace, this really really should be a sysctl to turn on instead of a config option.

Both the kconfig help text and the commit's log mention that this is controlled per-process via /proc/PID/coredump_filter. The new config option only changes the boot-time default value to be inherited.

Thanks,
Roland