git-svn: change dashed git-config to git config
PATCH 1/1 git-svn: change dashed git-config to git config
---
When testing git-svn changes, I'll often use git-svn.perl directly on a repository of mine, to see how things work. Recently I had this happen:
$ git-svn.perl info Use of uninitialized value in scalar chomp at ../git/git-svn.perl line 1202. Use of uninitialized value in concatenation (.) or string at ../git/git-svn.perl line 1203.
but the expected output showed up correctly, giving the SVN-like info.
git svn info appeared to work just fine though, despite there being essentially no difference between the two. However, if I do the following, this is what I see:
$ env /usr/libexec/git-core/git-svn info Can't exec "git-config": No such file or directory at /usr/libexec/git-core/git-svn line 1202. Use of uninitialized value in scalar chomp at /usr/libexec/git-core/git-svn line 1202.
Again, the SVN info would still appear.
Regardless, I think we want to change this call to use the non-dashed form.
Deskin Miller
git-svn.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
git-svn.perl +1 -1
@@ -1126,7 +1126,7 @@ sub read_repo_config { my $v = $opts->{$o}; my ($key) = ($o =~ /^([a-zA-Z\-]+)/); $key =~ s/-//g; - my $arg = 'git-config'; + my $arg = 'git config'; $arg .= ' --int' if ($o =~ /[:=]i$/); $arg .= ' --bool' if ($o !~ /[:=][sfi]$/); if (ref $v eq 'ARRAY') {
Signature · 1 line
1.6.0.2.554.g3041b
Quoted 14 lines · Deskin Miller
---
When testing git-svn changes, I'll often use git-svn.perl directly on a repository of mine, to see how things work. Recently I had this happen:$ git-svn.perl info Use of uninitialized value in scalar chomp at ../git/git-svn.perl line 1202. Use of uninitialized value in concatenation (.) or string at ../git/git-svn.perl line 1203.but the expected output showed up correctly, giving the SVN-like info.
git svn info appeared to work just fine though, despite there being essentially no difference between the two. However, if I do the following, this is what I see:
Quoted 7 lines
$ env /usr/libexec/git-core/git-svn info Can't exec "git-config": No such file or directory at /usr/libexec/git-core/git-svn line 1202. Use of uninitialized value in scalar chomp at /usr/libexec/git-core/git-svn line 1202.Again, the SVN info would still appear.
Regardless, I think we want to change this call to use the non-dashed form.
Thanks Deskin,
Quoted 20 lines
Deskin Miller
git-svn.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)git-svn.perl +1
-1@@ -1126,7 +1126,7 @@ sub read_repo_config { my $v = $opts->{$o}; my ($key) = ($o =~ /^([a-zA-Z\-]+)/); $key =~ s/-//g; - my $arg = 'git-config'; + my $arg = 'git config'; $arg .= ' --int' if ($o =~ /[:=]i$/); $arg .= ' --bool' if ($o !~ /[:=][sfi]$/); if (ref $v eq 'ARRAY') {Signature · 1 line
1.6.0.2.554.g3041b
Quoted 19 lines · Eric Wong
Quoted 18 lines · Deskin Miller
---
When testing git-svn changes, I'll often use git-svn.perl directly on a repository of mine, to see how things work. Recently I had this happen:$ git-svn.perl info Use of uninitialized value in scalar chomp at ../git/git-svn.perl line 1202. Use of uninitialized value in concatenation (.) or string at ../git/git-svn.perl line 1203.but the expected output showed up correctly, giving the SVN-like info.
git svn info appeared to work just fine though, despite there being essentially no difference between the two. However, if I do the following, this is what I see:
$ env /usr/libexec/git-core/git-svn info Can't exec "git-config": No such file or directory at /usr/libexec/git-core/git-svn line 1202. Use of uninitialized value in scalar chomp at /usr/libexec/git-core/git-svn line 1202.
Quoted 7 lines
Quoted 3 lines
Again, the SVN info would still appear.
Regardless, I think we want to change this call to use the non-dashed form.
Thanks Deskin,
Acked-by Eric Wong <[email protected]>
Sorry, patch should have had a
Feel free to forge it.
Quoted 20 lines
Quoted 20 lines
Deskin Miller
git-svn.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)git-svn.perl +1
-1@@ -1126,7 +1126,7 @@ sub read_repo_config { my $v = $opts->{$o}; my ($key) = ($o =~ /^([a-zA-Z\-]+)/); $key =~ s/-//g; - my $arg = 'git-config'; + my $arg = 'git config'; $arg .= ' --int' if ($o =~ /[:=]i$/); $arg .= ' --bool' if ($o !~ /[:=][sfi]$/); if (ref $v eq 'ARRAY') {Signature · 1 line
1.6.0.2.554.g3041b