Skip to contentSkip to conversation

Adding empia base driver

PATCH NAK Markus Rechberger 2 participants 4 messages Oct 22, 2008 – Oct 24, 2008 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/7 Adding empia base driver

em2880-dvb:
* supporting the digital part of Empia based devices, which
includes ATSC, ISDB-T and DVB-T

em28xx-aad.c:
* alternative audio driver, can be used instead of em28xx-audio if
alsa is not available
or not compiled into the kernel, it provides a raw interface to
the PCM samples

em28xx-audio.c:
* em28xx alsa driver and audio driver for FM radio

em28xx-audioep.c:
* em28xx alsa driver for devices which are set to vendor specific
audio on interface 1,
in that case snd-usb-audio will not attach to the interface and
em28xx-audioep will be needed

em28xx-cards.c:
* card definition and initial setup of devices.

em28xx-core.c:
* core videohandling and VBI frame slicing

em28xx-i2c.c:
* i2c setup and GPIO setup handling of the devices (including
em2888 based ones)

em28xx-input.c:
* currently mostly disabled since the linuxtv input handling is
broken by design and racy

em28xx-keymaps.c:
* keymap references of some remotes (could be merged into
ir-common, although as mentioned
this should be in userland done by lirc).

em28xx-video.c:
* inode handling for analog TV, radio and VBI, also some device probing

em28xx-webcam.c:
* videology webcam specific i2c commands

commit a18816f6b91629eb6038aed4815e4fb94ddc0a6b

Author: Markus Rechberger <[email protected]>
Date:   Wed Oct 22 21:56:45 2008 +0200

Adding empia base driver

em2880-dvb:
* supporting the digital part of Empia based devices, which includes ATSC, ISDB-T and DVB-T

em28xx-aad.c:
* alternative audio driver, can be used instead of em28xx-audio if alsa is not available or not compiled into the kernel, it provides a raw interface to the PCM samples

em28xx-audio.c:
* em28xx alsa driver and audio driver for FM radio

em28xx-audioep.c:
* em28xx alsa driver for devices which are set to vendor specific audio on interface 1, in that case snd-usb-audio will not attach to the interface and em28xx-audioep will be needed

em28xx-cards.c:
* card definition and initial setup of devices.

em28xx-core.c:
* core videohandling and VBI frame slicing

em28xx-i2c.c:
* i2c setup and GPIO setup handling of the devices (including em2888 based ones)

em28xx-input.c:
* currently mostly disabled since the linuxtv input handling is broken by design and racy

em28xx-keymaps.c:
* keymap references of some remotes (could be merged into ir-common, although as mentioned this should be in userland done by lirc).

em28xx-video.c:
* inode handling for analog TV, radio and VBI, also some device probing

em28xx-webcam.c:
* videology webcam specific i2c commands

drivers/media/video/Kconfig +2 -0
index 47102c2..a726c59 100644
@@ -783,6 +783,8 @@ source "drivers/media/video/pvrusb2/Kconfig"
 
 source "drivers/media/video/em28xx/Kconfig"
 
+source "drivers/media/video/empia/Kconfig"
+
 source "drivers/media/video/usbvision/Kconfig"
 
 source "drivers/media/video/usbvideo/Kconfig"
drivers/media/video/Makefile +1 -0
index 16962f3..9357368 100644
@@ -64,6 +64,7 @@ obj-$(CONFIG_VIDEO_MEYE) += meye.o
 obj-$(CONFIG_VIDEO_SAA7134) += saa7134/
 obj-$(CONFIG_VIDEO_CX88) += cx88/
 obj-$(CONFIG_VIDEO_EM28XX) += em28xx/
+obj-$(CONFIG_VIDEO_EMPIA) += empia/
 obj-$(CONFIG_VIDEO_USBVISION) += usbvision/
 obj-$(CONFIG_VIDEO_TVP5150) += tvp5150.o
 obj-$(CONFIG_VIDEO_PVRUSB2) += pvrusb2/
drivers/media/video/empia/Kconfig new file +61 -0

61 lines not on this page · raw message

drivers/media/video/empia/Makefile new file +19 -0
new file mode 100644
index 0000000..9ee2376
@@ -0,0 +1,19 @@
+em28xx-objs     := em28xx-video.o em28xx-i2c.o em28xx-cards.o em28xx-core.o \
+		   em28xx-input.o em28xx-webcam.o em28xx-keymaps.o
+
+em28xx-dvb-objs   := em2880-dvb.o 
+
+obj-$(CONFIG_VIDEO_EMPIA) += em28xx.o
+obj-$(CONFIG_VIDEO_EMPIA_AUDIO) += em28xx-audio.o
+obj-$(CONFIG_VIDEO_EMPIA_AUDIOEP) += em28xx-audioep.o
+obj-$(CONFIG_VIDEO_EMPIA_AAD_AUDIO) += em28xx-aad.o
+obj-$(CONFIG_VIDEO_EMPIA_DTV) += em28xx-dvb.o
+obj-$(CONFIG_VIDEO_EMPIA) += cx25843/
+obj-$(CONFIG_VIDEO_EMPIA_DTV) += lgdt3304/
+obj-$(CONFIG_VIDEO_EMPIA) += xc3028/
+obj-$(CONFIG_VIDEO_EMPIA) += xc5000/
+
+EXTRA_CFLAGS += -Idrivers/media/video
+EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
+EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
+EXTRA_CFLAGS += -Idrivers/media/common/tuners
drivers/media/video/empia/em2880-dvb.c new file +1139 -0

1,139 lines not on this page · raw message

drivers/media/video/empia/em28xx-aad.c new file +404 -0

404 lines not on this page · raw message

drivers/media/video/empia/em28xx-aad.h new file +46 -0

46 lines not on this page · raw message

drivers/media/video/empia/em28xx-audio.c new file +630 -0

630 lines not on this page · raw message

drivers/media/video/empia/em28xx-audioep.c new file +522 -0

522 lines not on this page · raw message

drivers/media/video/empia/em28xx-cards.c new file +3387 -0

164 lines not on this page · raw message

drivers/media/video/empia/em28xx-core.c new file +1366 -0

1,366 lines not on this page · raw message

drivers/media/video/empia/em28xx-i2c.c new file +983 -0

983 lines not on this page · raw message

drivers/media/video/empia/em28xx-input.c new file +536 -0

536 lines not on this page · raw message

drivers/media/video/empia/em28xx-keymaps.c new file +350 -0

350 lines not on this page · raw message

drivers/media/video/empia/em28xx-keymaps.h new file +21 -0
new file mode 100644
index 0000000..1205419

Lines of this file are not shown. View the raw message.

drivers/media/video/empia/em28xx-video.c new file +4244 -0

4,244 lines not on this page · raw message

drivers/media/video/empia/em28xx-webcam.c new file +375 -0

375 lines not on this page · raw message

drivers/media/video/empia/em28xx.h new file +1153 -0

1,153 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Part of the diff is not shown here. View the raw message.

#1 lore raw
Quoted 38 lines · On Wed, 22 Oct 2008 22:59:00 +0200 "Markus Rechberger" <[email protected]>…

em2880-dvb:
* supporting the digital part of Empia based devices, which
includes ATSC, ISDB-T and DVB-T

em28xx-aad.c:
* alternative audio driver, can be used instead of em28xx-audio if
alsa is not available
or not compiled into the kernel, it provides a raw interface to
the PCM samples

em28xx-audio.c:
* em28xx alsa driver and audio driver for FM radio

em28xx-audioep.c:
* em28xx alsa driver for devices which are set to vendor specific
audio on interface 1,
in that case snd-usb-audio will not attach to the interface and
em28xx-audioep will be needed

em28xx-cards.c:
* card definition and initial setup of devices.

em28xx-core.c:
* core videohandling and VBI frame slicing

em28xx-i2c.c:
* i2c setup and GPIO setup handling of the devices (including
em2888 based ones)

em28xx-input.c:
* currently mostly disabled since the linuxtv input handling is
broken by design and racy

em28xx-keymaps.c:
* keymap references of some remotes (could be merged into
ir-common, although as mentioned
this should be in userland done by lirc).

Quoted 5 lines

em28xx-video.c:
* inode handling for analog TV, radio and VBI, also some device probing

em28xx-webcam.c:
* videology webcam specific i2c commands

NACK.

There's already a driver for em28xx. Be welcome sending incremental patches to improve, like other developers do. But another driver for the same chip would just create a mess.

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

#2 lore raw
Quoted 44 lines · Mauro Carvalho Chehab
Quoted 41 lines · On Wed, 22 Oct 2008 22:59:00 +0200 "Markus Rechberger" <[email protected]>…

em2880-dvb:
* supporting the digital part of Empia based devices, which
includes ATSC, ISDB-T and DVB-T

em28xx-aad.c:
* alternative audio driver, can be used instead of em28xx-audio if
alsa is not available
or not compiled into the kernel, it provides a raw interface to
the PCM samples

em28xx-audio.c:
* em28xx alsa driver and audio driver for FM radio

em28xx-audioep.c:
* em28xx alsa driver for devices which are set to vendor specific
audio on interface 1,
in that case snd-usb-audio will not attach to the interface and
em28xx-audioep will be needed

em28xx-cards.c:
* card definition and initial setup of devices.

em28xx-core.c:
* core videohandling and VBI frame slicing

em28xx-i2c.c:
* i2c setup and GPIO setup handling of the devices (including
em2888 based ones)

em28xx-input.c:
* currently mostly disabled since the linuxtv input handling is
broken by design and racy

em28xx-keymaps.c:
* keymap references of some remotes (could be merged into
ir-common, although as mentioned
this should be in userland done by lirc).

em28xx-video.c:
* inode handling for analog TV, radio and VBI, also some device probing

Quoted 9 lines
Quoted 2 lines

em28xx-webcam.c:
* videology webcam specific i2c commands

NACK.

There's already a driver for em28xx. Be welcome sending incremental patches to improve, like other developers do. But another driver for the same chip would just create a mess.

the description right above shows up what the current driver is missing, excluding the bugfixes.
Technical reasons why the source is basically kept in the structure as it is, is eg. higher backward
compatibility without having to update the whole system. See eeePC packages which are available
from some vendors. The driver seamlessly works with the rest which is installed there, without
any framework upgrade.

Most users are currently using the drivers from mcentral.de since it's more stable and very
well tested over the last 3 years. It was basically your decision to not merge it back then
http://mcentral.de/v4l-dvb/

I pulled out the source and moved it together then and worked on additional device support.

http://mcentral.de/hg/~mrec/em28xx-new/shortlog
There are more than 200 changesets pointing out how it evolved, if someone wants to have an indepth
view about it. Bugreports and patches have been posted to the em28xx mailinglist where people worked
on it, including enduser applications.

The xc3028 as it is in the kernel is based on leaked and partly reverse engineered information.
I know that because I was also CC'ed with the leaked driver information.

The Xceive drivers which I submitted are the latest versions from Xceive addressing several bugs,
you might not have access to their changelog.

Before continuing any discussion the sourcecode and every statement I made for those patchsets
should be commented, otherwise a discussion won't go anywhere.

br,
Markus

#3 lore raw
Quoted 86 lines · Markus Rechberger
Quoted 44 lines · Mauro Carvalho Chehab
Quoted 41 lines · On Wed, 22 Oct 2008 22:59:00 +0200 "Markus Rechberger" <[email protected]>…

em2880-dvb:
* supporting the digital part of Empia based devices, which
includes ATSC, ISDB-T and DVB-T

em28xx-aad.c:
* alternative audio driver, can be used instead of em28xx-audio if
alsa is not available
or not compiled into the kernel, it provides a raw interface to
the PCM samples

em28xx-audio.c:
* em28xx alsa driver and audio driver for FM radio

em28xx-audioep.c:
* em28xx alsa driver for devices which are set to vendor specific
audio on interface 1,
in that case snd-usb-audio will not attach to the interface and
em28xx-audioep will be needed

em28xx-cards.c:
* card definition and initial setup of devices.

em28xx-core.c:
* core videohandling and VBI frame slicing

em28xx-i2c.c:
* i2c setup and GPIO setup handling of the devices (including
em2888 based ones)

em28xx-input.c:
* currently mostly disabled since the linuxtv input handling is
broken by design and racy

em28xx-keymaps.c:
* keymap references of some remotes (could be merged into
ir-common, although as mentioned
this should be in userland done by lirc).

em28xx-video.c:
* inode handling for analog TV, radio and VBI, also some device probing

Quoted 9 lines
Quoted 2 lines

em28xx-webcam.c:
* videology webcam specific i2c commands

NACK.

There's already a driver for em28xx. Be welcome sending incremental patches to improve, like other developers do. But another driver for the same chip would just create a mess.

the description right above shows up what the current driver is missing, excluding the bugfixes.
Technical reasons why the source is basically kept in the structure as it is, is eg. higher backward
compatibility without having to update the whole system. See eeePC packages which are available
from some vendors. The driver seamlessly works with the rest which is installed there, without
any framework upgrade.

Most users are currently using the drivers from mcentral.de since it's more stable and very
well tested over the last 3 years. It was basically your decision to not merge it back then
http://mcentral.de/v4l-dvb/

I pulled out the source and moved it together then and worked on additional device support.

http://mcentral.de/hg/~mrec/em28xx-new/shortlog
There are more than 200 changesets pointing out how it evolved, if someone wants to have an indepth
view about it. Bugreports and patches have been posted to the em28xx mailinglist where people worked
on it, including enduser applications.

The xc3028 as it is in the kernel is based on leaked and partly reverse engineered information.
I know that because I was also CC'ed with the leaked driver information.

Quoted 8 lines

The Xceive drivers which I submitted are the latest versions from Xceive addressing several bugs,
you might not have access to their changelog.

Before continuing any discussion the sourcecode and every statement I made for those patchsets
should be commented, otherwise a discussion won't go anywhere.

*to avoid any misunderstanding here, this is not about using chipdrivers from userspace*

Quoted 3 lines

br,
Markus