at91_ether: request/free GPIO for PHY interrupt

PATCH Applied David Brownell 2 participants 2 messages Oct 27, 2008 – Oct 31, 2008

Subsystems (3)

Networking Network drivers Arm/Microchip (AT91) SoC support

lore

Share & tools

lore

David Brownell

author

2008-10-27 21:38 UTC #0 lore raw

PATCH 1/1 at91_ether: request/free GPIO for PHY interrupt

From: David Brownell <[email protected]>

When the at91_ether driver is using a GPIO for its PHY interrupt, be sure to request (and later, if needed, free) that GPIO.

Signed-off-by David Brownell <[email protected]>

---
 drivers/net/arm/at91_ether.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

drivers/net/arm/at91_ether.c +5 -1

@@ -1080,7 +1080,8 @@ static int __init at91ether_setup(unsign
 		init_timer(&lp->check_timer);
 		lp->check_timer.data = (unsigned long)dev;
 		lp->check_timer.function = at91ether_check_link;
-	}
+	} else if (lp->board_data.phy_irq_pin >= 32)
+		gpio_request(lp->board_data.phy_irq_pin, "ethernet_phy");
 
 	/* Display ethernet banner */
 	printk(KERN_INFO "%s: AT91 ethernet at 0x%08x int=%d %s%s (%s)\n",

@@ -1167,6 +1168,9 @@ static int __devexit at91ether_remove(st
 	struct net_device *dev = platform_get_drvdata(pdev);
 	struct at91_private *lp = netdev_priv(dev);
 
+	if (lp->board_data.phy_irq_pin >= 32)
+		gpio_free(lp->board_data.phy_irq_pin);
+
 	unregister_netdev(dev);
 	free_irq(dev->irq, dev);
 	dma_free_coherent(NULL, sizeof(struct recv_desc_bufs), lp->dlist, (dma_addr_t)lp->dlist_phys);

Jeff Garzik

Applied

2008-10-31 04:48 UTC #1 lore raw

Quoted 9 lines · David Brownell

From: David Brownell <[email protected]>
When the at91_ether driver is using a GPIO for its PHY interrupt, be sure to request (and later, if needed, free) that GPIO.
Signed-off-by David Brownell <[email protected]>
---
 drivers/net/arm/at91_ether.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

applied