Skip to contentSkip to conversation

cciss: fix sysfs broken symlink regression

PATCH In review Mike Miller 3 participants 4 messages Oct 27, 2008 – Oct 28, 2008

Subsystems (2)
SCSI Block layer
lore
Share & tools
lore

Mike Miller

author
#0 lore raw

PATCH 1/2 cciss: fix sysfs broken symlink regression

Patch 1 of 2

Regression introduced by commit 6ae5ce8e8d4de666f31286808d2285aa6a50fa40. This patch fixes a broken symlink in sysfs that was introduced by the above commit also called "cciss: remove redundant code." We broke it in 2.6.27-rc on or about 20080804. Some installers are broken if this symlink does not exist and they may not detect the logical drives configured on the controller.
It does not require being backported into 2.6.26.x or earlier kernels.

Please consider this for inclusion.

Andrew, do I need to resubmit 2 of 2? Or is that one still in your queue?

Signed-off-by Mike Miller <[email protected]>
drivers/block/cciss.c +1 -0
index 1e1f915..0f367b1 100644
@@ -1365,6 +1365,7 @@ static void cciss_add_disk(ctlr_info_t *h, struct gendisk *disk,
 	disk->first_minor = drv_index << NWD_SHIFT;
 	disk->fops = &cciss_fops;
 	disk->private_data = &h->drv[drv_index];
+	disk->driverfs_dev = &h->pdev->dev;
 
 	/* Set up queue information */
 	blk_queue_bounce_limit(disk->queue, h->pdev->dma_mask);
#1 lore raw
Quoted 9 lines · On Mon, 27 Oct 2008 16:01:36 -0500 Mike Miller <[email protected]> wrote:

Patch 1 of 2

Regression introduced by commit 6ae5ce8e8d4de666f31286808d2285aa6a50fa40. This patch fixes a broken symlink in sysfs that was introduced by the above commit also called "cciss: remove redundant code." We broke it in 2.6.27-rc on or about 20080804. Some installers are broken if this symlink does not exist and they may not detect the logical drives configured on the controller.
It does not require being backported into 2.6.26.x or earlier kernels.

OK, thanks, I tagged it for 2.6.27.x.

Quoted 4 lines

Please consider this for inclusion.

Andrew, do I need to resubmit 2 of 2? Or is that one still in your queue?

What's 2 of 2?

cciss patches which I presently have queued are:

cciss-fix-regression-firmware-not-displayed-in-procfs-again-and-again.patch cciss-new-hardware-support.patch cciss-fix-sysfs-broken-symlink-regression.patch

author
#2 lore raw
Quoted 33 lines

-----Original Message-----
From: Andrew Morton [mailto:[email protected]]
Sent: Monday, October 27, 2008 4:30 PM
To: Miller, Mike (OS Dev)
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 1/2] cciss: fix sysfs broken symlink regression

Quoted 3 lines · On Mon, 27 Oct 2008 16:01:36 -0500 Mike Miller <[email protected]> wrote:

Patch 1 of 2

Regression introduced by commit

6ae5ce8e8d4de666f31286808d2285aa6a50fa40.

Quoted 1 line

This patch fixes a broken symlink in sysfs that was

introduced by the

Quoted 1 line

above commit also called "cciss: remove redundant code." We

broke it

Quoted 1 line

in 2.6.27-rc on or about 20080804. Some installers are

broken if this

Quoted 3 lines

symlink does not exist and they may not detect the logical drives configured on the controller.
It does not require being backported into 2.6.26.x or

earlier kernels.

OK, thanks, I tagged it for 2.6.27.x.

Quoted 3 lines

Please consider this for inclusion.

Andrew, do I need to resubmit 2 of 2? Or is that one still

Quoted 8 lines

in your queue?

Quoted 1 line

What's 2 of 2?

cciss patches which I presently have queued are:

cciss-fix-regression-firmware-not-displayed-in-procfs-again-an

d-again.patch

This is patch 2 of 2.

Quoted 4 lines

cciss-new-hardware-support.patch
cciss-fix-sysfs-broken-symlink-regression.patch

#3 lore raw
In reply to Mike Miller
Quoted 21 lines · Mike Miller

Patch 1 of 2

Regression introduced by commit 6ae5ce8e8d4de666f31286808d2285aa6a50fa40. This patch fixes a broken symlink in sysfs that was introduced by the above commit also called "cciss: remove redundant code." We broke it in 2.6.27-rc on or about 20080804. Some installers are broken if this symlink does not exist and they may not detect the logical drives configured on the controller.
It does not require being backported into 2.6.26.x or earlier kernels.

Please consider this for inclusion.

Andrew, do I need to resubmit 2 of 2? Or is that one still in your queue?

Signed-off-by Mike Miller <[email protected]>
drivers/block/cciss.c +0 -0
index 1e1f915..0f367b1 100644

drivers/block/cciss.c static void cciss_add_disk(ctlr_info_t *h, struct gendisk *disk,

Quoted 8 lines
drivers/block/cciss.c +1 -1
@@ -1365,6 +1365,7 @@ static void cciss_add_disk(ctlr_info_t *h, struct gendisk *disk,
 	disk->first_minor = drv_index << NWD_SHIFT;
 	disk->fops = &cciss_fops;
 	disk->private_data = &h->drv[drv_index];
+	disk->driverfs_dev = &h->pdev->dev;
 
 	/* Set up queue information */
 	blk_queue_bounce_limit(disk->queue, h->pdev->dma_mask);
--

Is this a patch for bug #11404 or for another regression?

Rafael