Skip to contentSkip to conversation

ep93xx: fix OHCI DMA mask

PATCH In review Matthias Kaehlcke 3 participants 3 messages Oct 28, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ep93xx: fix OHCI DMA mask

ep93xx: Fix OHCI DMA mask

--

arch/arm/mach-ep93xx/core.c +4 -2
@@ -26,6 +26,7 @@
 #include <linux/serial_core.h>
 #include <linux/device.h>
 #include <linux/mm.h>
+#include <linux/dma-mapping.h>
 #include <linux/time.h>
 #include <linux/timex.h>
 #include <linux/delay.h>
@@ -450,12 +451,13 @@
 	},
 };
 
+
 static struct platform_device ep93xx_ohci_device = {
 	.name		= "ep93xx-ohci",
 	.id		= -1,
 	.dev		= {
-		.dma_mask		= (void *)0xffffffff,
-		.coherent_dma_mask	= 0xffffffff,
+		.dma_mask		= &ep93xx_ohci_device.dev.coherent_dma_mask,
+		.coherent_dma_mask	= DMA_BIT_MASK(32),
 	},
 	.num_resources	= ARRAY_SIZE(ep93xx_ohci_resources),
 	.resource	= ep93xx_ohci_resources,
Signature · 11 lines
Matthias Kaehlcke
Embedded Linux Engineer
Barcelona

            You can chain me, you can torture me, you can even
          destroy this body, but you will never imprison my mind
                            (Mahatma Gandhi)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-
#1 lore raw
Quoted 3 lines · Matthias Kaehlcke

ep93xx: Fix OHCI DMA mask

Did this really have to go to so many people? akpm probably doesn't need to know of this directly, Russell reads linux-arm-kernel so isn't really a necessary CC: in this and you missed out the linux-usb list.

Quoted 46 lines

--

arch/arm/mach-ep93xx/core.c +4 -2
@@ -26,6 +26,7 @@
 #include <linux/serial_core.h>
 #include <linux/device.h>
 #include <linux/mm.h>
+#include <linux/dma-mapping.h>
 #include <linux/time.h>
 #include <linux/timex.h>
 #include <linux/delay.h>
@@ -450,12 +451,13 @@
 	},
 };
 
+
 static struct platform_device ep93xx_ohci_device = {
 	.name		= "ep93xx-ohci",
 	.id		= -1,
 	.dev		= {
-		.dma_mask		= (void *)0xffffffff,
-		.coherent_dma_mask	= 0xffffffff,
+		.dma_mask		= &ep93xx_ohci_device.dev.coherent_dma_mask,
+		.coherent_dma_mask	= DMA_BIT_MASK(32),
 	},
 	.num_resources	= ARRAY_SIZE(ep93xx_ohci_resources),
 	.resource	= ep93xx_ohci_resources,
Signature · 17 lines
-- 
Matthias Kaehlcke
Embedded Linux Engineer
Barcelona

            You can chain me, you can torture me, you can even
          destroy this body, but you will never imprison my mind
                            (Mahatma Gandhi)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'
#2 lore raw
Quoted 6 lines · On Tue, 28 Oct 2008 10:11:06 +0000 Ben Dooks <[email protected]> wrote:
Quoted 3 lines · Matthias Kaehlcke

ep93xx: Fix OHCI DMA mask

Did this really have to go to so many people?

It's better than too few! Bugfixes are important (most important?) and our lossage rate on patches is scary high.

In particular, please don't chase people's bugfixes off linux-kernel, because then I won't see them. I'd guess that somewhere between a quarter and a half of the bugfixes which I scoop off the list would otherwise not have been applied.

Spread the wealth!