Missing definition of DIV_ROUND

From u-boot HEAD grabbed just a few minutes ago...

garyj:tdt:u-boot:bash:1> ./MAKEALL ppc
Configuring for cmi_mpc5xx board...
strmhz.c: In function 'strmhz':
strmhz.c:30: warning: implicit declaration of function 'DIV_ROUND' lib_generic/libgeneric.a(strmhz.o): In function `strmhz':
/home/garyj/proj/junk/u-boot/lib_generic/strmhz.c:30: undefined reference to DIV_ROUND' /home/garyj/proj/junk/u-boot/lib_generic/strmhz.c:34: undefined reference to DIV_ROUND'
make: *** [u-boot] Error 1
size: './u-boot': No such file
Configuring for ads5121 board...
strmhz.c: In function 'strmhz':
strmhz.c:30: warning: implicit declaration of function 'DIV_ROUND' lib_generic/libgeneric.a(strmhz.o): In function `strmhz':
/home/garyj/proj/junk/u-boot/lib_generic/strmhz.c:30: undefined reference to DIV_ROUND' /home/garyj/proj/junk/u-boot/lib_generic/strmhz.c:34: undefined reference to DIV_ROUND'
make: *** [u-boot] Error 1
size: './u-boot': No such file
Configuring for BC3450 board...
strmhz.c: In function 'strmhz':
strmhz.c:30: warning: implicit declaration of function 'DIV_ROUND' lib_generic/libgeneric.a(strmhz.o): In function `strmhz':
/home/garyj/proj/junk/u-boot/lib_generic/strmhz.c:30: undefined reference to DIV_ROUND' /home/garyj/proj/junk/u-boot/lib_generic/strmhz.c:34: undefined reference to DIV_ROUND'
make: *** [u-boot] Error 1
size: './u-boot': No such file
Configuring for cm5200 board...
strmhz.c: In function 'strmhz':
strmhz.c:30: warning: implicit declaration of function 'DIV_ROUND' lib_generic/libgeneric.a(strmhz.o): In function `strmhz':
/home/garyj/proj/junk/u-boot/lib_generic/strmhz.c:30: undefined reference to DIV_ROUND' /home/garyj/proj/junk/u-boot/lib_generic/strmhz.c:34: undefined reference to DIV_ROUND'
make: *** [u-boot] Error 1
size: './u-boot': No such file
Configuring for cpci5200 board...
strmhz.c: In function 'strmhz':
strmhz.c:30: warning: implicit declaration of function 'DIV_ROUND'

Script done on Tue 28 Oct 2008 12:16:36 PM CET

---
Gary Jennejohn
*********************************************************************
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
*********************************************************************

Dear Gary Jennejohn,

Which commit ID is this where you see such behaviour?

Hmm... for me, current head is:

-> git-describe
v2008.10-121-gd35c451
-> git-log
commit d35c451d6cff3e77e40fbdfc7a2933cdcb86ae4b
Merge: a369f4a... 6b59e03...
Author: Wolfgang Denk <[email protected]>
Date: Tue Oct 28 08:37:19 2008 +0100

Merge branch 'master' of git://git.denx.de/u-boot-video
...

And this builds just fine:

-> JOBS=-j5 ./MAKEALL ppc
Configuring for cmi_mpc5xx board...
text data bss dec hex filename
94312 71160 6756 172228 2a0c4 ./u-boot
Configuring for ads5121 board...
text data bss dec hex filename
198296 35480 28584 262360 400d8 ./u-boot
Configuring for BC3450 board...
text data bss dec hex filename
284504 29004 296336 609844 94e34 ./u-boot
Configuring for cm5200 board...
text data bss dec hex filename
263448 17532 281344 562324 89494 ./u-boot
...

You must be doing something wrong, it seems.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It may be that your whole purpose in life is simply  to  serve  as  a
warning to others.

On Tue, 28 Oct 2008 17:55:49 +0100
Wolfgang Denk <[email protected]> wrote:

Dear Wolfgang,

I have d35c451d6cff3e77e40fbdfc7a2933cdcb86ae4b, exactly the same as you. And
garyj:tdt:u-boot:-bash:184> git branch -a
* master
origin/HEAD
origin/i.MX31
origin/lwmon5
origin/master
origin/next
origin/origin
origin/u-boot-next
origin/wd at denx.de

so I'm on the master branch.

Well, I also did MAKEALL ppc. I don't see how that could wrong.

I'll just delete u-boot and grab a fresh copy.

---
Gary Jennejohn
*********************************************************************
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
*********************************************************************

Ah, now I see. I somehow managed to overwrite common.h with an old copy.

Sorry for wasting bandwidth.

---
Gary Jennejohn
*********************************************************************
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
*********************************************************************