Skip to contentSkip to conversation

netns: add in ida ID to identify the network namespace

PATCH In review Vivien Chappelier 1 participant 1 message Oct 28, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Vivien Chappelier

author
#0 lore raw

PATCH 1/6 netns: add in ida ID to identify the network namespace

Patch initially submitted by Benjamin Thery, provided again here for reference.

This patch adds in 'id' member to struct net. This member contains an IDA ID. The id is allocated at netns creation.

This 'id' will be used to reference network namespaces without the need for a pid.

---
 include/net/net_namespace.h |    2 ++
 net/core/net_namespace.c    |   24 ++++++++++++++++++++++++
 2 files changed, 26 insertions(+), 0 deletions(-)
include/net/net_namespace.h +2 -0
index 708009b..8bde629 100644
@@ -75,6 +75,8 @@ struct net {
 #endif
 #endif
 	struct net_generic	*gen;
+
+	int			id;
 };
net/core/net_namespace.c +24 -0
index f1d07b5..894b35e 100644
@@ -26,6 +26,16 @@ EXPORT_SYMBOL(init_net);
 #define INITIAL_NET_GEN_PTRS	13 /* +1 for len +2 for rcu_head */
 
 /*
+ * IDs allocated from this ida are used as a suffix in sysfs to tag
+ * devices belonging to each netns (other than init_net).
+ * Only 4 characters are left to store a separator plus this tag in sysfs
+ * (BUS_ID_SIZE-IFNAMSIZ)
+ * Thus, this limits us to 4095 ("FFF") simultaneous network namespaces.
+ */
+static DEFINE_IDA(net_id_ida);
+#define NET_ID_MAX 0xFFF
+
+/*
  * setup_net runs the initializers for the network namespace object.
  */
 static __net_init int setup_net(struct net *net)

@@ -40,7 +50,20 @@ static __net_init int setup_net(struct net *net)
 	atomic_set(&net->use_count, 0);
 #endif
 
+	/* Get an ID */
+again:
+	error = ida_get_new(&net_id_ida, &net->id);
+	if (error) {
+		if (error == -EAGAIN) {
+			ida_pre_get(&net_id_ida, GFP_KERNEL);
+			goto again;
+		}
+		goto out;
+	}
 	error = -ENOMEM;
+	if (net->id > NET_ID_MAX)
+		goto out;
+
 	ng = kzalloc(sizeof(struct net_generic) +
 			INITIAL_NET_GEN_PTRS * sizeof(void *), GFP_KERNEL);
 	if (ng == NULL)

@@ -97,6 +120,7 @@ static void net_free(struct net *net)
 	}
 #endif
 	kfree(net->gen);
+	ida_remove(&net_id_ida, net->id);
 	kmem_cache_free(net_cachep, net);
 }
Signature · 1 line
1.5.4.4