Skip to contentSkip to conversation

drivers/rtc/rtc-ds1286.c is borked

PATCH Applied [email protected] 3 participants 5 messages Oct 30, 2008

Subsystems (2)
MIPS Real time clock (RTC)
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 2/3 drivers/rtc/rtc-ds1286.c is borked

From: Andrew Morton <[email protected]>

drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl' drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel' drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap' drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'

Cc Thomas Bogendoerfer <[email protected]>
Cc Alessandro Zummo <[email protected]>
Cc Ralf Baechle <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 drivers/rtc/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/rtc/Kconfig renamed from drivers/rtc/Kconfig~drivers-rtc-rtc-ds1286c-is-borked +1 -0
diff -puN drivers/rtc/Kconfig~drivers-rtc-rtc-ds1286c-is-borked drivers/rtc/Kconfig
@@ -373,6 +373,7 @@ config RTC_DRV_DS1216
 
 config RTC_DRV_DS1286
 	tristate "Dallas DS1286"
+	depends on MIPS
 	help
 	  If you say yes here you get support for the Dallas DS1286 RTC chips.

_

#1 lore raw
Quoted 9 lines · On Wed, Oct 29, 2008 at 02:21:33PM -0700, [email protected] wrote:

From: [email protected]
Date: Wed, 29 Oct 2008 14:21:33 -0700
To: [email protected]
Cc: [email protected], [email protected],
[email protected], [email protected]
Subject: [patch 2/3] drivers/rtc/rtc-ds1286.c is borked

From: Andrew Morton <[email protected]>

Quoted 8 lines

drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl' drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel' drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap' drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'

Geert's patch commit ID d7a6119f457f48a94985fdbdc400cbb03e136a76 should have solved this so you can drop this one.

Ralf

#2 lore raw
In reply to [email protected]

Hello.

Quoted 11 lines · [email protected] wrote:

From: Andrew Morton <[email protected]>

drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl' drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel' drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap' drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'

Again, on which architecture this happens?

WBR, Sergei

#3 lore raw
Quoted 12 lines · Hello, I wrote:
Quoted 11 lines

From: Andrew Morton <[email protected]>

drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl' drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel' drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap' drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'

Quoted 1 line

Again, on which architecture this happens?

Nevermind. I was looking at already fixed drivers...

WBR, Sergei

#4 lore raw
In reply to Sergei Shtylyov
Quoted 24 lines · Sergei Shtylyov

From: Sergei Shtylyov <[email protected]>
Date: Thu, 30 Oct 2008 14:10:54 +0300
To: [email protected]
Cc: [email protected], [email protected],
[email protected], [email protected]
Subject: Re: [patch 2/3] drivers/rtc/rtc-ds1286.c is borked
Content-Type: text/plain; charset=ISO-8859-1; format=flowed

Hello.

Quoted 11 lines · [email protected] wrote:

From: Andrew Morton <[email protected]>

drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':
drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl' drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':
drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel' drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':
drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap' drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'

Quoted 1 line

Again, on which architecture this happens?

On non-MIPS. <linux/io.h> is required to build the two files in question but wasn't getting included explicitly. On MIPS we were lucky; io.h was getting dragged in indirectly through another header so things just happened to work.

Ralf