Skip to contentSkip to conversation

drivers/rtc/rtc-m48t35.c is borked too

PATCH Applied [email protected] 3 participants 3 messages Oct 30, 2008

Subsystems (2)
MIPS Real time clock (RTC)
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 3/3 drivers/rtc/rtc-m48t35.c is borked too

From: Andrew Morton <[email protected]>

drivers/rtc/rtc-m48t35.c: In function 'm48t35_read_time':
drivers/rtc/rtc-m48t35.c:59: error: implicit declaration of function 'readb' drivers/rtc/rtc-m48t35.c:60: error: implicit declaration of function 'writeb' drivers/rtc/rtc-m48t35.c: In function 'm48t35_probe':
drivers/rtc/rtc-m48t35.c:168: error: implicit declaration of function 'ioremap' drivers/rtc/rtc-m48t35.c:168: warning: assignment makes pointer from integer without a cast drivers/rtc/rtc-m48t35.c:188: error: implicit declaration of function 'iounmap'

Cc Thomas Bogendoerfer <[email protected]>
Cc Alessandro Zummo <[email protected]>
Cc Ralf Baechle <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 drivers/rtc/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/rtc/Kconfig renamed from drivers/rtc/Kconfig~drivers-rtc-rtc-m48t35c-is-borked-too +1 -0
diff -puN drivers/rtc/Kconfig~drivers-rtc-rtc-m48t35c-is-borked-too drivers/rtc/Kconfig
@@ -432,6 +432,7 @@ config RTC_DRV_M48T86
 
 config RTC_DRV_M48T35
 	tristate "ST M48T35"
+	depends on MIPS
 	help
 	  If you say Y here you will get support for the
 	  ST M48T35 RTC chip.

_

#1 lore raw
Quoted 11 lines · On Wed, Oct 29, 2008 at 02:21:34PM -0700, [email protected] wrote:

Subject: [patch 3/3] drivers/rtc/rtc-m48t35.c is borked too

From: Andrew Morton <[email protected]>

drivers/rtc/rtc-m48t35.c: In function 'm48t35_read_time':
drivers/rtc/rtc-m48t35.c:59: error: implicit declaration of function 'readb' drivers/rtc/rtc-m48t35.c:60: error: implicit declaration of function 'writeb' drivers/rtc/rtc-m48t35.c: In function 'm48t35_probe':
drivers/rtc/rtc-m48t35.c:168: error: implicit declaration of function 'ioremap' drivers/rtc/rtc-m48t35.c:168: warning: assignment makes pointer from integer without a cast drivers/rtc/rtc-m48t35.c:188: error: implicit declaration of function 'iounmap'

Same for this one; commit ID d7a6119f457f48a94985fdbdc400cbb03e136a76 should have solved this one also.

Ralf

#2 lore raw
In reply to [email protected]

Hello.

Quoted 10 lines · [email protected] wrote:

From: Andrew Morton <[email protected]>

drivers/rtc/rtc-m48t35.c: In function 'm48t35_read_time':
drivers/rtc/rtc-m48t35.c:59: error: implicit declaration of function 'readb' drivers/rtc/rtc-m48t35.c:60: error: implicit declaration of function 'writeb' drivers/rtc/rtc-m48t35.c: In function 'm48t35_probe':
drivers/rtc/rtc-m48t35.c:168: error: implicit declaration of function 'ioremap' drivers/rtc/rtc-m48t35.c:168: warning: assignment makes pointer from integer without a cast drivers/rtc/rtc-m48t35.c:188: error: implicit declaration of function 'iounmap'

I wonder how that's possible with the correct #include's?

Quoted 5 lines
Cc Thomas Bogendoerfer <[email protected]>
Cc Alessandro Zummo <[email protected]>
Cc Ralf Baechle <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

[...]

drivers/rtc/Kconfig config RTC_DRV_M48T86 · line 436

Quoted 9 lines

diff -puN drivers/rtc/Kconfig~drivers-rtc-rtc-m48t35c-is-borked-too drivers/rtc/Kconfig

drivers/rtc/Kconfig renamed from drivers/rtc/Kconfig~drivers-rtc-rtc-m48t35c-is-borked-too +1 -0
@@ -432,6 +432,7 @@ config RTC_DRV_M48T86
 
 config RTC_DRV_M48T35
 	tristate "ST M48T35"
+	depends on MIPS

It shouldn't really be MIPS specific -- the patch seems wrong.

WBR, Sergei