Skip to contentSkip to conversation

x86: signal: cosmetic unification of signr_convert()

PATCH In review Hiroshi Shimamoto 2 participants 4 messages Oct 30, 2008 x86

lore
Share & tools
lore

Hiroshi Shimamoto

author
#0 lore raw

PATCH 1/3 x86: signal: cosmetic unification of signr_convert()

From: Hiroshi Shimamoto <[email protected]>

Make signr_convert() same.

Signed-off-by Hiroshi Shimamoto <[email protected]>
---
 arch/x86/kernel/signal_32.c |    2 ++
 arch/x86/kernel/signal_64.c |    6 ++++++
 2 files changed, 8 insertions(+), 0 deletions(-)
arch/x86/kernel/signal_32.c +2 -0
index 85a0d37..abf0df7 100644
@@ -503,10 +503,12 @@ static int __setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
  */
 static int signr_convert(int sig)
 {
+#ifdef CONFIG_X86_32
 	struct thread_info *info = current_thread_info();
 
 	if (info->exec_domain && info->exec_domain->signal_invmap && sig < 32)
 		return info->exec_domain->signal_invmap[sig];
+#endif /* CONFIG_X86_32 */
 	return sig;
 }
arch/x86/kernel/signal_64.c +6 -0
index 3d0deb3..a4b46e6 100644
@@ -295,6 +295,12 @@ static int __setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
  */
 static int signr_convert(int sig)
 {
+#ifdef CONFIG_X86_32
+	struct thread_info *info = current_thread_info();
+
+	if (info->exec_domain && info->exec_domain->signal_invmap && sig < 32)
+		return info->exec_domain->signal_invmap[sig];
+#endif /* CONFIG_X86_32 */
 	return sig;
 }
Signature · 1 line
1.5.6
author
#1 lore raw

PATCH 2/3 x86: signal: cosmetic unification of macros for setup_rt_frame()

From: Hiroshi Shimamoto <[email protected]>

Add #ifdef directive for unification.

Signed-off-by Hiroshi Shimamoto <[email protected]>
---
 arch/x86/kernel/signal_32.c |   12 ++++++++++++
 arch/x86/kernel/signal_64.c |   14 ++++++++++++--
 2 files changed, 24 insertions(+), 2 deletions(-)
arch/x86/kernel/signal_32.c +12 -0
index abf0df7..6f3b9a9 100644
@@ -512,10 +512,22 @@ static int signr_convert(int sig)
 	return sig;
 }
 
+#ifdef CONFIG_X86_32
+
 #define is_ia32	1
 #define ia32_setup_frame	__setup_frame
 #define ia32_setup_rt_frame	__setup_rt_frame
 
+#else /* !CONFIG_X86_32 */
+
+#ifdef CONFIG_IA32_EMULATION
+#define is_ia32	test_thread_flag(TIF_IA32)
+#else /* !CONFIG_IA32_EMULATION */
+#define is_ia32	0
+#endif /* CONFIG_IA32_EMULATION */
+
+#endif /* CONFIG_X86_32 */
+
 static int
 setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
 	       sigset_t *set, struct pt_regs *regs)
arch/x86/kernel/signal_64.c +12 -2
index a4b46e6..49df79e 100644
@@ -304,11 +304,21 @@ static int signr_convert(int sig)
 	return sig;
 }
 
+#ifdef CONFIG_X86_32
+
+#define is_ia32	1
+#define ia32_setup_frame	__setup_frame
+#define ia32_setup_rt_frame	__setup_rt_frame
+
+#else /* !CONFIG_X86_32 */
+
 #ifdef CONFIG_IA32_EMULATION
 #define is_ia32	test_thread_flag(TIF_IA32)
-#else
+#else /* !CONFIG_IA32_EMULATION */
 #define is_ia32	0
-#endif
+#endif /* CONFIG_IA32_EMULATION */
+
+#endif /* CONFIG_X86_32 */
 
 static int
 setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
Signature · 1 line
1.5.6
author
#2 lore raw

PATCH 3/3 x86: signal: cosmetic unification of NR_restart_syscall

In reply to Hiroshi Shimamoto

From: Hiroshi Shimamoto <[email protected]>

Add #ifdef directive to unify NR_restart_syscall.

Signed-off-by Hiroshi Shimamoto <[email protected]>
---
 arch/x86/kernel/signal_32.c |    6 ++++++
 arch/x86/kernel/signal_64.c |    5 +++++
 2 files changed, 11 insertions(+), 0 deletions(-)
arch/x86/kernel/signal_32.c +6 -0
index 6f3b9a9..a0efc1b 100644
@@ -628,7 +628,13 @@ handle_signal(unsigned long sig, siginfo_t *info, struct k_sigaction *ka,
 	return 0;
 }
 
+#ifdef CONFIG_X86_32
 #define NR_restart_syscall	__NR_restart_syscall
+#else /* !CONFIG_X86_32 */
+#define NR_restart_syscall	\
+	test_thread_flag(TIF_IA32) ? __NR_ia32_restart_syscall : __NR_restart_syscall
+#endif /* CONFIG_X86_32 */
+
 /*
  * Note that 'init' is a special process: it doesn't get signals it doesn't
  * want to handle. Thus you cannot kill init even with a SIGKILL even by
arch/x86/kernel/signal_64.c +5 -0
index 49df79e..83990db 100644
@@ -420,8 +420,13 @@ handle_signal(unsigned long sig, siginfo_t *info, struct k_sigaction *ka,
 	return 0;
 }
 
+#ifdef CONFIG_X86_32
+#define NR_restart_syscall	__NR_restart_syscall
+#else /* !CONFIG_X86_32 */
 #define NR_restart_syscall	\
 	test_thread_flag(TIF_IA32) ? __NR_ia32_restart_syscall : __NR_restart_syscall
+#endif /* CONFIG_X86_32 */
+
 /*
  * Note that 'init' is a special process: it doesn't get signals it doesn't
  * want to handle. Thus you cannot kill init even with a SIGKILL even by
Signature · 1 line
1.5.6
#3 lore raw
In reply to Hiroshi Shimamoto
Quoted 9 lines · Hiroshi Shimamoto

From: Hiroshi Shimamoto <[email protected]>

Make signr_convert() same.

Signed-off-by Hiroshi Shimamoto <[email protected]>
---
 arch/x86/kernel/signal_32.c |    2 ++
 arch/x86/kernel/signal_64.c |    6 ++++++
 2 files changed, 8 insertions(+), 0 deletions(-)

applied your patches to tip/x86/signal:

5791775: x86: signal: cosmetic unification of NR_restart_syscall
cabf503: x86: signal: cosmetic unification of macros for setup_rt_frame() 96bf84b: x86: signal: cosmetic unification of signr_convert()

thanks!

Ingo