New Board support: Makefile MAKEALL, etc
PATCH 1/4 New Board support: Makefile MAKEALL, etc
I used git format-patch, but I did not use git send-email. I am looking into that right now. I didn't realize that the web email client would create such problems. And as this is all that I currently have access to, I am looking into using the git tools to submit the patch.
Quoted 2 lines
please reorder patchseries or, even better, resubmit as one single patch so as to not break git bisecting.
I don't understand this. Could you elaborate?
Quoted 1 line
s/Signed off by/Signed-off-by/ so as to not upset statistics tools.
This also. I'm sorry.
Quoted 1 line
btw, these patches are missing diffstats; please look into using git
Are the diffstats the lines that tell you how many insertions and deletions there have been?
Thank you for the feedback.
Ron Madrid
PATCH 1/4 New Board support: Makefile MAKEALL, etc
Quoted 2 lines · On Fri, 31 Oct 2008 13:30:22 -0700 (PDT) Ron Madrid <[email protected]>…
I used git format-patch, but I did not use git send-email. I am looking into that right now. I didn't realize that the web email client would create such problems. And as this is all
patch submission is one of the biggest problems newcomers have, but once they've got their setup down, it's plain sailing after that.
Quoted 1 line
that I currently have access to, I am looking into using the git tools to submit the patch.
great, thanks.
Quoted 4 lines
Quoted 2 lines
please reorder patchseries or, even better, resubmit as one single patch so as to not break git bisecting.
I don't understand this. Could you elaborate?
people doing a "git bisect run" on, e.g. MAKEALL 83xx would inadvertently run into an error because your 1/4 patch (commit) adds a non-existent board to MAKEALL.
Quoted 3 lines
Quoted 1 line
s/Signed off by/Signed-off-by/ so as to not upset statistics tools.
This also. I'm sorry.
no worries.
Quoted 3 lines
Quoted 1 line
btw, these patches are missing diffstats; please look into using git
Are the diffstats the lines that tell you how many insertions and deletions there have been?
yes, like this:
doc/README.update | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
it's to help potential reviewers understand the breadth of the patch up front.
Quoted 1 line
Thank you for the feedback.
thanks for your new board submission!
I forgot to ask: can you (a) briefly describe your board in the commit message, (b) include the new board's name in the patch subject, and (c) preprend the subsystem denotation 'mpc83xx: ' in the patch subject?
Thanks again.
Kim