Skip to contentSkip to conversation

tags: link from CONFIG_x to 'config x' as well

PATCH In review Alexey Dobriyan 2 participants 2 messages Oct 31, 2008 – Nov 2, 2008 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tags: link from CONFIG_x to 'config x' as well

Inability to jump from CONFIG_ symbol in source to symbol definition in Kconfig is very, very annoying. You'll jump to useless entry in autoconf.h, if it exists at all.

No more.

---

 Makefile |    6 ++++++
 1 file changed, 6 insertions(+)
Makefile +6 -0
@@ -1482,6 +1482,10 @@ define xtags
 		--langdef=kconfig \
 		--language-force=kconfig \
 		--regex-kconfig='/^[[:blank:]]*(menu|)config[[:blank:]]+([[:alnum:]_]+)/\2/'; \
+	    $(all-kconfigs) | xargs $1 -a \
+		--langdef=kconfig \
+		--language-force=kconfig \
+		--regex-kconfig='/^[[:blank:]]*(menu|)config[[:blank:]]+([[:alnum:]_]+)/CONFIG_\2/'; \
 	    $(all-defconfigs) | xargs -r $1 -a \
 		--langdef=dotconfig \
 		--language-force=dotconfig \
@@ -1490,6 +1494,8 @@ define xtags
 	    $(all-sources) | xargs $1 -a; \
 	    $(all-kconfigs) | xargs $1 -a \
 		--regex='/^[ \t]*\(\(menu\)*config\)[ \t]+\([a-zA-Z0-9_]+\)/\3/'; \
+	    $(all-kconfigs) | xargs $1 -a \
+		--regex='/^[ \t]*\(\(menu\)*config\)[ \t]+\([a-zA-Z0-9_]+\)/CONFIG_\3/'; \
 	    $(all-defconfigs) | xargs -r $1 -a \
 		--regex='/^#?[ \t]?\(CONFIG_[a-zA-Z0-9_]+\)/\1/'; \
 	else \
#1 lore raw
Quoted 5 lines · Alexey Dobriyan

Inability to jump from CONFIG_ symbol in source to symbol definition in Kconfig is very, very annoying. You'll jump to useless entry in autoconf.h, if it exists at all.

No more.

Hi Alexey.

Based on the number of patches hitting tags/cscope support at the moment it is becoming obvious that this have to live outside the top-level Makefile.
So any improvements in this area has to start with ripping it all out of the top-level Makefile and add it to a shell script in scripts/tags.sh (or similar).

If no-one betas me I will do so when I start to look into non-bugfixes for kbuild.

So I will not take your patch right now. Not because it is wrong, but simple to avoid changes to the top-level Makefile when this must happen in a shell script.

Sam