New Board support: Makefile MAKEALL, etc
PATCH 1/4 New Board support: Makefile MAKEALL, etc
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
please reorder patchseries or, even better, resubmit as one single patch so as to not break git bisecting.
I don't understand this. Could you elaborate?
people doing a "git bisect run" on, e.g. MAKEALL 83xx would inadvertently run into an error because your 1/4 patch (commit) adds a non-existent board to MAKEALL.
So, I should put the patch for the top level files such as Makefile and MAKEALL as the last of a series of patches? That makes sense. But are you also suggesting that my 4 patches could be submitted as one single patch. I was worried that I might exceed the patch size limit.
Quoted 5 lines
Quoted 4 lines
Quoted 2 lines
s/Signed off by/Signed-off-by/ so as to not upset statistics tools.
This also. I'm sorry.
"This also." meant that I also didn't understand your meaning on the "Signed off by" part.
Thanks,
Ron
PATCH 1/4 New Board support: Makefile MAKEALL, etc
Dear Ron Madrid,
Quoted 3 lines · In message <[email protected]> you wrote:
So, I should put the patch for the top level files such as
Makefileand MAKEALL as the last of a series of patches? That makes sense.
i
No, you should make all that belongs together one patch.
Please see http://www.denx.de/wiki/U-Boot/Patches
Quoted 5 lines
But are you also suggesting that my 4 patches could be submitted as one single patch. I was worried that I might exceed the patch size limit.
Quoted 1 line
Quoted 7 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
s/Signed off by/Signed-off-by/ so as to not upset statistics tools.
This also. I'm sorry.
"This also." meant that I also didn't understand your meaning on the "Signed off by" part.
It has to be written as "Signed-off-by: ..."
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de We Klingons believe as you do -- the sick should die. Only the strong should live. -- Kras, "Friday's Child", stardate 3497.2