New Board support: Makefile MAKEALL, etc
PATCH 1/4 New Board support: Makefile MAKEALL, etc
Quoted 7 lines
Quoted 2 lines
So, I should put the patch for the top level files such as
Makefileand MAKEALL as the last of a series of patches? That makes sense.i
No, you should make all that belongs together one patch.Please see http://www.denx.de/wiki/U-Boot/Patches
I have previously read the information at the link suggested. In my mind I felt that the Makefile on the top level and the MAKEALL and the MAINTAINERS files would be suitable for putting together into one patch (which is what I did). Should I have put them together with all of my new board specific files? If not, then where would be the most appropriate place for these files to be?
All of the changes/additions to my project are the aforementioned files, all of the files within the /board directory, the /nand_spl directory, a README and a board config file. Do I need more patches or less. I'm confused now.
Quoted 9 lines
Quoted 7 lines
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
s/Signed off by/Signed-off-by/ so as to not upset statistics tools.
This also. I'm sorry.
"This also." meant that I also didn't understand your meaning on the "Signed off by" part.
It has to be written as "Signed-off-by: ..."
Thank you. This point is more clear.
Thank you for the help.
Ron
PATCH 1/4 New Board support: Makefile MAKEALL, etc
Dear Ron Madrid,
Quoted 3 lines · In message <[email protected]> you wrote:
I have previously read the information at the link suggested. In my mind I felt that the
Makefileon the top level and the MAKEALL and theMAINTAINERSfiles would be suitable for putting together into one patch (which is what I did). Should I have put
them together with all of my new board specific files? If not, then where would be the most appropriate place for these files to be?
Please restrict your line length to some 70 characters. Thanks.
Quoted 1 line
All of the changes/additions to my project are the aforementioned files, all of the files within the /board directory, the /nand_spl directory, a README and a board config file. Do I need more patches or less. I'm confused now.
It should be just a single patch, unless you break it into locally idenpendent parts, for example first adding general board support (complete and working in itself), and then in a second patch enhance the general board support by support to boot from NAND.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "... freedom ... is a worship word..." "It is our worship word too." -- Cloud William and Kirk, "The Omega Glory", stardate unknown