Skip to contentSkip to conversation

2.6.28-rc3: usb_hcd_poll_rh_status: array subscript is above array bounds

DISCUSSION Andrey Borzenkov 3 participants 5 messages Nov 3, 2008 – Nov 4, 2008

lore
Share & tools
lore
#0 lore raw

CC [M] drivers/usb/core/hcd.o
/home/bor/src/linux-git/drivers/usb/core/hcd.c: In function ‘usb_hcd_poll_rh_status’:
/home/bor/src/linux-git/arch/x86/include/asm/string_32.h:75: warning: array subscript is above array bounds

It is likely that issue is actually in string_32.h as similar errors are in oher places as well.

#1 lore raw
Quoted 6 lines · Andrey Borzenkov

CC [M] drivers/usb/core/hcd.o
/home/bor/src/linux-git/drivers/usb/core/hcd.c: In function ‘usb_hcd_poll_rh_status’:
/home/bor/src/linux-git/arch/x86/include/asm/string_32.h:75: warning: array subscript is above array bounds

It is likely that issue is actually in string_32.h as similar errors are in oher places as well.

I think this is actually a compiler bug. It certainly has nothing to do with USB. There was a discussion about it a month or so ago on LKML.

Alan Stern

#2 lore raw
Quoted 6 lines · Alan Stern
Quoted 4 lines · Andrey Borzenkov

CC [M] drivers/usb/core/hcd.o
/home/bor/src/linux-git/drivers/usb/core/hcd.c: In function ‘usb_hcd_poll_rh_status’:
/home/bor/src/linux-git/arch/x86/include/asm/string_32.h:75: warning: array subscript is above array bounds

Quoted 7 lines
Quoted 2 lines

It is likely that issue is actually in string_32.h as similar errors are in oher places as well.

I think this is actually a compiler bug. It certainly has nothing to do with USB. There was a discussion about it a month or so ago on LKML.

Yes this really looks like a compiler bug, "length" hardly can be considered constant expression even using very broad definition of "constant".

What is interesting though, it appears that compiler believes length has value of 5. So it will copy one extra byte; and possibly pass incorrect length to the caller. I cannot judge whether this garbage can do any harm.

Dp you know if it was ever reported to gcc folks?

#3 lore raw
Quoted 7 lines · Andrey Borzenkov
Quoted 4 lines

I think this is actually a compiler bug. It certainly has nothing to do with USB. There was a discussion about it a month or so ago on LKML.

Quoted 6 lines

Yes this really looks like a compiler bug, "length" hardly can be considered constant expression even using very broad definition of "constant".

What is interesting though, it appears that compiler believes length has value of 5. So it will copy one extra byte; and possibly pass incorrect length to the caller. I cannot judge whether this garbage can do any harm.

Did you examine the object code? That's the only way to be sure.

Quoted 1 line

Dp you know if it was ever reported to gcc folks?

I have no idea. All I know is what was reported on LKML.

Alan Stern

#4 lore raw
Quoted 3 lines · On Tue, 4 Nov 2008 11:10:33 -0500 (EST) Alan Stern <[email protected]>…
Quoted 1 line

Dp you know if it was ever reported to gcc folks?

I have no idea. All I know is what was reported on LKML.

I reported this bug (well from a different part of the kernel, but same warning) to gcc and yes it's a "gcc behavior"
apparently they produce the warning in a phase of the compiler before the optimization to remove this code as "not taken".

There's a fix floating around but it's only a partial fix or something like that.

Signature · 3 lines
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org