Skip to contentSkip to conversation

ath5k: Fix IMR init

PATCH In review Nick Kossifidis 4 participants 4 messages Nov 3, 2008 – Nov 6, 2008 Networking drivers (wireless)

lore
Share & tools
lore

Nick Kossifidis

author
#0 lore raw

PATCH 1/1 ath5k: Fix IMR init

*On a previous patch i splitted AR5K_INT_TX to multiple different TX interrupt flags for better handling but i forgot to unmask the new TXDESC and TXEOL interrupts on ath5k_init and only left TXOK. However for each queue we enable TXDESC and TXEOL interrupts, not TXOK so we don't handle TX interrupts at all (because these interrupts remain masked on PISR) and under load it results packet loss. Fix the problem by unmasking TXDESC and TXEOL on ath5k_init.

Signed-off-by Nick Kossifidis <[email protected]>

---

drivers/net/wireless/ath5k/base.c +3 -3
index 5ef8cc4..f5f46fe 100644
@@ -2219,9 +2219,9 @@ ath5k_init(struct ath5k_softc *sc, bool is_resume)
 	 */
 	sc->curchan = sc->hw->conf.channel;
 	sc->curband = &sc->sbands[sc->curchan->band];
-	sc->imask = AR5K_INT_RXOK | AR5K_INT_TXOK | AR5K_INT_RXEOL |
-		AR5K_INT_RXORN | AR5K_INT_FATAL | AR5K_INT_GLOBAL |
-		AR5K_INT_MIB;
+	sc->imask = AR5K_INT_RXOK | AR5K_INT_RXERR | AR5K_INT_RXEOL |
+		AR5K_INT_RXORN | AR5K_INT_TXDESC | AR5K_INT_TXEOL |
+		AR5K_INT_FATAL | AR5K_INT_GLOBAL | AR5K_INT_MIB;
 	ret = ath5k_reset(sc, false, false);
 	if (ret)
 		goto done;
#1 lore raw
Quoted 10 lines · Nick Kossifidis

*On a previous patch i splitted AR5K_INT_TX to multiple different TX interrupt flags for better handling but i forgot to unmask the new TXDESC and TXEOL interrupts on ath5k_init and only left TXOK. However for each queue we enable TXDESC and TXEOL interrupts, not TXOK so we don't handle TX interrupts at all (because these interrupts remain masked on PISR) and under load it results packet loss. Fix the problem by unmasking TXDESC and TXEOL on ath5k_init.

Signed-off-by Nick Kossifidis <[email protected]>

ACK

#2 lore raw
Quoted 7 lines · Luis R. Rodriguez
Quoted 4 lines · Nick Kossifidis

PISR) and under load it results packet loss. Fix the problem by unmasking TXDESC and TXEOL on ath5k_init.

Signed-off-by Nick Kossifidis <[email protected]>

ACK

Yes, please - worked great here.

Signature · 1 line
Bob Copeland %% www.bobcopeland.com
#3 lore raw

2008/11/4 Bob Copeland <[email protected]>:

Quoted 12 lines
Quoted 7 lines · Luis R. Rodriguez
Quoted 4 lines · Nick Kossifidis

PISR) and under load it results packet loss. Fix the problem by unmasking TXDESC and TXEOL on ath5k_init.

Signed-off-by Nick Kossifidis <[email protected]>

ACK

Yes, please - worked great here.

John any news on this ? Is it ok for inclusion or you want me to respin/rebase it ?

Signature · 3 lines
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick