qtopia4: fix wrong variable name for SQL
PATCH 1/1 qtopia4: fix wrong variable name for SQL
--- package/qtopia4/qtopia4.mk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
package/qtopia4/qtopia4.mk +1 -1
@@ -307,7 +307,7 @@ endif cp -dpfr $(STAGING_DIR)/usr/plugins/imageformats $(TARGET_DIR)/usr/plugins/; \ $(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/plugins/imageformats/*; \ fi -ifneq ($(BR2_PACKAGE_QTOPIA4_SQL),y) +ifneq ($(BR2_PACKAGE_QTOPIA4_SQL_MODULE),y) # Remove Sql libraries, not needed -rm $(TARGET_DIR)/usr/lib/libQtSql* endif
Signature · 1 line
1.6.0.3.524.g3adb7d
PATCH 1/1 qtopia4: fix wrong variable name for SQL
Thanks.
Applied in r23872.
Btw, could you send patches as attachments (instead or as well)? Not sure how others prefers them, but since I don't view my mail on linux boxes and only use linux through ssh I sort of have to apply them by typing it back on the ssh window. Also, I don't trust copy and paste to not mess with the whitespaces and tabs.... If I do mess them up others jump on my neck. Whitespace damage is sort of worst than having a non working package around here *smile*.
Anyway, thanks for spoting that. Sorry for my laziness.
Kind Regards,
Thiago A. Correa
Quoted 26 lines · Markus Heidelberg
Signed-off-by Markus Heidelberg <[email protected]>--- package/qtopia4/qtopia4.mk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)package/qtopia4/qtopia4.mk +1
-2@@ -307,7 +307,7 @@ endif cp -dpfr $(STAGING_DIR)/usr/plugins/imageformats $(TARGET_DIR)/usr/plugins/; \ $(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/plugins/imageformats/*; \ fi -ifneq ($(BR2_PACKAGE_QTOPIA4_SQL),y) +ifneq ($(BR2_PACKAGE_QTOPIA4_SQL_MODULE),y) # Remove Sql libraries, not needed -rm $(TARGET_DIR)/usr/lib/libQtSql* endif --1.6.0.3.524.g3adb7d
_______________________________________________
buildroot mailing list
buildroot at uclibc.org
http://busybox.net/mailman/listinfo/buildroot
PATCH 1/1 qtopia4: fix wrong variable name for SQL
Thiago A. Corr?a, 31.10.2008:
Quoted 5 lines
Thanks.
Applied in r23872.Btw, could you send patches as attachments (instead or as well)? Not sure how others prefers them,
I prefer inline patches, for easier commenting for example. I also find attachments are quite annoying if I have to use the web archives and can't just read the patch but have to download it at first. I know Peter prefers inline for the ease of applying them with "git am" and he has already applied a few from me.
Quoted 3 lines
but since I don't view my mail on linux
boxes and only use linux through ssh I sort of have to apply them by typing it back on the ssh window.
What are the advantages of using attachments or the disadvantages of inline through your ssh connection? When you are able to save an attachment you can also just save the whole email and apply it, can't you?
Quoted 4 lines
Also, I don't trust copy and paste
to not mess with the whitespaces and tabs.... If I do mess them up others jump on my neck. Whitespace damage is sort of worst than having a non working package around here *smile*.
If whitespace is damaged after copy and paste, you will notice it when applying the malformed patch.
Markus
PATCH 1/1 qtopia4: fix wrong variable name for SQL
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Markus" == Markus Heidelberg <[email protected]> writes:
Hi,
Quoted 2 lines
Quoted 2 lines
Btw, could you send patches as attachments (instead or as well)? Not sure how others prefers them,
Markus> I prefer inline patches, for easier commenting for example. I Markus> also find attachments are quite annoying if I have to use the Markus> web archives and can't just read the patch but have to Markus> download it at first. I know Peter prefers inline for the Markus> ease of applying them with "git am" and he has already Markus> applied a few from me.
Exactly!
Quoted 4 lines
Quoted 4 lines
Also, I don't trust copy and paste
to not mess with the whitespaces and tabs.... If I do mess them up others jump on my neck. Whitespace damage is sort of worst than having a non working package around here *smile*.
Markus> If whitespace is damaged after copy and paste, you will Markus> notice it when applying the malformed patch.
Yes.
Thiago, what keeps you from using a proper email client?
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 qtopia4: fix wrong variable name for SQL
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Markus" == Markus Heidelberg <[email protected]> writes:
Hi,
Quoted 2 lines
Quoted 2 lines
Btw, could you send patches as attachments (instead or as well)? Not sure how others prefers them,
Quoted 8 lines
Markus> I prefer inline patches, for easier commenting for example. I Markus> also find attachments are quite annoying if I have to use the Markus> web archives and can't just read the patch but have to Markus> download it at first. I know Peter prefers inline for the Markus> ease of applying them with "git am" and he has already Markus> applied a few from me.
Exactly!
I don't use git, and I guess I never will *smile*.
I agree it's best for commenting, but if it were also as well easier to apply, then it means the submitter doesn't have to wait for Peter to have the time to check it. I or someone else with the same problem as me could do it.
Quoted 5 lines
Quoted 4 lines
Quoted 4 lines
Also, I don't trust copy and paste
to not mess with the whitespaces and tabs.... If I do mess them up others jump on my neck. Whitespace damage is sort of worst than having a non working package around here *smile*.
Quoted 7 lines
Markus> If whitespace is damaged after copy and paste, you will Markus> notice it when applying the malformed patch.
Yes.
Thiago, what keeps you from using a proper email client?
I get rejects whenever I try to apply those git generated patches. It just occured to me that maybe if I use the "show original" in the gmail and copy from that it should work better. Will see in the next patches if this works ;)
PATCH 1/1 qtopia4: fix wrong variable name for SQL
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thiago" == Thiago A Corr?a <[email protected]> writes:
Hi,
Markus> I prefer inline patches, for easier commenting for example. I Markus> also find attachments are quite annoying if I have to use the Markus> web archives and can't just read the patch but have to Markus> download it at first. I know Peter prefers inline for the Markus> ease of applying them with "git am" and he has already Markus> applied a few from me.
Quoted 2 lines
Quoted 2 lines
Exactly!
Thiago> I don't use git, and I guess I never will *smile*.
Pity, you're missing out on good stuff. It's quite easy to get started with git-svn.
Thiago> I agree it's best for commenting, but if it were also as well Thiago> easier to apply, then it means the submitter doesn't have to Thiago> wait for Peter to have the time to check it. I or someone Thiago> else with the same problem as me could do it.
patch -p1 < mail afaik still works, but then you ofcourse have to do the manual svn add / copy commit message ritual.
Quoted 1 line
Quoted 1 line
Thiago, what keeps you from using a proper email client?
Thiago> I get rejects whenever I try to apply those git generated patches. It Thiago> just occured to me that maybe if I use the "show original" in the Thiago> gmail and copy from that it should work better. Will see in the next Thiago> patches if this works ;)
Do you apply them with patch -p1 ?
About cut'n'paste - Careful that you don't get tabs converted to white space on the way.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 qtopia4: fix wrong variable name for SQL
In reply to Thiago A. CorrêaThiago A. Corr?a, 03.11.2008:
Quoted 12 lines
Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Markus" == Markus Heidelberg <[email protected]> writes:
Btw, could you send patches as attachments (instead or as well)? Not sure how others prefers them,
Markus> I prefer inline patches, for easier commenting for example. I Markus> also find attachments are quite annoying if I have to use the Markus> web archives and can't just read the patch but have to Markus> download it at first. I know Peter prefers inline for the Markus> ease of applying them with "git am" and he has already Markus> applied a few from me.
Quoted 3 lines
Quoted 1 line
Exactly!
I don't use git, and I guess I never will *smile*.
Please don't say so, you only put yourself into constraints. When working with svn, I wouldn't be able to create patch series. Nor working on different issues at once without duplicating the tree. Just because I can't commit locally. Even with svn commit access I wouldn't use svn directly. Often you want to backup small incremental changes, but send one single patch upstream. It seems a couple of people are working in this fashion.
But of course you don't have to use git. Inline patches don't have anything to do with git, they are much older.
Quoted 4 lines
I agree it's best for commenting, but if it were also as well easier to apply, then it means the submitter doesn't have to wait for Peter to have the time to check it. I or someone else with the same problem as me could do it.
It IS easy to apply. You are the first person I hear complaining about inline patches. Use a mail client instead of the web interface, saving the mail should be exactly the same effort as saving an attached patch. Web interfaces are fine for reading mails from all over the world but are crap for working with.
Quoted 10 lines
Quoted 10 lines
Quoted 4 lines
Quoted 4 lines
Also, I don't trust copy and paste
to not mess with the whitespaces and tabs.... If I do mess them up others jump on my neck. Whitespace damage is sort of worst than having a non working package around here *smile*.Markus> If whitespace is damaged after copy and paste, you will Markus> notice it when applying the malformed patch.
Yes.
Quoted 7 lines
Quoted 2 lines
Thiago, what keeps you from using a proper email client?
I get rejects whenever I try to apply those git generated patches. It just occured to me that maybe if I use the "show original" in the gmail and copy from that it should work better. Will see in the next patches if this works ;)
If I'd attach the patch, it would also be "git generated". If not damaged whitespace, maybe it was just the -p option as supposed by Peter.
Markus