Skip to contentSkip to conversation

ftrace: fix hardirq.h for m68k

PATCH In review Steven Rostedt 2 participants 3 messages Nov 6, 2008

Subsystems (2)
Linux-next tree ftrace
lore
Share & tools
lore

Steven Rostedt

author maintainer
#0 lore raw

cover ftrace: fix hardirq.h for m68k

[
Lets try this again. This time in the patch directory.
]

Ingo and Stephen,

The problem that Alexey pointed out should be fixed by this trivial patch.

The following patches are in:

git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git

branch: tip/devel

Steven Rostedt (1):
ftrace: split out hardirq ftrace code into own header

author maintainer
#1 lore raw

PATCH 1/1 ftrace: split out hardirq ftrace code into own header

Impact: moving of function prototypes into own header file

ftrace.h is too big of a file for hardirq.h, and some archs will fail to build because of the include dependencies not being met.

This patch pulls out the required prototypes for hardirq.h into a smaller and safer ftrace_irq.h file.

Signed-off-by Steven Rostedt <[email protected]>
---
 include/linux/ftrace.h     |    5 -----
 include/linux/ftrace_irq.h |   13 +++++++++++++
 include/linux/hardirq.h    |    2 +-
 3 files changed, 14 insertions(+), 6 deletions(-)
 create mode 100644 include/linux/ftrace_irq.h
include/linux/ftrace.h +0 -5
index 41054a3..1f5608c 100644
@@ -134,9 +134,6 @@ extern void ftrace_release(void *start, unsigned long size);
 
 extern void ftrace_disable_daemon(void);
 extern void ftrace_enable_daemon(void);
-extern void ftrace_nmi_enter(void);
-extern void ftrace_nmi_exit(void);
-
 #else
 # define skip_trace(ip)				({ 0; })
 # define ftrace_force_update()			({ 0; })

@@ -144,8 +141,6 @@ extern void ftrace_nmi_exit(void);
 # define ftrace_disable_daemon()		do { } while (0)
 # define ftrace_enable_daemon()			do { } while (0)
 static inline void ftrace_release(void *start, unsigned long size) { }
-static inline void ftrace_nmi_enter(void) { }
-static inline void ftrace_nmi_exit(void) { }
 #endif /* CONFIG_DYNAMIC_FTRACE */
 
 /* totally disable ftrace - can not re-enable after this */
include/linux/ftrace_irq.h new file +13 -0
new file mode 100644
index 0000000..b1299d6
@@ -0,0 +1,13 @@
+#ifndef _LINUX_FTRACE_IRQ_H
+#define _LINUX_FTRACE_IRQ_H
+
+
+#ifdef CONFIG_DYNAMIC_FTRACE
+extern void ftrace_nmi_enter(void);
+extern void ftrace_nmi_exit(void);
+#else
+static inline void ftrace_nmi_enter(void) { }
+static inline void ftrace_nmi_exit(void) { }
+#endif
+
+#endif /* _LINUX_FTRACE_IRQ_H */
include/linux/hardirq.h +1 -1
index ffc16ab..89a56d7 100644
@@ -4,7 +4,7 @@
 #include <linux/preempt.h>
 #include <linux/smp_lock.h>
 #include <linux/lockdep.h>
-#include <linux/ftrace.h>
+#include <linux/ftrace_irq.h>
 #include <asm/hardirq.h>
 #include <asm/system.h>
Signature · 3 lines
1.5.6.5

--
#2 lore raw

Re: [PATCH 1/1] ftrace: split out hardirq ftrace code into own header

include/linux/hardirq.h line 7

Quoted 2 lines · Steven Rostedt
include/linux/hardirq.h +1 -1
-#include <linux/ftrace.h>
+#include <linux/ftrace_irq.h>

This helps, please don't forget in merge compile fixes into original patches before pleasepulling.