Skip to contentSkip to conversation

Change default for STRICT_DEVMEM

PATCH In review Matt LaPlante 5 participants 5 messages Nov 7, 2008 – Nov 8, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Change default for STRICT_DEVMEM

The recommendation for STRICT_DEVMEM is to select Y, however the option currently defaults to N. Have the option default to Y since it is recommended.

---
 arch/x86/Kconfig.debug |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/Kconfig.debug +1 -0
index 2a3dfbd..a03597c 100644
@@ -7,6 +7,7 @@ source "lib/Kconfig.debug"
 
 config STRICT_DEVMEM
 	bool "Filter access to /dev/mem"
+	default y
 	help
 	  If this option is disabled, you allow userspace (root) access to all
 	  of memory, including kernel and userspace memory. Accidental
Signature · 1 line
1.5.6.3
#1 lore raw
Quoted 3 lines · On Fri, 7 Nov 2008 14:18:36 -0600 Matt LaPlante <[email protected]>…

The recommendation for STRICT_DEVMEM is to select Y, however the option currently defaults to N. Have the option default to Y since it is recommended.

The recommendation is extremely dubious as it breaks a lot of back compatibility.

#2 lore raw
Quoted 10 lines · On Fri, 7 Nov 2008 22:00:38 +0000 Alan Cox <[email protected]> wrote:
Quoted 3 lines · On Fri, 7 Nov 2008 14:18:36 -0600 Matt LaPlante <[email protected]>…

The recommendation for STRICT_DEVMEM is to select Y, however the option currently defaults to N. Have the option default to Y since it is recommended.

The recommendation is extremely dubious as it breaks a lot of back compatibility.

Revert the default and toggle the recommendation then?

Signature · 1 line
Matt LaPlante <[email protected]>
#3 lore raw
In reply to Alan Cox
Quoted 10 lines · On Fri, 7 Nov 2008 22:00:38 +0000 Alan Cox <[email protected]> wrote:
Quoted 3 lines · On Fri, 7 Nov 2008 14:18:36 -0600 Matt LaPlante <[email protected]>…

The recommendation for STRICT_DEVMEM is to select Y, however the option currently defaults to N. Have the option default to Y since it is recommended.

The recommendation is extremely dubious as it breaks a lot of back compatibility.

the default recommendatiom is a typo. It used to be an "other way around" config option, and it got flipped into a "positive" option rather than a tripple negative, but the help text didn't get fixed properly.

Signature · 3 lines
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
#4 lore raw
In reply to Matt LaPlante
Quoted 7 lines · Matt LaPlante

The recommendation for STRICT_DEVMEM is to select Y, however the option currently defaults to N. Have the option default to Y since it is recommended.

---
 arch/x86/Kconfig.debug |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

no. This is a special case: due to compatibility we default to N, but still we recommend people/distros to enable it. Eventually we can switch around the default in the future, but not yet.

Ingo