e1000e: fix warn_on reload after phy_id error
Subsystems (2)
PATCH 1/1 e1000e: fix warn_on reload after phy_id error
If the driver fails to initialize the first time due to the failure in the phy_id check the kernel triggers a warn_on on the second try to load the driver because the driver did not free the msi/x resources in the first load because of the previous failure in phy_id check.
---
drivers/net/e1000e/netdev.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/e1000e/netdev.c +1 -0
@@ -5009,6 +5009,7 @@ err_hw_init: err_sw_init:if (adapter->hw.flash_address)iounmap (adapter->hw.flash_address); +e1000e_reset_interrupt_capability (adapter); err_flashmap:iounmap (adapter->hw.hw_addr); err_ioremap:
Quoted 4 lines · Jeff Kirsher
If the driver fails to initialize the first time due to the failure in the
phy_idcheck the kernel triggers awarn_onon the second try to load the driver because the driver did not free the msi/x resources in the first load because of the previous failure inphy_idcheck.
Is that all one sentence? Can I buy a comma or semi-colon, Pat? :)
More seriously, this description is not very helpful. A good description precisely outlines the _solution_ ("fix msi/x resource leak"), perhaps with a bit of concise problem description ("failure to free msi/x resources").
Your description focuses mostly on what the user/tester experiences and observes, whereas in a changeset description the most important thing to communicate is to describe the engineering change to the driver (proper release of resources).
Jeff