powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE
PATCH 1/1 powerpc/qe: Select QE_USB with USB_GADGET_FSL_QE
Boards should know when QE_USB is used, so that they can configure USB clocks and pins.
Another option would be to add 'select QE_USB' into USB_GADGET_FSL_QE, but selects are evil since they don't support dependencies.
While at it, also remove 'host' from the symbol description, since the QE_USB code is used to support the gadget driver as well.
--- arch/powerpc/sysdev/qe_lib/Kconfig | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
arch/powerpc/sysdev/qe_lib/Kconfig +2 -1
@@ -22,5 +22,6 @@ config UCC config QE_USB bool + default y if USB_GADGET_FSL_QE help - QE USB Host Controller support + QE USB Controller support
Signature · 1 line
1.5.6.3
Quoted 5 lines · Anton Vorontsov
Boards should know when
QE_USBis used, so that they can configure USB clocks and pins.Another option would be to add 'select
QE_USB' intoUSB_GADGET_FSL_QE, but selects are evil since they don't support dependencies.
Can anyone explain *why* select ignores dependencies, rather than recursively enabling the dependencies (and giving an error if it can't, or if a dependency has an || in it and is unmet)?
-Scott
Quoted 11 lines · Anton Vorontsov
Boards should know when
QE_USBis used, so that they can configure USB clocks and pins.Another option would be to add 'select
QE_USB' intoUSB_GADGET_FSL_QE, but selects are evil since they don't support dependencies.While at it, also remove 'host' from the symbol description, since the
QE_USBcode is used to support the gadget driver as well.Signed-off-by Anton Vorontsov <[email protected]>---
Anything wrong with this one?
Thanks,
Quoted 21 lines
arch/powerpc/sysdev/qe_lib/Kconfig | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)arch/powerpc/sysdev/qe_lib/Kconfig +2
-1@@ -22,5 +22,6 @@ config UCC config QE_USB bool + default y if USB_GADGET_FSL_QE help - QE USB Host Controller support + QE USB Controller supportSignature · 5 lines
1.5.6.3 _______________________________________________ Linuxppc-dev mailing list [email protected] https://ozlabs.org/mailman/listinfo/linuxppc-dev
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
Quoted 7 lines · Anton Vorontsov
Quoted 6 lines · Anton Vorontsov
Boards should know when
QE_USBis used, so that they can configure USB clocks and pins.Another option would be to add 'select
QE_USB' intoUSB_GADGET_FSL_QE, but selects are evil since they don't support dependencies.
Quoted 7 lines
Quoted 5 lines
While at it, also remove 'host' from the symbol description, since the
QE_USBcode is used to support the gadget driver as well.Signed-off-by Anton Vorontsov <[email protected]>---
Anything wrong with this one?
Without this patch QE UDC won't work (board file won't configure the USB clocks and pins).
Thanks,
Quoted 17 lines
Quoted 17 lines
arch/powerpc/sysdev/qe_lib/Kconfig | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)arch/powerpc/sysdev/qe_lib/Kconfig +2
-1@@ -22,5 +22,6 @@ config UCC config QE_USB bool + default y if USB_GADGET_FSL_QE help - QE USB Host Controller support + QE USB Controller supportSignature · 1 line
1.5.6.3
Signature · 3 lines
Anton Vorontsov email: [email protected] irc://irc.freenode.net/bd2
Kumar Gala
AppliedQuoted 6 lines · Anton Vorontsov
Boards should know when
QE_USBis used, so that they can configure USB clocks and pins.Another option would be to add 'select
QE_USB' intoUSB_GADGET_FSL_QE, but selects are evil since they don't support dependencies.
Quoted 7 lines
While at it, also remove 'host' from the symbol description, since the
QE_USBcode is used to support the gadget driver as well.Signed-off-by Anton Vorontsov <[email protected]>---
arch/powerpc/sysdev/qe_lib/Kconfig| 3 ++-1 files changed, 2 insertions(+), 1 deletions(-)
applied to next
- k