orinoco: fix last beacon reporting on 64-bit systems

PATCH In review Pavel Roskin 2 participants 2 messages Nov 10, 2008 – Nov 12, 2008 Networking drivers (wireless)

Share & tools

Pavel Roskin

author

2008-11-10 14:26 UTC #0 lore raw

PATCH 1/1 orinoco: fix last beacon reporting on 64-bit systems

orinoco_translate_scan() and orinoco_translate_ext_scan() wrongly truncate last_scanned argument from unsigned long to unsigned int.

Signed-off-by Pavel Roskin <[email protected]>

---
 drivers/net/wireless/orinoco/orinoco.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

drivers/net/wireless/orinoco/orinoco.c +2 -2

index 12059f4..da5ba5e 100644
@@ -5448,7 +5448,7 @@ static inline char *orinoco_translate_scan(struct net_device *dev,
 					   char *current_ev,
 					   char *end_buf,
 					   union hermes_scan_info *bss,
-					   unsigned int last_scanned)
+					   unsigned long last_scanned)
 {
 	struct orinoco_private *priv = netdev_priv(dev);
 	u16			capabilities;

@@ -5595,7 +5595,7 @@ static inline char *orinoco_translate_ext_scan(struct net_device *dev,
 					       char *current_ev,
 					       char *end_buf,
 					       struct agere_ext_scan_info *bss,
-					       unsigned int last_scanned)
+					       unsigned long last_scanned)
 {
 	u16			capabilities;
 	u16			channel;

Dave

2008-11-12 00:49 UTC #1 lore raw

Quoted 4 lines · Pavel Roskin

orinoco_translate_scan() and orinoco_translate_ext_scan() wrongly truncate last_scanned argument from unsigned long to unsigned int.
Signed-off-by Pavel Roskin <[email protected]>

Well spotted. IIRC that was the one of the issues you noticed with scan output when testing my WPA patch series.

ACK from me, if it matters.

Dave.