Skip to contentSkip to conversation

avr32/bootm: remove unused variable 'ret'

PATCH New Jean-Christophe PLAGNIOL-VILLARD 4 participants 8 messages Nov 11, 2008 – Dec 8, 2008

lore
Share & tools
lore

Jean-Christophe PLAGNIOL-VILLARD

author
#0 lore raw

PATCH 1/1 avr32/bootm: remove unused variable 'ret'

Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
lib_avr32/bootm.c +0 -1
index 556e3ea..03ab8d1 100644
@@ -176,7 +176,6 @@ int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images)
 	void	(*theKernel)(int magic, void *tagtable);
 	struct	tag *params, *params_start;
 	char	*commandline = getenv("bootargs");
-	int	ret;
 
 	if ((flag != 0) && (flag != BOOTM_STATE_OS_GO))
 		return 1;
Signature · 1 line
1.5.6.5
author
#1 lore raw

PATCH 1/1 avr32/cmd_bdinfo: fix printf() format warnings

Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
common/cmd_bdinfo.c +1 -1
index 6675241..087eda7 100644
@@ -378,7 +378,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 	}
 	puts ("\nip_addr     = ");
 	print_IPaddr (bd->bi_ip_addr);
-	printf ("\nbaudrate    = %d bps\n", bd->bi_baudrate);
+	printf ("\nbaudrate    = %ld bps\n", bd->bi_baudrate);
 
 	return 0;
 }
Signature · 1 line
1.5.6.5
#2 lore raw

PATCH 1/1 avr32/cmd_bdinfo: fix printf() format warnings

common/cmd_bdinfo.c

Quoted 6 lines · Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
common/cmd_bdinfo.c +0 -0
index 6675241..087eda7 100644

Subject mentions avr32/cmd_bdinfo while you touch common/cmd_bdinfo.c? Typo?

Dirk

Quoted 9 lines
common/cmd_bdinfo.c +1 -1
@@ -378,7 +378,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 	}
 	puts ("\nip_addr     = ");
 	print_IPaddr (bd->bi_ip_addr);
-	printf ("\nbaudrate    = %d bps\n", bd->bi_baudrate);
+	printf ("\nbaudrate    = %ld bps\n", bd->bi_baudrate);
 
 	return 0;
 }
author
#3 lore raw

PATCH 1/1 avr32/cmd_bdinfo: fix printf() format warnings

Quoted 10 lines · Dirk Behme

common/cmd_bdinfo.c

Quoted 6 lines · Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
common/cmd_bdinfo.c +0 -0
index 6675241..087eda7 100644

Subject mentions avr32/cmd_bdinfo while you touch common/cmd_bdinfo.c? Typo?

no the common/cmd_bdinfo regroup all arch I specify which one I've test and fix

Best Regards,
J.

#4 lore raw

PATCH 1/1 avr32/cmd_bdinfo: fix printf() format warnings

Dear Jean-Christophe PLAGNIOL-VILLARD,

Quoted 11 lines · In message <[email protected]> you wrote:
Quoted 10 lines · Dirk Behme

common/cmd_bdinfo.c

Quoted 6 lines · Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
common/cmd_bdinfo.c +0 -0
index 6675241..087eda7 100644

Subject mentions avr32/cmd_bdinfo while you touch common/cmd_bdinfo.c? Typo?

Quoted 2 lines

no the common/cmd_bdinfo regroup all arch I specify which one I've test and fix

I cannot make heads or tails from this comment.

Fact is that subject and code do not agree.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No one can guarantee the actions of another.
	-- Spock, "Day of the Dove", stardate unknown
#5 lore raw

PATCH 1/1 avr32/bootm: remove unused variable 'ret'

In reply to Jean-Christophe PLAGNIOL-VILLARD
Quoted 1 line · Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Acked-by Haavard Skinnemoen <[email protected]>

I'm a bit out of sync at the moment. Wolfgang, can you apply it directly?

Quoted 12 lines
lib_avr32/bootm.c +0 -1
index 556e3ea..03ab8d1 100644
@@ -176,7 +176,6 @@ int do_bootm_linux(int flag, int argc, char *argv[], bootm_headers_t *images)
 	void	(*theKernel)(int magic, void *tagtable);
 	struct	tag *params, *params_start;
 	char	*commandline = getenv("bootargs");
-	int	ret;
 
 	if ((flag != 0) && (flag != BOOTM_STATE_OS_GO))
 		return 1;
#6 lore raw

PATCH 1/1 avr32/bootm: remove unused variable 'ret'

Dear Haavard Skinnemoen,

Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 1 line · Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
Acked-by Haavard Skinnemoen <[email protected]>

I'm a bit out of sync at the moment. Wolfgang, can you apply it directly?

Sure, done.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"That unit is a woman."
"A mass of conflicting impulses."
	-- Spock and Nomad, "The Changeling", stardate 3541.9
Applied
#7 lore raw

PATCH 1/1 avr32/bootm: remove unused variable 'ret'

In reply to Jean-Christophe PLAGNIOL-VILLARD

Dear Jean-Christophe PLAGNIOL-VILLARD,

lib_avr32/bootm.c

Quoted 6 lines · In message <[email protected]> you wrote:
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
lib_avr32/bootm.c +0 -0
index 556e3ea..03ab8d1 100644

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
f u cn rd ths, itn tyg h myxbl cd.