Skip to contentSkip to conversation

atl1e: remove unnecessary crc inversion

PATCH New J. K. Cliburn 1 participant 1 message Nov 11, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

J. K. Cliburn

author
#0 lore raw

PATCH 1/1 atl1e: remove unnecessary crc inversion

atl1e: remove unnecessary crc inversion

Inverting the crc after calling ether_crc_le() is unnecessary and breaks multicast. Remove it.

Tested-by David Madore <[email protected]>
Signed-off-by Jay Cliburn <[email protected]>
Cc [email protected]
---
 drivers/net/atl1e/atl1e_hw.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
drivers/net/atl1e/atl1e_hw.c +0 -4
index 949e753..c0d5f7c 100644
@@ -163,9 +163,6 @@ int atl1e_read_mac_addr(struct atl1e_hw *hw)
  * atl1e_hash_mc_addr
  *  purpose
  *      set hash value for a multicast address
- *      hash calcu processing :
- *          1. calcu 32bit CRC for multicast address
- *          2. reverse crc with MSB to LSB
  */
 u32 atl1e_hash_mc_addr(struct atl1e_hw *hw, u8 *mc_addr)
 {

@@ -174,7 +171,6 @@ u32 atl1e_hash_mc_addr(struct atl1e_hw *hw, u8 *mc_addr)
 	int i;
 
 	crc32 = ether_crc_le(6, mc_addr);
-	crc32 = ~crc32;
 	for (i = 0; i < 32; i++)
 		value |= (((crc32 >> i) & 1) << (31 - i));
Signature · 1 line
1.5.6.5