markers: Add missing stdargs.h include, needed due to va_list usage
PATCH 1/1 markers: Add missing stdargs.h include, needed due to va_list usage
include/linux/marker.h +1 -0
@@ -12,6 +12,7 @@* See the file COPYING for more details. */ +#include <stdarg.h> #include <linux/types.h> struct module ;
include/linux/marker.h line 15
Quoted 9 lines · * Arnaldo Carvalho de Melo ([email protected]) wrote:
include/linux/marker.h +1
-0@@ -12,6 +12,7 @@* See the file COPYING for more details. */ +#include <stdarg.h>
Hrm given it's already included in kernel.h for printk, I am not sure it's required here ? Although it cannot hurt to add it explicitly.
Mathieu
Quoted 3 lines
include/linux/marker.h +0
-0#include <linux/types.h> struct module ;
Signature · 2 lines
Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
Em Wed, Nov 12, 2008 at 12:21:47PM -0500, Mathieu Desnoyers escreveu:
Quoted 9 lines · * Arnaldo Carvalho de Melo ([email protected]) wrote:
Quoted 8 lines
include/linux/marker.h +0
-0@@ -12,6 +12,7 @@* See the file COPYING for more details. */
Quoted 4 lines
include/linux/marker.h line 15
Quoted 1 line
include/linux/marker.h +1
-0+#include <stdarg.h> Hrm given it's already included in
kernel.hfor printk, I am not sure it's required here ? Although it cannot hurt to add it explicitly.
Well, its just that while writing code I noticed that if I included marker.h as the first include the compilation would fail.
My impression was that if you use something, you should include its definition, not relying on the includes hell.
Quoted 5 lines
Mathieu
Quoted 3 lines
include/linux/marker.h +0
-0#include <linux/types.h> struct module ;
Mathieu Desnoyers
Acked-byQuoted 15 lines · * Arnaldo Carvalho de Melo ([email protected]) wrote:
Em Wed, Nov 12, 2008 at 12:21:47PM -0500, Mathieu Desnoyers escreveu:
Quoted 9 lines · * Arnaldo Carvalho de Melo ([email protected]) wrote:
Quoted 8 lines
include/linux/marker.h +0
-0@@ -12,6 +12,7 @@* See the file COPYING for more details. */ Quoted 4 lines
include/linux/marker.h line 15
Quoted 1 line
include/linux/marker.h +1
-0+#include <stdarg.h> Hrm given it's already included in
kernel.hfor printk, I am not sure it's required here ? Although it cannot hurt to add it explicitly.
Quoted 6 lines
Well, its just that while writing code I noticed that if I included
marker.has the first include the compilation would fail.My impression was that if you use something, you should include its definition, not relying on the includes hell.
Ok,
Thanks,
Mathieu
Quoted 5 lines
Quoted 5 lines
Mathieu
Quoted 3 lines
include/linux/marker.h +0
-0#include <linux/types.h> struct module ;
Signature · 2 lines
Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68