package: don't default to y for categories
PATCH 1/1 package: don't default to y for categories
When doing 'make oldconfig' after a new category has been added, you can't simply press <Enter> to go on without branching into that category. Packages default to n and there is no reason to proceed with the categories in a different manner.
--- package/Config.in | 8 -------- package/audio/Config.in | 1 - package/database/Config.in | 1 - package/editors/Config.in | 1 - package/games/Config.in | 1 - package/java/Config.in | 1 - 6 files changed, 0 insertions(+), 13 deletions(-)
package/Config.in +0 -8
@@ -28,7 +28,6 @@ endif #menuconfig BR2_APPLICATION_SUPPORT # bool "Common Applications" -# default y # help # A set of applications, utilities and libraries for # text processing, toolchain generation and other things.
@@ -132,7 +131,6 @@ endif menuconfig BR2_NETWORK_SUPPORT bool "Networking" - default y help Support for communication, networking and related packages
@@ -233,7 +231,6 @@ endif menuconfig BR2_BLOCKDEV_SUPPORT bool "Hardware handling / blockdevices and filesystem maintenance" - default y help Support for hardware handling and maintenance, block devices, filesystem creation and maintenance.
@@ -294,7 +291,6 @@ source "package/audio/Config.in" menuconfig BR2_GRAPHIC_SUPPORT bool "Graphic libraries and applications (graphic/text)" - default y help Support for graphic libraries, X Window system and related packages, graphical toolkits, etc.
@@ -417,7 +413,6 @@ endif menuconfig BR2_COMPRESSOR_SUPPORT bool "Compressors / decompressors" - default y help Support for compressors and decompressors like lzo, lzma, bzip2
@@ -432,7 +427,6 @@ endif menuconfig BR2_PACKAGEMGRS_SUPPORT bool "Package managers" - default y help Support for package managers like rpm, portage, ipkg, ..
@@ -446,7 +440,6 @@ endif menuconfig BR2_SCRIPTING_SUPPORT bool "Interpreter languages / Scripting" - default y help Support for scripting languages, interpreter languages.
@@ -461,7 +454,6 @@ endif menuconfig BR2_XML_SUPPORT bool "XML handling" - default y help Support for XML handling
package/audio/Config.in +0 -1
@@ -1,6 +1,5 @@ menuconfig BR2_AUDIO_SUPPORT bool "Audio libraries and applications" - default y help Support for audio libraries and applications
package/database/Config.in +0 -1
@@ -1,6 +1,5 @@ menuconfig BR2_DATABASE_SUPPORT bool "Database" - default y if BR2_DATABASE_SUPPORT source "package/database/mysql_client/Config.in"
package/editors/Config.in +0 -1
@@ -1,6 +1,5 @@ menuconfig BR2_TEXTEDIT_SUPPORT bool "Text editors" - default y help Support for text editors
package/games/Config.in +0 -1
@@ -1,6 +1,5 @@ menuconfig BR2_GAMES bool "Games" - default y help Support for games
package/java/Config.in +0 -1
@@ -1,6 +1,5 @@ menuconfig BR2_JAVA_SUPPORT bool "Java" - default y help Support java programs (classpath, vm, osgi)
Signature · 1 line
1.6.0.4.620.g87fa
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 package: don't default to y for categories
Arnar Mar Sig, 13.11.2008:
Quoted 5 lines
How about creating new categories for the packages on the main "package selection for target" page?
Personally I thing there are way to many package on the main page and I'm board of always scolling thru it to.
That's what I think, too. Some more order would be nice. I also find the scrolling quite annoying.
Markus
PATCH 1/1 package: don't default to y for categories
Quoted 10 lines · On Fri, 14 Nov 2008 09:57:05 +0100 Markus Heidelberg…
Arnar Mar Sig, 13.11.2008:
Quoted 5 lines
How about creating new categories for the packages on the main "package selection for target" page?
Personally I thing there are way to many package on the main page and I'm board of always scolling thru it to.
That's what I think, too. Some more order would be nice. I also find the scrolling quite annoying.
A bit OT; the sub package selection directory should be selected when you have a package selected beneath. That way you can not disable compression stuff, when you have ZLIB selected by other packages.
Signature · 2 lines
Best regards, Hans-Christian Egtvedt
PATCH 1/1 package: don't default to y for categories
Hans-Christian Egtvedt, 14.11.2008:
Quoted 10 lines
Quoted 7 lines · On Fri, 14 Nov 2008 09:57:05 +0100 Markus Heidelberg…
Arnar Mar Sig, 13.11.2008:
Quoted 5 lines
How about creating new categories for the packages on the main "package selection for target" page?
Personally I thing there are way to many package on the main page and I'm board of always scolling thru it to.
Quoted 7 lines
Quoted 3 lines
That's what I think, too. Some more order would be nice. I also find the scrolling quite annoying.
A bit OT; the sub package selection directory should be selected when you have a package selected beneath. That way you can not disable compression stuff, when you have ZLIB selected by other packages.
Damn, I see. So please forget the patch for now.
Markus
PATCH 1/1 package: don't default to y for categories
Quoted 3 lines · On Fri, 14 Nov 2008 10:21:18 +0100 Markus Heidelberg…
Hans-Christian Egtvedt, 14.11.2008:
Quoted 2 lines
On Fri, 14 Nov 2008 09:57:05 +0100
Markus Heidelberg <[email protected]> wrote:
<snipp>
Quoted 7 lines
Quoted 4 lines
A bit OT; the sub package selection directory should be selected when you have a package selected beneath. That way you can not disable compression stuff, when you have ZLIB selected by other packages.
Damn, I see. So please forget the patch for now.
It was more a remark about a general "bug" in the menu system generated by kconfig now. Just look at the kernel, if you select a driver beneath SPI, then you are not able to deselect the SPI category. I think we should do the same with the kconfig in Buildroot.
Signature · 2 lines
Best regards, Hans-Christian Egtvedt
PATCH 1/1 package: don't default to y for categories
Le Fri, 14 Nov 2008 10:52:26 +0100,
Hans-Christian Egtvedt <[email protected]> a ?crit :
Quoted 4 lines
It was more a remark about a general "bug" in the menu system generated by kconfig now. Just look at the kernel, if you select a driver beneath SPI, then you are not able to deselect the SPI category. I think we should do the same with the kconfig in Buildroot.
This is important when enabling a category enables the compilation of a particular set of code, required for the items available under this specific category.
In our case, the categories ? Graphical libraries ?, ? Audio stuff ? and others do not lead to anything being compiled, except if I'm wrong. So I would say that we shouldn't be able to select/unselect the categories. They should just be submenus, to organize the options, not more.
Look at the top of the kernel configuration system. Networking support can be enabled/disabled as a whole, while Device Drivers is just a submenu. Our categories should be like Device Drivers, IMO.
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 package: don't default to y for categories
Quoted 13 lines · On Fri, 14 Nov 2008 11:15:45 +0100 Thomas Petazzoni…
Le Fri, 14 Nov 2008 10:52:26 +0100,
Hans-Christian Egtvedt <[email protected]> a ?crit :Quoted 5 lines
It was more a remark about a general "bug" in the menu system generated by kconfig now. Just look at the kernel, if you select a driver beneath SPI, then you are not able to deselect the SPI category. I think we should do the same with the kconfig in Buildroot.
This is important when enabling a category enables the compilation of a particular set of code, required for the items available under this specific category.
Quoted 6 lines
In our case, the categories ? Graphical libraries ?, ? Audio stuff ? and others do not lead to anything being compiled, except if I'm wrong. So I would say that we shouldn't be able to select/unselect the categories. They should just be submenus, to organize the options, not more.
Ah, even more sane. I think I for long time ago (probably fixed now) that LZO was not compiled if the compression menu was not selected. LZO was selected by some other packages in a different sub menu.
Anyways, it was the LZO package which should have been fixed, not the menu system.
Quoted 4 lines
Look at the top of the kernel configuration system. Networking support can be enabled/disabled as a whole, while Device Drivers is just a submenu. Our categories should be like Device Drivers, IMO.
Yes, that is smoother IMHO.
Signature · 2 lines
Best regards, Hans-Christian Egtvedt
PATCH 1/1 package: don't default to y for categories
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Hans-Christian" == Hans-Christian Egtvedt <[email protected]> writes:
Hi,
Quoted 6 lines
Quoted 6 lines
In our case, the categories ? Graphical libraries ?, ? Audio stuff ? and others do not lead to anything being compiled, except if I'm wrong. So I would say that we shouldn't be able to select/unselect the categories. They should just be submenus, to organize the options, not more.
Hans-Christian> Ah, even more sane. I think I for long time ago Hans-Christian> (probably fixed now) that LZO was not compiled if the Hans-Christian> compression menu was not selected. LZO was selected Hans-Christian> by some other packages in a different sub menu.
I actually think that's still the case as we don't source the Config.in files of the stuff in the sub menus if the menu isn't enabled.
Quoted 4 lines
Quoted 4 lines
Look at the top of the kernel configuration system. Networking support can be enabled/disabled as a whole, while Device Drivers is just a submenu. Our categories should be like Device Drivers, IMO.
Hans-Christian> Yes, that is smoother IMHO.
I agree. I'll change the sub menus to use menu / endmenu instead of menuconfig. This does mean that you no longer can deselect all packages in a submenu simply by deselecting the menu, but as all packages default to n that shouldn't be a big deal.
Signature · 1 line
Bye, Peter Korsgaard