Skip to contentSkip to conversation

USB patches for 2.6-git

PATCH In review Greg KH 4 participants 9 messages Nov 13, 2008 – Nov 14, 2008

lore
Share & tools
lore

Greg KH

author
#0 lore raw

PATCH 1/1 USB patches for 2.6-git

Here are a few USB patches for your 2.6-git tree.

These patches are:
- lots of new device ids for different drivers
- usb storage quirks
- documentation fixes
- ehci fixes
- ps3 shutdown fix
- musb driver fixes (this is the majority of these patches)
- misc fixes

Please pull from:

	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/usb-2.6.git/

All of these have been in the -next and -mm releases for a while.

The full patches will be sent to the linux-usb mailing list, if anyone wants to see them.

thanks,

greg k-h

------------

 drivers/block/ub.c                  |   20 ++++-
 drivers/net/usb/asix.c              |    4 +
 drivers/usb/class/cdc-acm.c         |    9 +-
 drivers/usb/core/message.c          |    1 +
 drivers/usb/core/sysfs.c            |    2 +-
 drivers/usb/core/urb.c              |    4 +-
 drivers/usb/gadget/f_acm.c          |    4 +
 drivers/usb/host/Kconfig            |   23 ++----
 drivers/usb/host/ehci-hcd.c         |   25 +++---
 drivers/usb/host/ehci-ps3.c         |    1 +
 drivers/usb/host/ehci-sched.c       |    4 +-
 drivers/usb/host/isp1760-if.c       |   22 +++---
 drivers/usb/host/ohci-ps3.c         |    3 +-
 drivers/usb/host/r8a66597-hcd.c     |    5 +-
 drivers/usb/misc/sisusbvga/sisusb.c |    1 +
 drivers/usb/misc/vstusb.c           |    2 +-
 drivers/usb/musb/musb_core.c        |    6 +-
 drivers/usb/musb/musb_debug.h       |    4 +-
 drivers/usb/musb/musb_host.c        |  159 ++++++++++++++++++++++-------------
 drivers/usb/musb/musb_host.h        |    1 +
 drivers/usb/musb/omap2430.c         |    2 +
 drivers/usb/musb/tusb6010.c         |    2 +-
 drivers/usb/serial/cp2101.c         |    2 +
 drivers/usb/serial/option.c         |    6 ++
 drivers/usb/storage/Kconfig         |    4 +-
 drivers/usb/storage/unusual_devs.h  |   22 +++++
 include/linux/usb.h                 |    2 +
 27 files changed, 218 insertions(+), 122 deletions(-)

---------------

Ajay Kumar Gupta (3):
usb: musb: Fix for isochronous IN transfer
usb: musb: Removes compilation warning in gadget mode
usb: musb: fix BULK request on different available endpoints

Alan Stern (4):
USB: don't register endpoints for interfaces that are going away
USB: unusual_devs entry for Argosy USB mass-storage interface
USB: EHCI: fix handling of dead controllers
USB: EHCI: fix divide-by-zero bug

Albert Comerma (1):

      USB: SISUSB2VGA driver: add 0x0711, 0x0903

Brandon Philips (1):
USB: cdc-acm.c: fix recursive lock in acm_start_wb error path

Craig Shelley (1):
USB: CP2101 Add device ID for AMB2560

Damir N Abdullin (1):
+ usb-serial-cp2101-add-enfora-gsm2228.patch added to -mm tree

David Brownell (1):
USB: gadget: cdc-acm deadlock fix

Felipe Balbi (2):
usb: musb: tusb6010: kill compile warning
usb: musb: fix debug global variable name

Geoff Levand (1):
USB: Fix PS3 USB shutdown problems

Greg Kroah-Hartman (1):
USB: vstusb: fix compiler warning on x86-64

Jason Cooper (1):
USB: net: asix: add support for Cables-to-Go USB Ethernet adapter

Leslie Watter (1):
USB: Add YISO u893 usb modem vendor and product IDs to option driver

Paul Bolle (1):
USB: storage: adjust comment in Kconfig

Paul Ready (1):
USB: add Nikon D300 camera to unusual_devs

Pete Zaitcev (1):
ub: stub pre_reset and post_reset to fix oops

Rabin Vincent (1):
USB: mention URB_FREE_BUFFER in usb_free_urb documentation

Ricky Wong (1):
usb: unusual devs patch for Nokia 7610 Supernova

Sebastian Andrzej Siewior (1):
USB: remove optional bus bindings in isp1760, fixing runtime warning

Yoshihiro Shimoda (1):
usb: r8a66597-hcd: fix wrong data access in SuperH on-chip USB

#1 lore raw

Hi Greg,

There is a difference in the musb patch I submitted and the one which actually has been forwarded to you by Felipe. This difference has introduced a bug.

The patch in you series is,
usb: musb: fix BULK request on different available endpoints

It was submitted by me at,
http://marc.info/?l=linux-usb&m=122337227617797&w=2

And the one which is forwarded to you by Felipe is at,
http://marc.info/?l=linux-usb&m=122528597316728&w=2

There is a difference in between above two as below.
Original: + if (best_end < 0 && qh->type == USB_ENDPOINT_XFER_BULK) {
Sent to you: + if (best_end > 0 && qh->type == USB_ENDPOINT_XFER_BULK) {

It should be [best_end < 0].

If it is possible then please correct this mismatch in your series.

Regards,
Ajay

Quoted 130 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Greg KH
Sent: Friday, November 14, 2008 4:33 AM
To: Linus Torvalds; Andrew Morton
Cc: [email protected]; [email protected]
Subject: [GIT PATCH] USB patches for 2.6-git

Here are a few USB patches for your 2.6-git tree.

These patches are:
- lots of new device ids for different drivers
- usb storage quirks
- documentation fixes
- ehci fixes
- ps3 shutdown fix
- musb driver fixes (this is the majority of these patches)
- misc fixes

Please pull from:

	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/usb-2.6.git/

All of these have been in the -next and -mm releases for a while.

The full patches will be sent to the linux-usb mailing list, if anyone wants to see them.

thanks,

greg k-h

------------

 drivers/block/ub.c                  |   20 ++++-
 drivers/net/usb/asix.c              |    4 +
 drivers/usb/class/cdc-acm.c         |    9 +-
 drivers/usb/core/message.c          |    1 +
 drivers/usb/core/sysfs.c            |    2 +-
 drivers/usb/core/urb.c              |    4 +-
 drivers/usb/gadget/f_acm.c          |    4 +
 drivers/usb/host/Kconfig            |   23 ++----
 drivers/usb/host/ehci-hcd.c         |   25 +++---
 drivers/usb/host/ehci-ps3.c         |    1 +
 drivers/usb/host/ehci-sched.c       |    4 +-
 drivers/usb/host/isp1760-if.c       |   22 +++---
 drivers/usb/host/ohci-ps3.c         |    3 +-
 drivers/usb/host/r8a66597-hcd.c     |    5 +-
 drivers/usb/misc/sisusbvga/sisusb.c |    1 +
 drivers/usb/misc/vstusb.c           |    2 +-
 drivers/usb/musb/musb_core.c        |    6 +-
 drivers/usb/musb/musb_debug.h       |    4 +-
 drivers/usb/musb/musb_host.c        |  159 ++++++++++++++++++++++-------------
 drivers/usb/musb/musb_host.h        |    1 +
 drivers/usb/musb/omap2430.c         |    2 +
 drivers/usb/musb/tusb6010.c         |    2 +-
 drivers/usb/serial/cp2101.c         |    2 +
 drivers/usb/serial/option.c         |    6 ++
 drivers/usb/storage/Kconfig         |    4 +-
 drivers/usb/storage/unusual_devs.h  |   22 +++++
 include/linux/usb.h                 |    2 +
 27 files changed, 218 insertions(+), 122 deletions(-)

---------------

Ajay Kumar Gupta (3):
usb: musb: Fix for isochronous IN transfer
usb: musb: Removes compilation warning in gadget mode
usb: musb: fix BULK request on different available endpoints

Alan Stern (4):
USB: don't register endpoints for interfaces that are going away
USB: unusual_devs entry for Argosy USB mass-storage interface
USB: EHCI: fix handling of dead controllers
USB: EHCI: fix divide-by-zero bug

Albert Comerma (1):

      USB: SISUSB2VGA driver: add 0x0711, 0x0903

Brandon Philips (1):
USB: cdc-acm.c: fix recursive lock in acm_start_wb error path

Craig Shelley (1):
USB: CP2101 Add device ID for AMB2560

Damir N Abdullin (1):
+ usb-serial-cp2101-add-enfora-gsm2228.patch added to -mm tree

David Brownell (1):
USB: gadget: cdc-acm deadlock fix

Felipe Balbi (2):
usb: musb: tusb6010: kill compile warning
usb: musb: fix debug global variable name

Geoff Levand (1):
USB: Fix PS3 USB shutdown problems

Greg Kroah-Hartman (1):
USB: vstusb: fix compiler warning on x86-64

Jason Cooper (1):
USB: net: asix: add support for Cables-to-Go USB Ethernet adapter

Leslie Watter (1):
USB: Add YISO u893 usb modem vendor and product IDs to option driver

Paul Bolle (1):
USB: storage: adjust comment in Kconfig

Paul Ready (1):
USB: add Nikon D300 camera to unusual_devs

Pete Zaitcev (1):
ub: stub pre_reset and post_reset to fix oops

Rabin Vincent (1):
USB: mention URB_FREE_BUFFER in usb_free_urb documentation

Ricky Wong (1):
usb: unusual devs patch for Nokia 7610 Supernova

Sebastian Andrzej Siewior (1):
USB: remove optional bus bindings in isp1760, fixing runtime warning

Yoshihiro Shimoda (1):
usb: r8a66597-hcd: fix wrong data access in SuperH on-chip USB

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 17 lines · Ajay Kumar

Hi Greg,

There is a difference in the musb patch I submitted and the one which actually has been forwarded to you by Felipe. This difference has introduced a bug.

The patch in you series is,
usb: musb: fix BULK request on different available endpoints

It was submitted by me at,
http://marc.info/?l=linux-usb&m=122337227617797&w=2

And the one which is forwarded to you by Felipe is at,
http://marc.info/?l=linux-usb&m=122528597316728&w=2

Quoted 7 lines

There is a difference in between above two as below.
Original: + if (best_end < 0 && qh->type == USB_ENDPOINT_XFER_BULK) {
Sent to you: + if (best_end > 0 && qh->type == USB_ENDPOINT_XFER_BULK) {

It should be [best_end < 0].

If it is possible then please correct this mismatch in your series.

I'll wait to get a patch from Felipe for this.

thanks,

greg k-h

#3 lore raw

Hello.

Quoted 18 lines · Greg KH
Quoted 17 lines

Hi Greg,

There is a difference in the musb patch I submitted and the one which actually has been forwarded to you by Felipe. This difference has introduced a bug.

The patch in you series is,
usb: musb: fix BULK request on different available endpoints

It was submitted by me at,
http://marc.info/?l=linux-usb&m=122337227617797&w=2

And the one which is forwarded to you by Felipe is at,
http://marc.info/?l=linux-usb&m=122528597316728&w=2

There is a difference in between above two as below.
Original: + if (best_end < 0 && qh->type == USB_ENDPOINT_XFER_BULK) {
Sent to you: + if (best_end > 0 && qh->type == USB_ENDPOINT_XFER_BULK) {

Quoted 5 lines
Quoted 3 lines

It should be [best_end < 0].

If it is possible then please correct this mismatch in your series.

I'll wait to get a patch from Felipe for this.

I'm seeing it being to you sent at least a week ago -- look for "usb:
musb: fix bug in musb_schedule".

Quoted 2 lines

thanks,
greg k-h

WBR, Sergei

#4 lore raw
Quoted 23 lines · Sergei Shtylyov

Hello.

Quoted 18 lines · Greg KH
Quoted 18 lines

Hi Greg,

There is a difference in the musb patch I submitted and the one which actually has been
forwarded to you by Felipe. This difference has introduced a bug.

The patch in you series is,
usb: musb: fix BULK request on different available endpoints

It was submitted by me at,
http://marc.info/?l=linux-usb&m=122337227617797&w=2

And the one which is forwarded to you by Felipe is at,
http://marc.info/?l=linux-usb&m=122528597316728&w=2

There is a difference in between above two as below.
Original: + if (best_end < 0 && qh->type == USB_ENDPOINT_XFER_BULK) {
Sent to you: + if (best_end > 0 && qh->type == USB_ENDPOINT_XFER_BULK) {

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

It should be [best_end < 0].

If it is possible then please correct this mismatch in your series.

I'll wait to get a patch from Felipe for this.

I'm seeing it being to you sent at least a week ago -- look for "usb:
musb: fix bug in musb_schedule".

As Felipe is the maintainer of the musb code, and has been batching up patches and sending them on to me when needed, I have only been taking them from him.

So that message is long deleted from my mail, sorry.

thanks,

greg k-h

#5 lore raw
Quoted 22 lines · Greg KH
Quoted 21 lines
Quoted 21 lines
Quoted 12 lines

There is a difference in the musb patch I submitted and the one which actually has been forwarded to you by Felipe. This difference has introduced a bug.

The patch in you series is,
usb: musb: fix BULK request on different available endpoints

It was submitted by me at,
http://marc.info/?l=linux-usb&m=122337227617797&w=2

And the one which is forwarded to you by Felipe is at,
http://marc.info/?l=linux-usb&m=122528597316728&w=2

Quoted 7 lines

There is a difference in between above two as below.
Original: + if (best_end < 0 && qh->type == USB_ENDPOINT_XFER_BULK) {
Sent to you: + if (best_end > 0 && qh->type == USB_ENDPOINT_XFER_BULK) {

It should be [best_end < 0].

If it is possible then please correct this mismatch in your series.

I'll wait to get a patch from Felipe for this.

Quoted 8 lines
Quoted 2 lines

I'm seeing it being to you sent at least a week ago -- look for "usb:
musb: fix bug in musb_schedule".

As Felipe is the maintainer of the musb code, and has been batching up patches and sending them on to me when needed, I have only been taking them from him.

So that message is long deleted from my mail, sorry.

Even though it was a message from him CCing you? :-) Here it is: http://marc.info/?l=linux-usb&m=122605639520312.

Quoted 2 lines

thanks,
greg k-h

WBR, Sergei

author
#6 lore raw
Quoted 29 lines · Sergei Shtylyov
Quoted 26 lines · Greg KH
Quoted 26 lines
Quoted 18 lines
Quoted 17 lines

There is a difference in the musb patch I submitted and the one which actually has been
forwarded to you by Felipe. This difference has introduced a bug.

The patch in you series is,
usb: musb: fix BULK request on different available endpoints

It was submitted by me at,
http://marc.info/?l=linux-usb&m=122337227617797&w=2

And the one which is forwarded to you by Felipe is at,
http://marc.info/?l=linux-usb&m=122528597316728&w=2

There is a difference in between above two as below.
Original: + if (best_end < 0 && qh->type == USB_ENDPOINT_XFER_BULK) {
Sent to you: + if (best_end > 0 && qh->type == USB_ENDPOINT_XFER_BULK)
{

Quoted 5 lines
Quoted 3 lines

It should be [best_end < 0].

If it is possible then please correct this mismatch in your series.

I'll wait to get a patch from Felipe for this.

I'm seeing it being to you sent at least a week ago -- look for "usb:
musb: fix bug in musb_schedule".

Quoted 8 lines
Quoted 5 lines

As Felipe is the maintainer of the musb code, and has been batching up patches and sending them on to me when needed, I have only been taking them from him.

So that message is long deleted from my mail, sorry.

Even though it was a message from him CCing you? :-) Here it is: http://marc.info/?l=linux-usb&m=122605639520312.

Nope, I'm not on the CC: for that message, sorry, check your headers...

thanks,

greg k-h

#7 lore raw
Quoted 13 lines · Greg KH
Quoted 12 lines
Quoted 12 lines
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

It should be [best_end < 0].

If it is possible then please correct this mismatch in your series.

I'll wait to get a patch from Felipe for this.

I'm seeing it being to you sent at least a week ago -- look for "usb:
musb: fix bug in musb_schedule".

As Felipe is the maintainer of the musb code, and has been batching up patches and sending them on to me when needed, I have only been taking them from him.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

So that message is long deleted from my mail, sorry.

Even though it was a message from him CCing you? :-) Here it is: http://marc.info/?l=linux-usb&m=122605639520312.

Nope, I'm not on the CC: for that message, sorry, check your headers...

Sigh, here's an excerpt from its header (note that marc.info doesn't show
CCs at all):

From: Felipe Balbi <[email protected]>
To: [email protected]
Cc: Greg Kroah-Hartman <[email protected]>,
Felipe Balbi <[email protected]>

Quoted 2 lines

thanks,
greg k-h

WBR, Sergei

author
#8 lore raw
Quoted 22 lines · Sergei Shtylyov
Quoted 13 lines · Greg KH
Quoted 12 lines
Quoted 12 lines
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

It should be [best_end < 0].

If it is possible then please correct this mismatch in your series.

I'll wait to get a patch from Felipe for this.

I'm seeing it being to you sent at least a week ago -- look for "usb:
musb: fix bug in musb_schedule".

As Felipe is the maintainer of the musb code, and has been batching up patches and sending them on to me when needed, I have only been taking them from him.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

So that message is long deleted from my mail, sorry.

Even though it was a message from him CCing you? :-) Here it is: http://marc.info/?l=linux-usb&m=122605639520312.

Nope, I'm not on the CC: for that message, sorry, check your headers...

Quoted 7 lines

Sigh, here's an excerpt from its header (note that marc.info doesn't
show CCs at all):

From: Felipe Balbi <[email protected]>
To: [email protected]
Cc: Greg Kroah-Hartman <[email protected]>,
Felipe Balbi <[email protected]>

Odd, digging through my linux-usb archive I see:

	Date: Wed, 12 Nov 2008 17:35:18 +0200
	From: Felipe Balbi <[email protected]>
	To: [email protected]
	Cc: Felipe Balbi <[email protected]>
	Subject: [patch-2.6.28-rc3+ 8/9] usb: musb: fix bug in musb_schedule
	Message-Id: <[email protected]>

Anyway, I didn't realize I should have added it at the time.

I'll wait for Felipe to resend his queue as he said he was going to do.

Ah, if you go back further, now I see it:

	Message-Id: <[email protected]>

Oh well, that got purged after I saw his updated patch queue.

what a mess...

thanks,

greg k-h