ufs: sector_t cannot be negative
PATCH 1/1 ufs: sector_t cannot be negative
From: Roel Kluin <[email protected]>
unsigned i_block,fragment cannot be negative
Signed-off-by Roel Kluin <[email protected]>
Signed-off-by Evgeniy Dushistov <[email protected]>
---
fs/ufs/inode.c +1 -9
@@ -56,9 +56,7 @@ static int ufs_block_to_path(struct inode *inode, sector_t i_block, sector_t offUFSD ("ptrs=uspi->s_apb = %d,double_blocks=%ld \n" ,ptrs,double_blocks); -if (i_block <0 ) { -ufs_warning (inode->i_sb,"ufs_block_to_path" ,"block < 0" ); - }else if (i_block < direct_blocks) { +if (i_block < direct_blocks) { offsets[n++] = i_block; }else if ((i_block -= direct_blocks) < indirect_blocks) { offsets[n++] =UFS_IND_BLOCK ;
@@ -440,8 +438,6 @@ int ufs_getfrag_block(struct inode *inode, sector_t fragment, struct buffer_headlock_kernel ();UFSD ("ENTER, ino %lu, fragment %llu\n" , inode->i_ino, (unsigned long long )fragment); -if (fragment <0 ) - goto abort_negative;if (fragment > ((UFS_NDADDR + uspi->s_apb + uspi->s_2apb + uspi->s_3apb) << uspi->s_fpbshift))
@@ -504,10 +500,6 @@ abort:unlock_kernel ();return err; -abort_negative: -ufs_warning (sb,"ufs_get_block" ,"block < 0" ); - goto abort; - abort_too_big:ufs_warning (sb,"ufs_get_block" ,"block > big" ); goto abort;
Signature · 1 line
/Evgeniy