Skip to contentSkip to conversation

MODULE_UNLOAD should depend on PROC_FS

PATCH In review Américo Wang 2 participants 3 messages Nov 18, 2008 – Nov 19, 2008

lore
Share & tools
lore

Américo Wang

author
#0 lore raw

PATCH 1/1 MODULE_UNLOAD should depend on PROC_FS

The feature controlled by MODULE_UNLOAD uses proc interface, so it should depend on PROC_FS.

Signed-off-by WANG Cong <[email protected]>
Cc Rusty Russell <[email protected]>

---

init/Kconfig +1 -0
index 226da27..fade39e 100644
@@ -871,6 +871,7 @@ config MODULE_FORCE_LOAD
 
 config MODULE_UNLOAD
 	bool "Module unloading"
+	depends on PROC_FS
 	help
 	  Without this option you will not be able to unload any
 	  modules (note that some modules may not be unloadable
#1 lore raw
Quoted 2 lines · On Wednesday 19 November 2008 05:10:52 Américo Wang wrote:

The feature controlled by MODULE_UNLOAD uses proc interface, so it should depend on PROC_FS.

Hi Wang,

This patch looks wrong to me; you can remove modules without /proc. Does
it not compile with CONFIG_MODULE_UNLOAD=y and CONFIG_PROC_FS=n?

Thanks,
Rusty.

author
#2 lore raw
Quoted 9 lines · Rusty Russell
Quoted 2 lines · On Wednesday 19 November 2008 05:10:52 Américo Wang wrote:

The feature controlled by MODULE_UNLOAD uses proc interface, so it should depend on PROC_FS.

Hi Wang,

This patch looks wrong to me; you can remove modules without /proc. Does
it not compile with CONFIG_MODULE_UNLOAD=y and CONFIG_PROC_FS=n?

Thank you, Rusty and Alan!

I think I was wrong. It is compiled fine with the above config, just tested.

Signature · 1 line
"Sometimes the only way to stay sane is to go a little crazy."